From: Shuah Khan <skhan@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>, Shuah Khan <shuah@kernel.org>,
Hangbin Liu <liuhangbin@gmail.com>,
Brendan Jackman <jackmanb@google.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: Fix duplicated test number reporting
Date: Fri, 17 Apr 2026 11:24:15 -0600 [thread overview]
Message-ID: <ab4cea9d-3274-4018-a172-f5399eef1f4f@linuxfoundation.org> (raw)
In-Reply-To: <20260417-selftests-fix-double-number-v1-1-1be5d7c36b94@kernel.org>
On 4/17/26 10:57, Mark Brown wrote:
> Commit 2964f6b816c2 ("selftests: Use ktap helpers for runner.sh") converted
> the prints in runner.sh to use the relevant helpers from ktap_helpers.sh,
> not modifying any of the strings printed in the process. This included
> converting all the result reports to use the relevant ktap_test_ function.
> Since the output was originally KTAP compliant the strings reported for
> test names now include test numbers:
>
> ok 59 59 selftests: arm64: syscall-abi
>
> instead of the expected format:
>
> ok 59 selftests: arm64: syscall-abi
>
> which causes result parsers to interpret the second number as part of the
> test name.
>
> Given the use of the helpers the tracking of test numbers by runner.sh is
> now redundant, remove it entirely to restore the expected output format.
>
> Fixes: 2964f6b816c2 ("selftests: Use ktap helpers for runner.sh")
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
That was quick - I applied this one also to linux-kselftest next.
I will send one pr with all 4 fixes tomorrow.
thanks,
-- Shuah
prev parent reply other threads:[~2026-04-17 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 16:57 Mark Brown
2026-04-17 17:24 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab4cea9d-3274-4018-a172-f5399eef1f4f@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=jackmanb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®