From: Florian Fainelli <f.fainelli@gmail.com>
To: "Michal Vokáč" <michal.vokac@ysoft.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: Do not configure VLAN ID 0
Date: Fri, 1 Mar 2019 09:54:07 -0800 [thread overview]
Message-ID: <ab4f9ea2-f108-1538-3a98-dd03d3657a16@gmail.com> (raw)
In-Reply-To: <2f23dc48-a042-4fcf-cc5b-11d247061239@gmail.com>
On 3/1/19 9:52 AM, Florian Fainelli wrote:
[snip]
>> Tested-by: Michal Vokáč <michal.vokac@ysoft.com>
>>
>> I am not sure what was the original problem as I could not find the
>> thread where Heiner reported the issue but with the latest version
>> next-20190228 I get this error with QCA8334 switch:
>
> Thanks Michal. There is still a lingering issue though, because we
> currently skip the prepare phase (we don't have a switchdev_trans
> structure that would make sense here), we are not checking that the
> underlying switch device driver does actually support
> port_vlan_add/port_vlan_del, and qca8k currently does not. I will submit
> a v2 patch that also takes care of that.
David, please discard this version, I will submit a version that
properly emulates the prepare/commit phase such that no assumptions are
broken, this will take care of both issues at once. Thanks!
--
Florian
next prev parent reply other threads:[~2019-03-01 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 23:49 Florian Fainelli
2019-03-01 6:14 ` Heiner Kallweit
2019-03-01 10:34 ` Michal Vokáč
2019-03-01 17:52 ` Florian Fainelli
2019-03-01 17:54 ` Florian Fainelli [this message]
2019-03-01 20:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab4f9ea2-f108-1538-3a98-dd03d3657a16@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.vokac@ysoft.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®