mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
	"kbuild@lists.01.org" <kbuild@lists.01.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mchehab+samsung@kernel.org" <mchehab+samsung@kernel.org>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"phil.edworthy@renesas.com" <phil.edworthy@renesas.com>,
	"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
	"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lee.jones@linaro.org" <lee.jones@linaro.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"pavel@ucw.cz" <pavel@ucw.cz>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"dmurphy@ti.com" <dmurphy@ti.com>,
	"jeffrey.t.kirsher@intel.com" <jeffrey.t.kirsher@intel.com>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	"hofrat@osadl.org" <hofrat@osadl.org>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>,
	"wsa+renesas@sang-engineering.com"
	<wsa+renesas@sang-engineering.com>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v4 15/16] leds: Add common LED binding parsing support to LED class/core
Date: Mon, 18 Nov 2019 06:34:12 +0000	[thread overview]
Message-ID: <ab534cb686f94f32d8fadc2534ebbb1772b57dee.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20191118055941.GB1776@kadam>

Hello All,

On Mon, 2019-11-18 at 08:59 +0300, Dan Carpenter wrote:
> Hi Matti,
> 
> [auto build test WARNING on 31f4f5b495a62c9a8b15b1c3581acd5efeb9af8c]
> 
> url:    
> https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Support-ROHM-BD71828-PMIC/20191117-030515
> base:    31f4f5b495a62c9a8b15b1c3581acd5efeb9af8c
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> smatch warnings:
> drivers/leds/led-core.c:400 fw_is_match() error: uninitialized symbol
> 'ret'.
> drivers/leds/led-core.c:465 led_find_fwnode() error: double free of
> 'val'

Ouch. The free is clearly a leftover from original code where the
"is_match" was not it's own function. Sorry folks. I'll fix both issues
and send new version.

By the way, I'd appreciate if someone else would also check the
reference-counting for fwnodes - is pumping up the refcount in
led_find_fwnode Ok? My idea is that when-ever the led_find_fwnode
returns an fwnode, the LED class needs to decrease refcount when LED is
unregistered. No matter if fwnode was from device, given by LED driver
or found by the LED class.

Br,
	Matti Vaittinen



  reply	other threads:[~2019-11-18  6:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-16 18:55 [PATCH v4 00/16] Support ROHM BD71828 PMIC Matti Vaittinen
2019-11-16 18:55 ` [PATCH v4 01/16] dt-bindings: regulator: Document ROHM BD71282 regulator bindings Matti Vaittinen
2019-11-16 18:56 ` [PATCH v4 02/16] dt-bindings: leds: ROHM BD71282 PMIC LED driver Matti Vaittinen
2019-11-16 18:56 ` [PATCH v4 03/16] dt-bindings: mfd: Document ROHM BD71828 bindings Matti Vaittinen
2019-11-16 18:57 ` [PATCH v4 04/16] mfd: rohm PMICs - use platform_device_id to match MFD sub-devices Matti Vaittinen
2019-11-16 18:57 ` [PATCH v4 05/16] mfd: bd71828: Support ROHM BD71828 PMIC - core Matti Vaittinen
2019-11-16 18:58 ` [PATCH v4 06/16] mfd: input: bd71828: Add power-key support Matti Vaittinen
2019-11-16 18:58 ` [PATCH v4 07/16] clk: bd718x7: Support ROHM BD71828 clk block Matti Vaittinen
2019-11-16 18:59 ` [PATCH v4 08/16] regulator: bd718x7: Split driver to common and bd718x7 specific parts Matti Vaittinen
2019-11-16 18:59 ` [PATCH v4 09/16] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators Matti Vaittinen
2019-11-16 18:59 ` [PATCH v4 10/16] gpio: devres: Add devm_gpiod_get_parent_array Matti Vaittinen
2019-11-16 19:00 ` [PATCH v4 11/16] docs: driver-model: Add missing managed GPIO array get functions Matti Vaittinen
2019-11-16 19:00 ` [PATCH v4 12/16] regulator: bd71828: Add GPIO based run-level control for regulators Matti Vaittinen
2019-11-16 19:01 ` [PATCH v4 13/16] rtc: bd70528 add BD71828 support Matti Vaittinen
2019-11-16 19:01 ` [PATCH v4 14/16] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs Matti Vaittinen
2019-11-16 19:02 ` [PATCH v4 15/16] leds: Add common LED binding parsing support to LED class/core Matti Vaittinen
2019-11-18  5:59   ` Dan Carpenter
2019-11-18  6:34     ` Vaittinen, Matti [this message]
2019-11-16 19:02 ` [PATCH v4 16/16] led: bd71828: Support LED outputs on ROHM BD71828 PMIC Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab534cb686f94f32d8fadc2534ebbb1772b57dee.camel@fi.rohmeurope.com \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=broonie@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dan.carpenter@oracle.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=hkallweit1@gmail.com \
    --cc=hofrat@osadl.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pavel@ucw.cz \
    --cc=phil.edworthy@renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®