From: Daniel Gomez <da.gomez@kernel.org>
To: Kees Cook <kees@kernel.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: "Luis Chamberlain" <mcgrof@kernel.org>,
"Malcolm Priestley" <tvboxspy@gmail.com>,
"Hans Verkuil" <hverkuil@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rusty Russell" <rusty@rustcorp.com.au>,
"Petr Pavlu" <petr.pavlu@suse.com>,
"Sami Tolvanen" <samitolvanen@google.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-modules@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 0/3] module: Add compile-time check for embedded NUL characters
Date: Tue, 4 Nov 2025 07:35:19 +0100 [thread overview]
Message-ID: <ab56339a-8736-4d68-bf11-d27c8d591597@kernel.org> (raw)
In-Reply-To: <202511031612.8A05E2FD1C@keescook>
On 04/11/2025 01.13, Kees Cook wrote:
> On Mon, Nov 03, 2025 at 08:49:43PM +0100, Daniel Gomez wrote:
>>
>> On Thu, 09 Oct 2025 20:06:06 -0700, Kees Cook wrote:
>>> v2:
>>> - use static_assert instead of _Static_assert
>>> - add Hans's Reviewed-by's
>>> v1: https://lore.kernel.org/lkml/20251008033844.work.801-kees@kernel.org/
>>>
>>> Hi!
>>>
>>> [...]
>>
>> Applied patch 3, thanks!
>>
>> [3/3] module: Add compile-time check for embedded NUL characters
>> commit: 913359754ea821c4d6f6a77e0449b29984099663
>
> I'm nervous about this going in alone -- it breaks allmodconfig builds
> without the media fixes. My intention was to have the media fixes land
> first...
>
> Should I send the media fixes to linus right away?
>
> -Kees
>
I can take both patches. But I think it'd make sense to drop patch 3 first and
then, apply all 3.
Please, Kees, Hans and Mauro, let me know if this is okay with you.
next prev parent reply other threads:[~2025-11-04 6:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 3:06 Kees Cook
2025-10-10 3:06 ` [PATCH v2 1/3] media: dvb-usb-v2: lmedm04: Fix firmware macro definitions Kees Cook
2025-10-10 7:10 ` Mauro Carvalho Chehab
2025-10-10 3:06 ` [PATCH v2 2/3] media: radio: si470x: Fix DRIVER_AUTHOR macro definition Kees Cook
2025-10-10 7:10 ` Mauro Carvalho Chehab
2025-10-10 3:06 ` [PATCH v2 3/3] module: Add compile-time check for embedded NUL characters Kees Cook
2025-10-10 4:19 ` Petr Pavlu
2025-10-21 2:05 ` Aaron Tomlin
2025-11-03 8:54 ` Hans Verkuil
2025-11-03 8:58 ` Daniel Gomez
2025-11-03 9:05 ` Hans Verkuil
2025-12-19 12:29 ` Matthieu Baerts
2025-12-19 12:41 ` Daniel Gomez
2025-12-19 12:44 ` Dan Carpenter
2025-12-19 14:59 ` Matthieu Baerts
2026-01-16 23:35 ` Chris Li
2025-11-03 19:49 ` [PATCH v2 0/3] " Daniel Gomez
2025-11-04 0:13 ` Kees Cook
2025-11-04 6:35 ` Daniel Gomez [this message]
2025-11-04 10:35 ` Hans Verkuil
2025-11-04 12:03 ` Daniel Gomez
2025-11-04 20:35 ` Daniel Gomez
2025-11-04 20:59 ` Hans Verkuil
2025-11-05 13:03 ` Daniel Gomez
2025-11-05 13:06 ` Daniel Gomez
2025-11-11 11:42 ` Andy Shevchenko
2025-11-11 12:34 ` Daniel Gomez
2025-11-11 17:52 ` Uwe Kleine-König
2025-11-05 13:19 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab56339a-8736-4d68-bf11-d27c8d591597@kernel.org \
--to=da.gomez@kernel.org \
--cc=hverkuil+cisco@kernel.org \
--cc=hverkuil@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rusty@rustcorp.com.au \
--cc=samitolvanen@google.com \
--cc=tvboxspy@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®