From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BB4A1925BC for ; Sat, 21 Mar 2026 07:19:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774077561; cv=none; b=FIOAJ+rr+mDlyQJQjf+uVG1JEDZdSM76QsKiCGsebGmbwQXn0OgJmxWBuiZeqYHaNkNcCBouHn6MFQWfkwyhgsQjnUmAaKlYk+HebgEbqvWkZZ9jxYIei8h4M2CoUdA78GZ29JDStlDQwZxwpVQ+GHY7H4ZWdL62lkYPNg3Eglk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774077561; c=relaxed/simple; bh=YLUV4AaDj19VK+8BgD/sfoI7peLDKO9901h8/c4y6vI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kGXfxC/99dDz3yV0SjMA2SUdLvYUZY8tqoNO2z2YMBUPlzcmnqmDRsIinxVtTTFEbW6v3ljQ5yACLvMCYTbT7o3sFE2NXmQmb3+pZu74FsZGuZuvbJS7gG1g7fDojyqCOrkXX8OTKjIyKOBa0wdisIkNaakb7QnlSOsnBjQzQEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NK1fU0On; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NK1fU0On" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-48374014a77so24750185e9.3 for ; Sat, 21 Mar 2026 00:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774077559; x=1774682359; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tYv8NSPDpZJ95g8FVV342Y3MV0/TZZYtvHbpGnN4m+w=; b=NK1fU0OnQFDbH6J7IYTyP3D5hr20a42z6aJ2yoveEOZfstiM+HeLQ9h7XUUL0/0wkd y+W6k5QAboPFNaYU8eQDl5b4mB6LsLHlXRyynN7vFJ8tCKBEm/4ZDnKRsesjvoCs0L+9 zelqMG8DZkLbmm8ypqf3CMfsa2a+zFCzpGibKr4T8rxZa3uDkHW3AhzpRua6+ix9sic3 Una6bRv1dYhFPAtX5seRefpVaAYSAyYzSDlLnkQR0ebtsq2NbiQSLKyNuFETAtHkr0du JCtZ4WxgN+M4nrm2Uo/ccL/Aazs/fUzoce92DSfoBl8TqHQs9Q+3mJ/KuZyQI6ycMvln a7uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774077559; x=1774682359; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tYv8NSPDpZJ95g8FVV342Y3MV0/TZZYtvHbpGnN4m+w=; b=QK2USTrc4kbhW9A244M/svy6/9fUy7sbqQCyNZ1Wjp2muuMO8RzgOCvsGD3aDqgzkK Q4Ohu24ia8Un2ts5yFP++jQprMCSVpuNid7JBavoCLPqHQgEgoIqWLKGQnAMrgtOjRaf bwrfwrTk1T3gn2x5w4V19SZRyCaWadlr5WIzLT8xkZ0v9r3kFGyhMbAGVbRILlCDE+g0 ui1xeLt8YdBIu8+VsdPne7l8sc0aXZY7WOtCl4/vBGtpvY7LmmDDhhQxW7iWeItG8akP 8KQq8u36atEwvh/QRYDWytKRHAobFWmI+0k6ui37Kr6TaV0F/pTn50yk3ouZfl/qXncd bYEQ== X-Forwarded-Encrypted: i=1; AJvYcCWDJ2esZDefg3kPY+nnQArsLKm8SZRSPzsbaRj8PkckeAoEM0kip2YSwyovP5cCKEMkM3pgvKdCrjbWbfs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7w1bFMxZjZNxwpsQBSjfy1zNCKTyLTum5RjzA/uXbHPP0/tF+ /oFrFGt5E+CRBO4Lo/gi2Ofq41crFfW6WEsUJ7At+vR0P/QGlZ4LUdi/Ki4w3jpp7m0= X-Gm-Gg: ATEYQzwBVNl3RNWdKbMyYKbZsXIYBN1CxQx3LjYQJiEH02OA9knrlB5TaFJ2C3h2/z4 Al99r08ewnlwtiSwUs/kp/XdlYVVEQSflU4eG+pjUe/4D08IsgftU/whRnPQs3tlyE9BTEFD/aA xwNFH3Q4BmUOIUKUYaWNP6zRLXsBxSL2Mzh/bBsk4nyx3dTamXTSWzOmH97aD3pEt1ywB7H96BS 8rhvJCtvLHjkqnYJiR6PCVAq5W4xHy1kfMQL3qjyh5l1DcyRwlLmjAntOkXEpd40kvKOgSLHoul HZxngxXEmlVOvFtY4qADFsjH+o0dMCsDBEiRP0U1XkJB7GPs3948qMW3+/MweuP3TyFHIlqNpoQ IEXGy/Fo6/dTmmExfTUOTgK2NhcXnHKXsaU9oLVKZ6O5k3Ieb2o3b53fuHYzy/ars5GWE5CvXB1 j1hDWDjm98BqUnqFy8DT8/kESFOH3B X-Received: by 2002:a05:600c:1f0e:b0:486:fe23:1707 with SMTP id 5b1f17b1804b1-486fee08a04mr74936475e9.20.1774077558381; Sat, 21 Mar 2026 00:19:18 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b6471a297sm13050436f8f.37.2026.03.21.00.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 00:19:17 -0700 (PDT) Date: Sat, 21 Mar 2026 10:19:14 +0300 From: Dan Carpenter To: Sungwoo Kim Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Mike Christie , "Martin K. Petersen" , Hannes Reinecke , Chao Shi , Weidong Zhu , Dave Tian , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Harshit Mogalapalli Subject: Re: [PATCH v2] nvme: fix memory allocation in nvme_pr_read_keys() Message-ID: References: <20260228001927.382810-3-iam@sung-woo.kim> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Ah, yes. You're right. It's the nonsense: if (rse_len > U32_MAX) return -EINVAL; check which confused me. Commit a58383fa45c7 ("block: add allocation size check in blkdev_pr_read_keys()") caps num_keys at 65536 so the rse_len can't be more than 4MB which is less than INT_MAX (2GB). We could remove that check. I will send a patch to do that. regards, dan carpenter