From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B4942C3244 for ; Sat, 21 Mar 2026 07:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774079214; cv=none; b=I3y1mwVTUAGFU8H1mehcLPfv9sDVsiYjDQPbFBVHMQ9jGd3ytYqZSLH8QwhuTiDH8WI0sN2UtNgkwENoR521eNeJ1D9AM2W3Il1g/zLFG41LXliZcfMtt0sjHUi+b3lzyfir+GpCsDnQZ1t4G2LWV63EphSYLhg5mXF+yG1NnRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774079214; c=relaxed/simple; bh=p6yx8lVUTF073ZPW8VGoM15AxO32qRR9RZi9yjS0K38=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R90XfF75UegHTk3uyeHnl6Idv/5buTSwqOJxKl45v2W8ItOjCiKqIeVbEkCU+FIwj0JBTsTiwk+RGbmd0KZ3TNdk8KhYQy6QIRj5AWh5Ju7mcFmDUP39YMVTkn6T2phRwNSW3QNz8Sl3PKlxBKShm01Pkw7btSpGHazDdS6TaGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yj3fsBNL; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yj3fsBNL" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-486507134e4so31530455e9.0 for ; Sat, 21 Mar 2026 00:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774079212; x=1774684012; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ubEwMaEuXbkyO+Lyt1mqbUhXR8pB9gr1IB+DXkw3SYk=; b=yj3fsBNL1jcJazuVnUBM2m68SkJHrfO26LYdOXIjhuP9FX2AcF2uHqE5wi5E1HgUZ7 pG/PI3wjxCycL5OENg1yAUzz1ibmunx/RrJNiQHZLMuX5k9GdJkTzFwQZ8ayBwITbQxe /t+aw+7CXk3uSNdPjTrmCED4DPXh2qHKE8rOfJdf8RtX3mF/snrrnGeUV2IRP71FcU1+ 5+i4FpYu0E9UIQPgnhYLqgbj8Jsl3nZVuNtH461I/AvjApK86hsRADbatjachnNZOuJx 0sxfDiQY/+JObY6yP1nukTY0LRL8A6Gs72E/df5XwcDFg9G5LObXf9VN9VhYp5RD3uwL 3/7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774079212; x=1774684012; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ubEwMaEuXbkyO+Lyt1mqbUhXR8pB9gr1IB+DXkw3SYk=; b=gWSFFpmSLINN6Vjm3fYGHW281+Fm3IqjenGeu4zMGpukgV5c6n8sTH/PaSNDK85+Xa konA3TkOL1oCllQSEdHOPqs+HpieLhCJOEdxsw2FssZqaoVY/2YNCalhZIdYmPQ9buIN mfrje+rMoB9ovkkomJpCV58bxAbnT6yNVv3ojpftoW6JR3LY/X4vmLfaMlXOqhBgCmES 5EuBk0EEHZznmfFv0PPniamUnE6Fdp8g7tRvyxnR7ndbEIsTQxb5iXs/k03l+4hQOW7a DyivHTbhVdhjwoAx5foERd8EhZZlW17BPnqqgViPP8InI/gBu49ch8ikmvj4n6J05JCA 6Waw== X-Forwarded-Encrypted: i=1; AJvYcCWxjYvnXOZkStrYiZVp2JYaM1Vg53VIOrGdcvV/rqFz9SqYEZYkUujI2LvnN+RMdG7diPOpnEGpBKfcam0=@vger.kernel.org X-Gm-Message-State: AOJu0YwWRjan0tMErVdy1HVfez5uE4aXLwaxt8I75bUTkfyFXN7Xnvf1 C7sXOh2Hf8waniTC0OvZXotS+So6eig5IKPK7JKVZA62/DU3UhiamYivUOgm7MnpbU4= X-Gm-Gg: ATEYQzyf0DuXLyt3Rv3efeQDPYg/AQ1ta7puwixL6fExBIYZCORt2rOQMieMUtO+Hjs jLM/HNlUkvo5VcrYASeGeHa4HgOagQAZAXCJ4a6yB+oeyEbXasmzg8bV8SThpXYvL7euI8Zge8K bkDqw2L2pXYY7wKpUvF/4cqF6m9O/4xfomcRYFlMHQPxS0fKWRXh4zfZXVjat9ufrWZWx5xsHdB jLhGWMtfZ8xnRaDKaEk54I1kQGepDwoQFt51x0Sv2idozbVk0anS0ArdNll0DGS9eHsMCSmUA8j X8hHT3WZpWeMFYHYy+0mdgA+cVybpI8HcUFNOyJJ1nsyWKsJE7V+1yTafPyQCapn15xJItaGFjV M8uzrVkULX1UmF+bbUlh55rFEA1yNlXb3kOokjkLQSDM6XxsOb8PHF+/Z+4/ZiLjL6DjRRrTo/Y 7no81BhOxP9JSRV3l9Q1byZpSK6onX X-Received: by 2002:a05:600c:3549:b0:485:363b:fafe with SMTP id 5b1f17b1804b1-486fedab866mr76426165e9.1.1774079211920; Sat, 21 Mar 2026 00:46:51 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe032a55sm223880405e9.7.2026.03.21.00.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 00:46:51 -0700 (PDT) Date: Sat, 21 Mar 2026 10:46:48 +0300 From: Dan Carpenter To: "Jose A. Perez de Azpillaga" Cc: linux-staging@lists.linux.dev, Greg Kroah-Hartman , Michael Straube , Hans de Goede , Khushal Chitturi , Ethan Tidmore , Luka Gejak , Vivek BalachandharTN , Artur Stupa , Zhuoheng Li , Nino Zhang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] staging: rtl8723bs: refactor rtw_joinbss_event_prehandle to reduce indentation Message-ID: References: <20260320154724.603847-1-azpijr@gmail.com> <20260320154724.603847-3-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260320154724.603847-3-azpijr@gmail.com> On Fri, Mar 20, 2026 at 04:47:17PM +0100, Jose A. Perez de Azpillaga wrote: > -ignore_joinbss_callback: > + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); > > spin_unlock_bh(&pmlmepriv->lock); > + /* s5. Cancel assoc_timer */ > + timer_delete_sync(&pmlmepriv->assoc_timer); > + return; > } So close... But you can't end a void function with a return statement. It causes a checkpatch warning. KTODO: Fix checkpatch to catch extra void statements Checkpatch will catch an unnecessary return statement like this when people use the -f option, but why can't it catch it for normal patches? Surely, if there is a line which is just "}" then we could just print a warning if the previous line is "return;"? Test this on commits in the git log to find if there is a non-obvious reason why it only works for -f. regards, dan carpenter