From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E34825B31D for ; Sat, 21 Mar 2026 07:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774079341; cv=none; b=kvgLnahrneT7x8RM+eE7PShGloj8ZE1+P0dsrug7hKeV71SQgs/AZ4NGs2Q4lnPwEB/mXDuzM6kR5suctmQe86OfAmVv0s0fv8zGP1Axer2Lt3lioo31BAW0neulmR61yNJwNp7eHh25J0AJElh5aibixZKjCCLGksATeYH76Hw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774079341; c=relaxed/simple; bh=BxDWW2LjJoKTs4lYmbValHKuQvjsGTWftMpDcB7UMy0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LKWQDoFey/verNdi2RaOeOgZCxg296R4lDOpFwmO2/WCHVh1IumyDHAMfa55ZI3WT2ayQanohsnP8OqizPN8rKH+3cHXIwaMRTM+AEdeNEglP54PWMQpKtomxnYBjFRJ5KQ4TYF1Ov2Jj3LFabXSTZAVFGkt76+CfnAU9VFiuoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JTbxRZmH; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JTbxRZmH" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4853c1ca73aso23550325e9.2 for ; Sat, 21 Mar 2026 00:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774079339; x=1774684139; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Fo8jQCnWVOp5Mp7yfQ+5Hl/xgbWT4Hf5m1bOCKXA/8g=; b=JTbxRZmHs+UD3BkNWxoVbvA5MMDtGT6x1e0aXAL2/6lCCoJ5Q+gQYiaK4U0thPI6+U 4ydv4epeOKc8AHM2yv5y8Dca8GkvsL1iRF20uyhFnOMYk2G79N41tT45rC+PC60Fg4C7 NTECbYDPWDXnfkGipgfxfYqOCRgiJ4vaZXCXKygpUi7S8u/YmEKjfhi8erUTaWpog+qC HSpwkijyuUSFihtTubWYoz3Jweil8CtTywCZqTYj6RpX2eY6PfTXAlWXYTgN6aqbInJ/ eQDb1w6KC+KnI0a2ZAy6r5cXJ1dzk49zxzuO/ILH/5BbsuKhUG0fz8P0eIY8SvKEmdSV 0aXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774079339; x=1774684139; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fo8jQCnWVOp5Mp7yfQ+5Hl/xgbWT4Hf5m1bOCKXA/8g=; b=avqBBcGGZNtyPeG8O2mvA87Kb0BzVX68Vt0J1hSSo+i+s0VsQ4hzgwMrhw9uAiqqeg sVUM7L65eY5upOfpcomQBfWwlU/FCZMVvafRzL7htYx+77IuMsLN/+nk3zMfEdD9xY3/ QJ+Xa7yvv7pYvi1+SvPK/d9AcrPvefaOrApDTo+CTdARweMuV6/K0g8OC1QP5kOAy6/m kbzAjz21iBRquCVFtm63tK2iglSInFAKDp2hE4MRl0orDwYKWkUrazXkdmNPsmfSNgBj x6mOYkIW7/KeDZjsPrPfNjnL3PsNlwIRRwB8L4iOKEXw6jduV62TFEZU/W4y34qtThHS ckeQ== X-Forwarded-Encrypted: i=1; AJvYcCWxijLPSiJUv+HLrZ7OeaS4IZKqn+vRGIr7BgaOWhZxs5WqZK4oGpqAJqtkfHZnyYmrr5Mwif9m5PkhJag=@vger.kernel.org X-Gm-Message-State: AOJu0YxumReR7YmS+T8XLH0E/vNbTyzZK/OKTBvoNtPp6FGUFZYpsnl0 ffRNzFzxa9IAAudTaYVcGOTFAOwejFi5n+pUkTTMIDosEhz+DUAv1iU3bg3KuV6XRVE= X-Gm-Gg: ATEYQzyV/yuTmozlE4wZw/+wFAGpM8MfSFiArtUgLzTFylKaSkPcDzy+rO+whVOtEZN wkEVC7j/cCgcaUGspPqIt882hKO2hTgT5wLPg6ZIovkYnDLTVMBVXTLnA0yltnGZ8gAKljW0Vfa 8I3Z57WSOJZHEU7520pB6aYsrgAFSlzdk1qJuVUGaPA9rsHiWQPrePRyYj9Wl6OIECk0qnlZ2tK Jus5kF76fk4lIlhWgTNAPkMdU7SvDmP7Q2Bf07qlb/Sj2I9vM6PsBhR6wxG5U8akYst+QDREzsz 21Id3mlcv3DGDKw3xK2Ncvj21gX0934WfuREPJwTX+Z2tE6g5o4+Jb5rfHQeLx8/VOQ81JUaAU4 +KzCc7uvQAylMrJvU4lwFN+XwPI4hei8WpaXjfldl2qNlRvjVyvtbZNa2TSFvwKToQ+eh3og+cW upYnJbG9yrg96iyXyMvHDDSLQK7bgu X-Received: by 2002:a05:600c:3495:b0:485:3b00:f939 with SMTP id 5b1f17b1804b1-486fedf6b7amr83708215e9.8.1774079338901; Sat, 21 Mar 2026 00:48:58 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe8367d8sm147894975e9.14.2026.03.21.00.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 00:48:58 -0700 (PDT) Date: Sat, 21 Mar 2026 10:48:55 +0300 From: Dan Carpenter To: "Jose A. Perez de Azpillaga" Cc: linux-staging@lists.linux.dev, Greg Kroah-Hartman , Michael Straube , Hans de Goede , Khushal Chitturi , Ethan Tidmore , Luka Gejak , Vivek BalachandharTN , Artur Stupa , Zhuoheng Li , Nino Zhang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] staging: rtl8723bs: refactor rtw_joinbss_event_prehandle to reduce indentation Message-ID: References: <20260320154724.603847-1-azpijr@gmail.com> <20260320154724.603847-3-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Mar 21, 2026 at 10:46:48AM +0300, Dan Carpenter wrote: > KTODO: Fix checkpatch to catch extra void statements > > Checkpatch will catch an unnecessary return statement like this when > people use the -f option, but why can't it catch it for normal patches? > Surely, if there is a line which is just "}" then we could just print > a warning if the previous line is "return;"? > > Test this on commits in the git log to find if there is a non-obvious > reason why it only works for -f. (This was not intended for you Jose, I'm trying to create a TODO list for kernel janitors to work on so I put KTODO in the email so people looking for things to do can find it on lore). regards, dan carpenter