From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AD19346AFB for ; Sat, 21 Mar 2026 07:58:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774079883; cv=none; b=czm87cM1+nl95CGaGX1P50KQKCWQ2z7lTwfA9v6ZB2aa7Xanseae9I3JR3srcCi4ZpUTWXwIdqknTm7H4cFVrfWVq4R0mOwnS90aqDOAPfL4fMd6TDmSQ3xtjpWCxGyHGK29OoGdRGbgCl0TWzZG8dVGPlgcMBfsBQr5dmel4tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774079883; c=relaxed/simple; bh=xC6TFvSRt5n+yCR5ZAsOK5Kj1fNNYaM8HoB22Mmr47A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZArEUr7FBCVmp2lbChlywEnQ0ZtANW1ZsT5HkkFEIpvftvV3yKS+0vEqFur+vtw6H04DNp2M0Mq2nwLfhs+x3QF3aM2dUi2eNavnhChC7hLV6TSZw3NrVbr3JyFo7j2vqE63DrA4pt2ykRixBka01dLe6cU2cpGd2H0UWJ8dzhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gEzRZk/q; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gEzRZk/q" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-439b2965d4bso886102f8f.2 for ; Sat, 21 Mar 2026 00:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774079881; x=1774684681; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/feQgsbf2sd9ZVef0q1kRuYMHLLA9XdF8QHnZq52BVc=; b=gEzRZk/qGZPMa9ofRq+kixDNR9FCTUeUnTZnm17AK5UmNKzxtwkHU/wMtvl7xrlipg NxEc8kgCwC1vvETd8LUhEgxc1fuUe6V1zV9c5j3CFCO/mEdV9LpCM8gctlGhOdqUw3Br fSS6mqAu78eUXdNDfKhyOM3/8fiIEQBMOWX0Du7D8sagUXQNVWiGRgqrobzwg82H+KhG ErkoRqxkvc3CRS9G48f8qqfr0eDB7hPkqNuVWI9lK6BpM6pWpHHxfkoe2aAX1rgiEixW VNbJRb/WqKsNCfYLTQMnP/8He8yIrnaBUa2U4dFUX02yBqFwpo89t6on59OQWNrz0GVt dz+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774079881; x=1774684681; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/feQgsbf2sd9ZVef0q1kRuYMHLLA9XdF8QHnZq52BVc=; b=HBFuT4mqLB1yzH3d4fnvck4TvjK0FCOnB7R0yrDzNkMN6eS4nGP5Kfso0PHrdszMJp /CgMbDPkbhO1aVUt/w7/1P2us6jd3L40FSUFCYxKADUM3IuJnTh0QPDFWjkvwIIhQwjb v0IJdpdOXy0MseJSNuxoS7d7xxBWUZYFx45zYVewbPTNipSSF6DfxK055A8Q0HEnNxt0 gcg7D5Ma9kH8ZwDMv/TrblF9vC5ai4ewlbz4T1ZOWDQJ379e15ZBdYO9jNL2j8x1pdz0 FWojkaQ4g0HzWxo1b8MtCRFkHRUg9hohW9UDQUnxphyNq5TMqbypj9YBwQxmWvfXTEf0 Sedg== X-Forwarded-Encrypted: i=1; AJvYcCXpH1Z2YD/VPxF72aadclKIcKT2/kSVw2VCleYZSdxuZ01g6fghH/G80qyYgYrhAwNYhuY2Fqo2bsL0N5w=@vger.kernel.org X-Gm-Message-State: AOJu0YzFmOfYWuscxGXdhDYjWQYGrWUd7fcWJTO3Ifj+CTzye4gy4zct VdyOZp2p6F4GKOkVHggqH2m/ssRXSCO1+or6URlOpSL2/fT5T31Xgo8kThs/o54uaPc= X-Gm-Gg: ATEYQzw9hBMdjHhcB73QdqK8gj/GCqqsz53KI2/9zSgoWKoRCerq8XOizsO1mE/jlqh 8iyxvka4ZOUsFlDKZyAPNhf1cqB4N1eFMeLHfcay9QXteS4RuLvtYm+9DAHP6R6jX4lQnzBXKGe ym3qB0XLu11HnylYRIJLqL1cpWXEI5FErzPqC6pzfkqjvPLV+/uRbEpVSXyWhzozb7Wu+iI8MT1 L5B3jCkhzqPkB73IfIuX9w6J4RPNagQhcLnUtRkWSmGRjqrpwx2C4pk4dFylKcvqwITM55vI+Rh QGOxZmpj/FU4CM60NwB/GR1irepM94k3hOUcEfKN11Edoj38t3/3Mh9yzsWsFwoNhYKCXodFbhK 98Uepn1IEqHGddmDwrT3mazzm/R0pPf9MZI0CTTSbxlbC6O40xrUmnLhb/mlq7YFdVXtVVQB1+c btxtwCa3eBSJa2ulwRLgOz6Cfjnjym X-Received: by 2002:a05:600c:a43:b0:486:fbd1:9dc0 with SMTP id 5b1f17b1804b1-486fee0d52fmr75025545e9.22.1774079880894; Sat, 21 Mar 2026 00:58:00 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486f8b949e1sm322295655e9.9.2026.03.21.00.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 00:58:00 -0700 (PDT) Date: Sat, 21 Mar 2026 10:57:57 +0300 From: Dan Carpenter To: Greg KH Cc: Lin YuChen , straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: initialize le_tmp64 in rtw_BIP_verify() Message-ID: References: <20260320172502.167332-1-starpt.official@gmail.com> <2026032035-opulently-cupbearer-820b@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026032035-opulently-cupbearer-820b@gregkh> On Fri, Mar 20, 2026 at 06:29:13PM +0100, Greg KH wrote: > On Sat, Mar 21, 2026 at 01:25:02AM +0800, Lin YuChen wrote: > > Initialize le_tmp64 to zero in rtw_BIP_verify() to prevent using > > uninitialized data. > > > > Smatch warns that only 6 bytes are copied to this 8-byte (u64) > > variable, leaving the last two bytes uninitialized: > > > > drivers/staging/rtl8723bs/core/rtw_security.c:1308 rtw_BIP_verify() > > warn: not copying enough bytes for '&le_tmp64' (8 vs 6 bytes) > > > > Initializing the variable at the start of the function fixes this > > warning and ensures predictable behavior. > > Which makes me wonder how this ever worked at all, if random data was in > those 2 bytes. These days, everyone sane zeroes their stack variables, but this driver is older than the zeroing code so it's a puzzling thing. I could imagine a couple different ways that the code might be able to work even with uninitialized data... It wouldn't surprise me if the check for: /* BIP packet number should bigger than previous BIP packet */ is some kind of work around for bug? regards, dan carpenter