Re: [PATCH 3/4] media: rcar-isp: ispcore: Look at number of planes when programming

["Barnabás Pőcze" <barnabas.pocze@ideasonboard.com>]

2026. 10. 19. 21:35 keltezéssel, Niklas Söderlund írta:
> Instead of expanding a list of formats that uses two planes look at the
> format information directly.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>   drivers/media/platform/renesas/rcar-isp/core.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/rcar-isp/core.c b/drivers/media/platform/renesas/rcar-isp/core.c
> index 3e135e84b75b..cb9d9033d0cf 100644
> --- a/drivers/media/platform/renesas/rcar-isp/core.c
> +++ b/drivers/media/platform/renesas/rcar-isp/core.c
> @@ -126,8 +126,7 @@ static void risp_core_job_run_output(struct rcar_isp_core *core,
>   		mem = vb2_dma_contig_plane_dma_addr(&buf->vb.vb2_buf, 0);
>   		risp_core_write(core, reg, mem);
>   
> -		/* Only NV16 uses 2 planes. */
> -		if (fmt->fmt.pix_mp.pixelformat != V4L2_PIX_FMT_NV16M)
> +		if (fmt->fmt.pix_mp.num_planes != 2)
>   			continue;

Looks reasonable to me. Maybe `< 2` would be more future proof?

Reviewed-by: Barnabás Pőcze <barnabas.pocze+renesas@ideasonboard.com>


>   
>   		reg = ISPCORE_DMA_IMAGE_FRAME_BASE_ADDRESS_COMP1(0, frame);
>