From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3BA23ACEE0 for ; Tue, 20 Jan 2026 07:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768895131; cv=none; b=Blev241Zzg1Ntdeys+Qcr9gyRohC3xuf0JUo2rAP57ZP+nXXkjJ6q/iukO/e4s7HL66RQec4bJYg2gq+7inHo8HoGWUh+LTLpl614jmwa4QXRukXWXFj4Y4vKUjbNtEaIJpiaMTUNu/ued7q/wVplFI5l/SBSeSNVu6psHKg3CI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768895131; c=relaxed/simple; bh=A7WdKEUEVYfv9u/e3wJ6l1j/cN1T/RbeqRHBVjqH3m0=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Napn0k2S3QEfl7Ww96H+aohmGnwUqtb/07KVgjkKCNIciMIKInc3ytBuPbZFCb+ikVNoJ9vEcL21iq5Z7TdnQ3T5oH2zZpjI8RpyEHwz8AEe7JZF0RmB/jFkl7JBlq92KMU586McbBDUASzOurE/Gs1aBNYlc2vBmsoLSR2Xpmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Nzaojw8Y; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=QqUAAZXl; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Nzaojw8Y"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="QqUAAZXl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768895129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=A7WdKEUEVYfv9u/e3wJ6l1j/cN1T/RbeqRHBVjqH3m0=; b=Nzaojw8YWPlmkX6k3KQM+bkPNJXovbJ40ZwXZxJHOT4WERfcse+A5+ndvGI6PUUKDPo/Eh hLngvLf+EI5MbbComqQEQV/JuZ7qTBbNlBQTI2cuvnMk35do9+gt+vtrnc0K8QzVusPAKv nkJQHj9ddvR1YsA2QFviw9iqOpfoddk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-0TcJ3ZJCOxmjIeL-vGVG3w-1; Tue, 20 Jan 2026 02:45:27 -0500 X-MC-Unique: 0TcJ3ZJCOxmjIeL-vGVG3w-1 X-Mimecast-MFC-AGG-ID: 0TcJ3ZJCOxmjIeL-vGVG3w_1768895126 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4779d8fd4ecso25212935e9.1 for ; Mon, 19 Jan 2026 23:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768895126; x=1769499926; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id:from:to:cc :subject:date:message-id:reply-to; bh=A7WdKEUEVYfv9u/e3wJ6l1j/cN1T/RbeqRHBVjqH3m0=; b=QqUAAZXl1ruj5pTJb/Grfolc47xN+zpKq+V5SXWH/TYRa/eqbbeVFpb4gU552YGdgT sLh1rdFfTVePM17j3qE5SPXNEuV8D3BcXeWqoYDzDrNDkYHtGSm4Tw3HmvLp9Ix5/GHV hZHC3TjA+5ZaAnnLSF3gr3QbNQ38LYS41ShLCTZU3G6LAQ+RsF2OAlG0TA+EerVBQSyG BdsuJXDb6QjK96sal8jwFuT9HsE+vOxvP2p8nE7/PofRVJI8Zfw9XiS0WSkujk7FnrDM fnVUV8qZHW0iY6JUbsjihlJgk58hKdDZyjhz8chtaCZB6hqXXR3i6XCUTwxHpSHoJEYS XpLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768895126; x=1769499926; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A7WdKEUEVYfv9u/e3wJ6l1j/cN1T/RbeqRHBVjqH3m0=; b=LxYW5RVCkK7+b8rd++YslPAFOR1ja/sJfp2iPWsDrGyIFh9yTRfqorS6+uqqUyCTY4 d8ptRndFxhU6GX0gx5+CtYx+HIh3HM/T1tbSfTb7TMb1W9Jvv+WXThzv+y1CxoCEkSRZ QFGz2dhkj3aKBjgLSjlotmI2Yhoi+Jf03BKDwpcoHAeZ9ZMMa7hPnXH2rvc6QPtx1pfX SbgE3cNC6cwYO6Wdy2cq8+sZn6/5qiIJS8PDaiMuSMiYYT2YokaJTfVXUaNQxwmJid2b jFOw5YGazUEu0Yl7zIf7lDIafEsYbv2kW68MFCiBdntrmsCbMESTzqpfF4TC3DOX34gN 3jMQ== X-Forwarded-Encrypted: i=1; AJvYcCW7rWjcS2cNAfICgfGBJECMsgMwCQq8L1Cawo3rTRzVli9BwmXKSjjYVrd1s2nHCet3Y1aOwbpa4WpZCHI=@vger.kernel.org X-Gm-Message-State: AOJu0YyY2uXzJaUVmVGAaE/XJ6dNvZuJ2c1SULdynHfzhpquuRVx7GNh wIqgba55feRFZuRjDKAJDj/cobaT+n3gp0Mo5c1Jr2uLiarse1nK+A0Vrh1I2jzqBYwTx/pGcTz WbzsjBut3QV+CgQgorbP8WBSPR8CYJpB6FOVmUpI+/HcS8YaV2sd4TTZrLDbxvHDO2Q== X-Gm-Gg: AY/fxX6YcC1VmId5p0RV18t2FmhZJP/5bB885lLhqi4OG/3P1PMGb+eeLHL60zZgHfT ZoOTgGoplLmskV7YgwTmkNWh84Qai/Txz0XEPXTGt5ZITT4TGpcx9gO+tau8Ex1Mj/lD7mUWvy5 C1EpcPO/ydtCB8E7Zddr6Vm200FxsnRKK6YRdFNEGElYupF+f0sdzXyAA6bxR8LiRAh8AYj3+B2 320SzQM/tPSZanYeSyZZp1N5LJBfv6T5JKfc+mW8ylscMBN2OmreTaayoQawt7SgOAm5/1NyBvI 5ZVL0yG/WTUFMebl3Ux+y4nfOCmdWKQ3l9qTgGkwZwiu69z3SHizRNyQ5/WMSOBN1+xTOYZiFWK fHMfqLH4+CAA4QUJh8zbSTNk1WCe/aSu/M+s8kFLwfo5CRQNEyYrApUWLjrEF0S9rSGcEFGKw+6 C9DC7AL2as X-Received: by 2002:a05:600d:2388:b0:47e:e7de:7c41 with SMTP id 5b1f17b1804b1-47f44d4ca19mr130183505e9.16.1768895126163; Mon, 19 Jan 2026 23:45:26 -0800 (PST) X-Received: by 2002:a05:600d:2388:b0:47e:e7de:7c41 with SMTP id 5b1f17b1804b1-47f44d4ca19mr130183295e9.16.1768895125704; Mon, 19 Jan 2026 23:45:25 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f428acae8sm289964525e9.4.2026.01.19.23.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jan 2026 23:45:25 -0800 (PST) Message-ID: Subject: Re: [PATCH 07/26] rv/rvgen: replace __contains__() with in operator From: Gabriele Monaco To: Wander Lairson Costa , Steven Rostedt , Nam Cao , open list , "open list:RUNTIME VERIFICATION (RV)" Date: Tue, 20 Jan 2026 08:45:24 +0100 In-Reply-To: <20260119205601.105821-8-wander@redhat.com> References: <20260119205601.105821-1-wander@redhat.com> <20260119205601.105821-8-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote: > Replace the direct call to the __contains__() dunder method with the > idiomatic in operator in the dot2c module. The previous implementation > explicitly called the __contains__() method to check for membership in > the final_states collection, which is not the recommended Python > style. >=20 > Python provides the in operator as the proper way to test membership, > which internally calls the __contains__() method. Directly calling > dunder methods bypasses Python's abstraction layer and reduces code > readability. Using the in operator makes the code more natural and > familiar to Python developers while maintaining identical functionality. >=20 > Signed-off-by: Wander Lairson Costa Neat, thanks! Reviewed-by: Gabriele Monaco > --- > =C2=A0tools/verification/rvgen/rvgen/dot2c.py | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/verification/rvgen/rvgen/dot2c.py > b/tools/verification/rvgen/rvgen/dot2c.py > index b9a2c009a9246..c97bb9466af6d 100644 > --- a/tools/verification/rvgen/rvgen/dot2c.py > +++ b/tools/verification/rvgen/rvgen/dot2c.py > @@ -207,7 +207,7 @@ class Dot2c(Automata): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = else: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 first =3D False > =C2=A0 > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if se= lf.final_states.__contains__(state): > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if st= ate in self.final_states: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 line =3D line + '1' > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = else: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 line =3D line + '0'