From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2365AC4360F for ; Thu, 4 Apr 2019 18:55:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8DE02171F for ; Thu, 4 Apr 2019 18:55:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729908AbfDDSzZ (ORCPT ); Thu, 4 Apr 2019 14:55:25 -0400 Received: from smtprelay0163.hostedemail.com ([216.40.44.163]:34529 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727398AbfDDSzZ (ORCPT ); Thu, 4 Apr 2019 14:55:25 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id E60031802EFE0; Thu, 4 Apr 2019 18:55:22 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: hope54_11554c3f8d22c X-Filterd-Recvd-Size: 3107 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Thu, 4 Apr 2019 18:55:18 +0000 (UTC) Message-ID: Subject: Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging From: Joe Perches To: Sam Ravnborg Cc: Guido =?ISO-8859-1?Q?G=FCnther?= , Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Kevin Hilman , Manivannan Sadhasivam , Shawn Guo , Jagan Teki , Martin Blumenstingl , Johan Hovold , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Nicolas Ferre , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 04 Apr 2019 11:55:17 -0700 In-Reply-To: <20190404170040.GA23897@ravnborg.org> References: <20190403161735.GN5238@ulmo> <1ed5eb3af4df6b2dd1544c7b696e034ed5c94f06.camel@perches.com> <20190404105359.GA8255@bogon.m.sigxcpu.org> <20190404170040.GA23897@ravnborg.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-04-04 at 19:00 +0200, Sam Ravnborg wrote: > Hi Joe. > > On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote: > > These were missing '\n' terminations, add them. > > > > Signed-off-by: Joe Perches > > --- > > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++++++++++--------- > > 1 file changed, 10 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > > index 158a6d548068..d88ea8da2ec2 100644 > > --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > > +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c > > @@ -123,7 +123,7 @@ static int jh057n_init_sequence(struct jh057n *ctx) > > > > ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > > if (ret < 0) { > > - DRM_DEV_ERROR(dev, "Failed to exit sleep mode"); > > + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n"); > > I was under the impression that newlines was optional these days. > Should we always use them with logging? Yes. The general problem is KERN_CONT/pr_cont uses where interleaving is still possible from multiple threads. > I did not find any obvious clues in linux/printk.h I'll see about adding something one day to the Documentation. Likely in coding-style.rst.