From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A841B2550AF for ; Sat, 21 Mar 2026 09:11:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774084291; cv=none; b=nt8i3ae9CjoCIaFEfUOOz2xnSOGddZqOdMD8z1mLv1UEG2nhqyQ42wNlQjowPl661xvIllSU9vwOysnV52h2W8hDNIOjdGc+HIP41DH5SHze0AdMnpFxIwk5d8/aEPc+S6n9yZf2CY5yg9EtEiettpAUk9A3FaZMQenIySrDtbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774084291; c=relaxed/simple; bh=g88TsmGvhPf/0xyn5Z4d4bZ5OWZNV190OqTroMj8OhQ=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RHxsb1irCc8GZU//lEuZKqFFFvmZDccmw2Nt18a5PdPbhJ5QYBmgWUz4/Xkq2gfElTiVE0JVsqxftavG7LPOZcXy3IdB1SXLEHteX++Zwv4dP8EVNa5ab85f9Cyth8tiN7YgiWsxsqL/dEm3oiJhpWGfCA5YMjECbjjK9gKWcSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Eh8MGTqm; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Eh8MGTqm" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-486fd3a577eso10766435e9.1 for ; Sat, 21 Mar 2026 02:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774084289; x=1774689089; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=8IedKiARDXE8lCU5jVbRUokeFlyWix2GoFLTc0oC95Q=; b=Eh8MGTqmyXbp6ou5WDL26ffruGvqiLWcEoZK10zIBFFdWPynNUPH65o5ReLWILqBou +qH7+5RoiuoPu3hMfiGCmaBMjl/68hvDxXqabfpv1bSDeI33aUtjgDMPcc7DHeBedKve tQtQg7+JeuLGIpGFXUUp173PcJsYC/zzjgj9hgDNrnfbCvvXuBAYd4Zwdf8SHH/vBmsj Qsxm5/X9GTFyAC90+MHjvk5hqCe4BPYR+xmwkhOvEoxlls2cU0IPvxZL3FDxpC3KSIVC ISRpWilhm0EsLg9On3AJ8e6LMMe0m05qMwwgytFJGc16uY1TVQ2+5jk5GU+p+PDWBJSg FDkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774084289; x=1774689089; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8IedKiARDXE8lCU5jVbRUokeFlyWix2GoFLTc0oC95Q=; b=O/yeJyVMSQt7epyDO9OE58wc9ozbWNkljPplqEdbHbgFzaopR2J0V+EfBuz0q10Eqw hp+KCR/7Fs3q2h2xAumJvhPZ4wdA2WuGeCEnNsVFezpw5E33VQMEEHSVDr9bo1YN9TKY sTzoL1YrIA0rgiJCaCnHWL5fHCQrb+odIb1yILIinYESmVxw2RkSz9J45t9RXt0qjb6P maT2HsTdjSotMsmwo20QMLnN3gGesvYQnKW5nfrBJ3dWlzvi/Y+U8wyCgZDSL3/Jq0f6 93+KU8qbtBFHvgKhTjN6WogNB+NgVZYGm7KCpx262gTJjNOzuKzBKpOnOFur51NBSB3n zJIA== X-Forwarded-Encrypted: i=1; AJvYcCXfatoK5WgEGFw3nhk5BZfdVeeOWK3RBsNvenupdN5e356yTA+5l5JApfSL7A5ShjnQ2Oobg2rXHwXV8aI=@vger.kernel.org X-Gm-Message-State: AOJu0YwXijTRTXuxwn+EGu4Y1e0pMGKIiVv8huEFfQ+kJEQVl6lnQBqh QacnF7ypMUjve9qUBZEhetOtPYXapb7BfsDsKM/zDfPXx3Ilw+krdRxP X-Gm-Gg: ATEYQzw9s/0aapE9CRpR0V7/vuOIyC47WiSITUA8Gnh5Ml08Wo1En4pK4nnegBXlL84 1uv9jowLO0vBM9NCTDblcz7uT1nI0yInwQt9SosjEjynpC52rSNPVZXlQ3UgFdQD/mOzeT4hHVS AYBHEE2JzuwojWHiGqBgpon8ylQwjRI3Mo0ceMf/KByc2bLCs+25Cj9UwsZGnS0GQ6eRvel9TM0 nMn8GwmxcwHW5O8jLfcCvP1E3DCy7Ub/xjfVSx7+jmh8pLEJY6Sf8oTh/ni+0ytIBhLu306Wvre v5HMmEpHe6pyKrzZ8v77BVGKlIZw5hwmLub/d38F/PVqj5Lh2pzz2YOn3REwLxqLcMdSOOSnvIA RdONC+EZavSBQ5Eudd1MNneKvHx8H2ucQvzJXyRe2aCdRY2T8UU4zP2OcULiZU9LyB6/zuVoT X-Received: by 2002:a05:600c:4705:b0:485:3a86:6392 with SMTP id 5b1f17b1804b1-486fee0d816mr81541115e9.20.1774084288761; Sat, 21 Mar 2026 02:11:28 -0700 (PDT) Received: from krava ([2a02:8308:a00c:e200::d99c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe7d6c54sm291474725e9.4.2026.03.21.02.11.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 02:11:28 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Sat, 21 Mar 2026 10:11:26 +0100 To: Weixie Cui <523516579@qq.com> Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Weixie Cui Subject: Re: [PATCH bpf] bpf: propagate kvmemdup_bpfptr errors from bpf_prog_verify_signature Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Mar 21, 2026 at 02:08:00PM +0800, Weixie Cui wrote: > From: Weixie Cui > > kvmemdup_bpfptr() returns -EFAULT when the user pointer cannot be > copied, and -ENOMEM on allocation failure. The error path always > returned -ENOMEM, misreporting bad addresses as out-of-memory. > > Return PTR_ERR(sig) so user space gets the correct errno. > > Signed-off-by: Weixie Cui Acked-by: Jiri Olsa jirka > --- > kernel/bpf/syscall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c > index 274039e36465..51ade3cde8bb 100644 > --- a/kernel/bpf/syscall.c > +++ b/kernel/bpf/syscall.c > @@ -2832,7 +2832,7 @@ static int bpf_prog_verify_signature(struct bpf_prog *prog, union bpf_attr *attr > sig = kvmemdup_bpfptr(usig, attr->signature_size); > if (IS_ERR(sig)) { > bpf_key_put(key); > - return -ENOMEM; > + return PTR_ERR(sig); > } > > bpf_dynptr_init(&sig_ptr, sig, BPF_DYNPTR_TYPE_LOCAL, 0, > -- > 2.39.5 (Apple Git-154) > >