From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F942284881 for ; Sat, 21 Mar 2026 10:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774088564; cv=none; b=bXZdVjg46RcZbsfRbJ96GbM5I2JA0YOYOA4/4fkzrjZvDH0lH8kPNIw7uSJxNoNeYzwLmQhXE35kpEurXcn5dc1NTSosjB1OEhraCVZmB7TRruWmBz++mw3UE/inGt3qOfM2b3/IRv0oTESZP5FzoIbAhVZPc+wjTmNm+IZrSg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774088564; c=relaxed/simple; bh=LQ0bxs+3d9n403nrVVBCtUaJTlLutOkC1jRK9LEEa6A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nPoV8TVhnEI6SjiK6abHMf2YQEnxPzpCa1ub5DJ8f+5+6opJTjj4P+bIXayLHN6pA0lLeIS/s1zN+UIGcFNRTqx1CGsz3XMP6JeYVfdmww9MP615jKN7OKLfWBGJSzz8sLfgP5BF9VpF+I3M1IqEfBYrwQ9LU4m12DEO0D/owpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EjjL92Wi; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EjjL92Wi" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-486507134e4so32539925e9.0 for ; Sat, 21 Mar 2026 03:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774088561; x=1774693361; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ncZ3YNhaTYxF3dz2fmkAFzB2GbjnNzz5sDTtsch5DyI=; b=EjjL92WiyK/UYxgIX3/pou5W5tCV6Eb45NkRc0De8oGtikNu7nmyHd6pVMlOR9NChe SH3u8JpyAMDg2ixu75HYCqmNJR3KFdADJJGRoBZaSnlXgHFaXmWaZQurxmGBHQjE3pZS 8iGLXa/mj6V+lEx+8LuSIddmteM3g1m1fwBDoA4gUR5UgH3FmSAlQ3M9lLF6cF6zHByY pMMjlWgJ1GZviJCkDYB/NL0L3ku5eIDxGZVaSMC0rMX9mawCR2RUh5hshq0pOf0AjE2G /WdhuP19RORIXE72BzKilMx+Bsx/uQloimYSVtiiu52wnnH/bG6TmI0bSImFDrHCWTEY p3qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774088561; x=1774693361; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ncZ3YNhaTYxF3dz2fmkAFzB2GbjnNzz5sDTtsch5DyI=; b=X5gWacuuDfL82QSmBu14S2BM62RgIekZg1bu3xi7EqxHZHylGCFruN7CNKr4DxmvWJ N4/unyOTCHsu3ZqQkv0e8RvB+C6g5/q+mjoiGs+LHBMh3EJ906U+j9qKtF3qY4aB3jLX o6CHO/dzLEyE1xsN/BGy7LH8YJAAfOy6lw7uYfbTzpurPNOXXOXZbnqVoEsfX6/3aTyK eeYjLun23DSJloi9Mfbma7T5kuKNvoUjvjurIUrXeY9MlVbhVE1qdp0W34wCiSRxwU0F oYEyw5X+EhsYQCUnLpOEiV2JgfRGoyfHcBNV9K8kuI4YwERCGz1dZF+VWQDnzOANiVmT EDyQ== X-Forwarded-Encrypted: i=1; AJvYcCWeoyGClXXsx8R3Jvd6yzVm5W/BXHcOvUxHpdWF/Dc9Ah9ObBxsw7VBqydibxKooZR5KxOvCoer5+hsHM8=@vger.kernel.org X-Gm-Message-State: AOJu0YySpkL0mx6l0mkG/LwLoeYHjqMRQ+XS6Eb5HvxyHUdx8GZ+LwPU FS6OIhs2KXNUJo+m4N7NPDkuYUx22VsQRacB3QOe/8iftkLISroEmeqjTfqyg3DdzjE= X-Gm-Gg: ATEYQzxxRUSUjp0N/Qaj2HgJHHPSbuzOSes59We74CUxR5y3u0OXCtYchew62j8VfxH gzeNhyeD+6+m/fINvOalcMgzeg+dyKDg/PutS/PtCeM7s3+orCXLp8dAietG+Wy258h9sLSGA6l xbBilncn/Ln/Xk6jjpmrif2fsfTlh5iX+09jQQ9wxgM8NDL/DSs6EmwDVsI3ZnWpA1GBZXDflID LgtUWNOYaIj3Ois/2SSc/GiQmiwHkmktV3Dd/cYH8f7ENTqPO+HFUvV9MbUe2g5DSBnq1sKqag8 slca6sqKIuSnMlvoCUNYQ7//HcZb5LRTvqqdsna6ka1xTVWnfdMFXk9PHCgU5hHSwtKoh5IWgP8 qo31Ig9qItdwIWiPFItLIAwGI5phjike8XnK98jFnA20j5Wy/Hsels9GG0y5ju10OL78pcCR4t9 vTcbnGIRus/IxUhBZ8Xbrb1grTvMEeQeGvY6ZjmoQ= X-Received: by 2002:a05:600c:c167:b0:486:fab9:a578 with SMTP id 5b1f17b1804b1-486fedc3843mr85510505e9.11.1774088561508; Sat, 21 Mar 2026 03:22:41 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe032a55sm238485695e9.7.2026.03.21.03.22.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 03:22:41 -0700 (PDT) Date: Sat, 21 Mar 2026 13:22:38 +0300 From: Dan Carpenter To: yaxing guo Cc: oe-kbuild@lists.linux.dev, lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: drivers/uio/uio_pci_generic_sva.c:140 probe() warn: passing devm_ allocated variable to kfree. 'udev' Message-ID: References: <202603210811.1eXTfndx-lkp@intel.com> <2da23703-7693-47f8-a561-743428b9bb22@bosc.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2da23703-7693-47f8-a561-743428b9bb22@bosc.ac.cn> On Sat, Mar 21, 2026 at 05:51:15PM +0800, yaxing guo wrote: > > 3397c3cd859a2c Yaxing Guo 2025-09-26 135 pci_set_drvdata(pdev, udev); > > 3397c3cd859a2c Yaxing Guo 2025-09-26 136 > > 3397c3cd859a2c Yaxing Guo 2025-09-26 137 return 0; > > 3397c3cd859a2c Yaxing Guo 2025-09-26 138 > > 3397c3cd859a2c Yaxing Guo 2025-09-26 139 out_free: > > 3397c3cd859a2c Yaxing Guo 2025-09-26 @140 kfree(udev); > > > > So this is a double free. > > > > 3397c3cd859a2c Yaxing Guo 2025-09-26 141 out_disable: > > 3397c3cd859a2c Yaxing Guo 2025-09-26 142 pci_disable_device(pdev); > > 3397c3cd859a2c Yaxing Guo 2025-09-26 143 > > 3397c3cd859a2c Yaxing Guo 2025-09-26 144 return ret; > > 3397c3cd859a2c Yaxing Guo 2025-09-26 145 } > > > > Hi Dan, > The double-free issue has been addressed by Shuangshuo Li, who has already > submitted a fix patch: > > https://lore.kernel.org/lkml/20260226153250.18079-1-lgs201920130244@gmail.com/ > Okay. Good. I actually reported this bug to you last year in November. https://lore.kernel.org/all/202511280815.WV9iCJZb-lkp@intel.com/ regards, dan carpenter