mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Amna Waseem <Amna.Waseem@axis.com>,
	Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH v4 0/2] hwmon: (ina2xx):Add Suppor for passing alert polarity from device tree to driver
Date: Wed, 12 Jun 2024 07:18:06 -0700	[thread overview]
Message-ID: <ab648952-769a-42bf-b7bb-ee13b58f8794@roeck-us.net> (raw)
In-Reply-To: <2e0eeac2-891e-44c8-a1e1-36ec759d1b84@kernel.org>

On 6/11/24 23:44, Krzysztof Kozlowski wrote:
> On 12/06/2024 08:37, Amna Waseem wrote:
>> On 6/12/24 08:20, Krzysztof Kozlowski wrote:
>>> So you require someone to re-review?
>>
>> Yes that will be great if someone re-review.
> 
> You are joking, right? We have hundreds of other patches to take care of
> and you ignore review tag, so you get duplicated work from the same
> reviewer? That's huge waste of time and actually quite disrespectful to
> our time.
> 

I applied v3 of the devicetree patch (after comparing the two to make sure
there are no changes).

Amna, I would suggest to run checkpatch on your patches in the future
to find problems such as the following.

ERROR: trailing whitespace
#178: FILE: Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml:74:
+      the alert polarity to active-high. $

Thanks,
Guenter


      parent reply	other threads:[~2024-06-12 14:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  9:36 Amna Waseem
2024-06-11  9:36 ` [PATCH v4 1/2] dt-bindings: hwmon: ti,ina2xx: Add ti,alert-polarity-active-high property Amna Waseem
2024-06-11  9:36 ` [PATCH v4 2/2] hwmon: (ina2xx) Add device tree support to pass alert polarity Amna Waseem
2024-06-12 14:15   ` Guenter Roeck
2024-06-11 12:49 ` [PATCH v4 0/2] hwmon: (ina2xx):Add Suppor for passing alert polarity from device tree to driver Krzysztof Kozlowski
2024-06-12  6:18   ` Amna Waseem
2024-06-12  6:20     ` Krzysztof Kozlowski
2024-06-12  6:37       ` Amna Waseem
2024-06-12  6:44         ` Krzysztof Kozlowski
2024-06-12  6:50           ` Amna Waseem
2024-06-12 14:18           ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab648952-769a-42bf-b7bb-ee13b58f8794@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Amna.Waseem@axis.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=kernel@axis.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®