From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60140381AF for ; Wed, 3 Dec 2025 22:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764799784; cv=none; b=BvoIBfk+lcLN3VvZNq19SWJcQDzlZSRWeoCuXw7AvgJvqlfNXTOQzbHqAlV/c56Bi98CgxO6lkiwnYCLWNNNuCoTkYSid8o9oacoUIFjAYnUa8cU4e9vOY1aXqtVxE7H5PdnEFNtpx0ayt65t9XtzZ/8OuoqULbNvD7hI0OynAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764799784; c=relaxed/simple; bh=qplw2NsSDVoMG0RmGsxE0liWEOV24X9E6jdz5lTHSqs=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=H/nSYDLOqyuc12qFYgQBGQ10k0tTxhXMIUtxz/9wyxdC+zcHtjmkRpSSbEGgzOJtcMPZwSDMHJEYMMm7m0s9G4TvSVc0KJvIRa/WowkWUOBCVA4tzg2vnteTH607ghTh8HRR15sNz6g6StYRNGMrP0GIDcjRtbGKxNTJioiG7H0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hnSUynhi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hnSUynhi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FC6BC4CEF5; Wed, 3 Dec 2025 22:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764799783; bh=qplw2NsSDVoMG0RmGsxE0liWEOV24X9E6jdz5lTHSqs=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=hnSUynhiHzos6CFDDzU9qowPSxtRN4BNvQCLmdClkN111LnqBpQ8Ncx8GqhU64KaT 9ZPiP9/5YWT7e++u1Ombip0PtYIi/o/HbS7mEwroMYSzqDK1FrqL0ZcdxdSOXPqjkv 8RALgMOgTeJgdQCf2HhJwqfSxc9yfNzHSliaIklOe+OiqdjyjC5oxwsFWW4WDxOBaN U0zpAOiUKc659WwskAF9NOei1WmQLUcs+6epkKQIyjwCTLtXVr3PwodL+ORu9in/qN Qfuj7GhPR10jphED71eJtLlesfbPDl7W++yIshUE3MYE9218c4eehVEF03G2gCUE6U KtSRxI1wC2IWQ== Message-ID: Date: Wed, 3 Dec 2025 23:09:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 06/10] mm: debug_vm_pgtable: use pgtable_has_pmd_leaves() From: "David Hildenbrand (Red Hat)" To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com References: <237bcb7f3d832457322210cc7f8d1272c4ac88ef.1762464515.git.luizcap@redhat.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/17/25 18:40, David Hildenbrand (Red Hat) wrote: > On 06.11.25 22:28, Luiz Capitulino wrote: >> debug_vm_pgtable calls has_transparent_hugepage() in multiple places to >> check if PMD-sized pages are supported, use pgtable_has_pmd_leaves() > > Is that code even dealing with pages? Likely we really only want to > check whether PMD leaves are supported, independent of any pages. I recall that some arch protect certain pmd_* helpers under CONFIG_TRANSPARENT_HUGEPAGE. But it's certainly something to explore, to see if we can just get rid of that without causing compile-time or runtime issues. > >> instead. >> >> Signed-off-by: Luiz Capitulino >> --- >> mm/debug_vm_pgtable.c | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index 830107b6dd08..241b36c78ac9 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -170,7 +170,7 @@ static void __init pmd_basic_tests(struct pgtable_debug_args *args, int idx) >> unsigned long val = idx, *ptr = &val; >> pmd_t pmd; >> >> - if (!has_transparent_hugepage()) >> + if (!pgtable_has_pmd_leaves()) >> return; > > > All of these are currently protected by CONFIG_TRANSPARENT_HUGEPAGE, right? IIUC, yes. -- Cheers David