From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 668EA2820A9 for ; Sat, 21 Mar 2026 15:30:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774107060; cv=none; b=Oel8fsdm3dfBUMxGzEH7+oiAI9vpYQKW72tKU804Gdx+OlulOx2gQaNo4fjGTnzcHw/yiF8/tKHRnqkTl040iimnabdCCjRMuFKmMbZotOMKgi+aYxxntutrzR96hHBlevWUhWtMpGr7U2uT3pJrBHwiStkvina82P16RfIO63Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774107060; c=relaxed/simple; bh=B2nZGqB6E53i5cgbBKeNPO4PjE1DsTST7gLCyG5zE7U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NQJ2w2DCUqmDJdt3biP2QoujK4vpLQDyFqw8C7mEYTuQ6MQfsBiHcBYCDxGLqBFj0Z0UTcf+6UbupUa/KCBj/AEGKVxyfDdpTlruS1HeOA+y+RcTm81ylNYRYez8vcVItB+7N0I4VvWfueehh4ojyTHeu+7uWbNExxWv8CwZNrI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mNPY/bAp; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mNPY/bAp" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso13381405e9.3 for ; Sat, 21 Mar 2026 08:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774107058; x=1774711858; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3TwS9QYfhY3hdyHYGCfHBE6avYl+4A9FV1oW4FB2a2A=; b=mNPY/bApDXaY6KdoeiUtiA5EC32pVrvOgy+rXB2MSstt7gFYd8HutgE5Dt9AblYqUW +WfflJxOKfeC4nhnNbwRGaa0nQWRK1sqWlFxaF71KgvboxYejFCjvyJCJw0ei3h6U9Co Ug4m3nSHPfLP6YfK/j9fBGm7iyFkiYoZDRS9twmEuOW53R1r1ZvZym1NUF0n8RHsAZkl IGjY97mClbXnKPWsNCN4mjs4GhGjkYzglFBOqZy1HJ1MLlugbRxwoAIlgyefYUVg/giJ Hbr7HFLRep28ar5FMgYM9Dt9mPxf4aSVPgRGinFIJb+IeoxaBnQYdgpMrL0DjUNtV/Xf Au1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774107058; x=1774711858; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3TwS9QYfhY3hdyHYGCfHBE6avYl+4A9FV1oW4FB2a2A=; b=nNNyTmkGiXs2x1rfP4X+NOASBiOADqkRySDFKjQ+YrHjyh5nORQWUcXpRPucvAI7j8 mXiHeBoL38arVCZMaCQsHrxVJK+tXmbaTMxSDjZDr2STYiOqWFxxUhVO1+GqkNWudyCb /T5rjN+mE6HdCcuMCzL2Pcu7eTqAxgFKm4mzgEUa/G0+cfJRzASIFDRb2nACz0H+5EXe mj+dclJ4f8EU93O1PT8ha4P8EZTF3qTIu7Y3prh3SSplRHQX+RINJLqJ4COM6kThTrHu OMCN8fMmr+5/fHMrVKOQRDIyOfYHQiNyYNpNdPFBJmHU9XY4msApY7ik/edg9IsoCCrD SjEg== X-Forwarded-Encrypted: i=1; AJvYcCULG+wWyuRROL54wV+vYxI1O1wmM04EuTj8aluxs80wXW8zCGWrOG5EghwtS/Sj/903Nb2kubaJU+ng2B4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxq1vRzBzSgWrGA6/OmO2mrTVlRxdb2nvlBXGPRETdv7uEJPP8Q k22ZC8Hax64XpbFppoZrJu6sE2adY+iHT2EJCiRLu4QcxBijafPJ1QFPhgSNkyQ6zJo= X-Gm-Gg: ATEYQzzZ/Gz6O6MSTvfr6CVqmiQCsZzm4uANAjQ+yCjzk0IGxf8bX/gMZ+/9WEBIIgx IZp1ilqMuTog6E1rW+lUatEU98RtLIb88Gf/zjQ+vNhsnQmRC1BqnrlgWmNyGKkgu39TF8isiBF VRW+5Ljel1fO6ScIs5U2fLGCy0WLhSM3iOjSlAPFyXTv7v17ZyndGu9XBxsySuvnlcSN4in8QN2 v15Pyx9N+Ffgab/ofHcd/la53zH9cYpEpXl8LxvYrAPgNAfskZ0St1yVqo6Y1V3GUD9JOMUjjML DwFBp/5SXy7vZ7Id9AOm0Zo2m3es7nMg47Jf84Qxy07ERcoJl5+QgoZjAGtkbcxkeVJ05pP3Mw/ /uyK9+nfL11TWXTAH/cg1vlZaKP/4Wy9RLX736rpdzPchYMRjbng9U7qtMqeFmQkzrLzT7tfyZd XhcE4/GEUEiIQIQK+pvATgb1My2ndR X-Received: by 2002:a05:600c:8b46:b0:485:3baa:af14 with SMTP id 5b1f17b1804b1-486fee0fc11mr94402605e9.18.1774107057872; Sat, 21 Mar 2026 08:30:57 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-486fe85e4d3sm41338885e9.2.2026.03.21.08.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Mar 2026 08:30:57 -0700 (PDT) Date: Sat, 21 Mar 2026 18:30:54 +0300 From: Dan Carpenter To: Marcos Andrade Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: rtl8723bs: rename rt_channel_info members to snake_case Message-ID: References: <20260321151342.19864-1-marcosandrade95963@gmail.com> <20260321151342.19864-3-marcosandrade95963@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260321151342.19864-3-marcosandrade95963@gmail.com> On Sat, Mar 21, 2026 at 03:13:41PM +0000, Marcos Andrade wrote: > i++; > j++; > k++; > - } else if (chplan_sta[i].ChannelNum < chplan_ap.Channel[j]) { > - chplan_new[k].ChannelNum = chplan_sta[i].ChannelNum; > - chplan_new[k].ScanType = SCAN_PASSIVE; > + } else if (chplan_sta[i].channel_num < chplan_ap.Channel[j]) { > + chplan_new[k].channel_num = chplan_sta[i].scan_type; ^^^^^^^^^ You changed this from .channel_num to .scan_type... Please, be more careful. regards, dan carpenter > + chplan_new[k].scan_type = SCAN_PASSIVE; > i++; > k++; > - } else if (chplan_sta[i].ChannelNum > chplan_ap.Channel[j]) { > - chplan_new[k].ChannelNum = chplan_ap.Channel[j]; > - chplan_new[k].ScanType = SCAN_ACTIVE; > + } else if (chplan_sta[i].channel_num > chplan_ap.Channel[j]) { > + chplan_new[k].channel_num = chplan_ap.Channel[j]; > + chplan_new[k].scan_type = SCAN_ACTIVE; > j++; > k++; > }