From: Zenghui Yu <yuzenghui@huawei.com>
To: Raghavendra Rao Ananta <rananta@google.com>
Cc: Oliver Upton <oliver.upton@linux.dev>,
Marc Zyngier <maz@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Mark Brown <broonie@kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kvmarm@lists.linux.dev>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>
Subject: Re: [PATCH] arm64/sysreg: Correct the values for GICv4.1
Date: Sun, 21 Jul 2024 17:29:57 +0800 [thread overview]
Message-ID: <ab66968b-3d56-caec-cfe1-b509307caf94@huawei.com> (raw)
In-Reply-To: <20240718215532.616447-1-rananta@google.com>
On 2024/7/19 5:55, Raghavendra Rao Ananta wrote:
> Currently, sysreg has value as 0b0010 for the presence of GICv4.1 in
> ID_PFR1_EL1 and ID_AA64PFR0_EL1, instead of 0b0011 as per ARM ARM.
> Hence, correct them to reflect ARM ARM.
>
> Signed-off-by: Raghavendra Rao Ananta <rananta@google.com>
> ---
> arch/arm64/tools/sysreg | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
> index a4c1dd4741a47..7ceaa1e0b4bc2 100644
> --- a/arch/arm64/tools/sysreg
> +++ b/arch/arm64/tools/sysreg
> @@ -149,7 +149,7 @@ Res0 63:32
> UnsignedEnum 31:28 GIC
> 0b0000 NI
> 0b0001 GICv3
> - 0b0010 GICv4p1
> + 0b0011 GICv4p1
> EndEnum
> UnsignedEnum 27:24 Virt_frac
> 0b0000 NI
> @@ -903,7 +903,7 @@ EndEnum
> UnsignedEnum 27:24 GIC
> 0b0000 NI
> 0b0001 IMP
> - 0b0010 V4P1
> + 0b0011 V4P1
> EndEnum
> SignedEnum 23:20 AdvSIMD
> 0b0000 IMP
Fortunately there is no user for this bit inside kernel. We had checked
against the correct hard-coded value (0x3) in gic_cpuif_has_vsgi().
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
next prev parent reply other threads:[~2024-07-21 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 21:55 Raghavendra Rao Ananta
2024-07-19 7:55 ` Marc Zyngier
2024-07-22 8:00 ` Anshuman Khandual
2024-07-21 9:29 ` Zenghui Yu [this message]
2024-07-22 8:37 ` Anshuman Khandual
2024-07-22 8:39 ` Anshuman Khandual
2024-07-23 15:46 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab66968b-3d56-caec-cfe1-b509307caf94@huawei.com \
--to=yuzenghui@huawei.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=rananta@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®