From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010055.outbound.protection.outlook.com [52.101.193.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45A2235B62A for ; Thu, 2 Apr 2026 17:56:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.55 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775152581; cv=fail; b=MWZ7VgXK/pmkYD4PawXbtQbOj0NzlFf0qWGBAL5xL3jGLmy9B3mRCBA4Yvz11XmPgAqabf860B0j2TuR/16zt2TIuJD04/kRayjxtsyRl1oQImAHaXq/PnL/uABe7tMP0QFH7KlH2pwThzftYWKdF+Mc2Uz5cQD78Ix24O0/8o8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775152581; c=relaxed/simple; bh=CwZqW6WfH5vWBlYKirtWLyj5DqAJ2dxCGiFI+ZYHtVI=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=R5pChvxgTiBPZxYU4d4q04mMUMlHE6hn7fXs11RLltRnQna8iDa2T2AAnelFAThD9l5Yw0kO47vPKvnr9BpLPJAL8A3fr7fOrDQNd4mjQ6z5ueEWMcgUswsaccYECcb9+Pgsc6H5+5ywc5xNA7bIV85ev3l94w99dbKkkdzPvJ8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=bXHzDTKP; arc=fail smtp.client-ip=52.101.193.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="bXHzDTKP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IjukWQZt8Yz+wNus0aegpR5syrKgwdgHDVAJ2SQ1YgtFJWLbsNZsFCDgb6Ayt2SYrQzuvOyI0MBj3EiXvXGrOc+FqFFVpCosw3BSvTx5udVSbfpzZZp+8E7O5eMUqM3aCHbPw0l36U202ZKU+CI2o08VULI1qZzqVAVP5WuhCc7zuljljzNU7ylfbn88xOJcGIVvHPSdpTEaip1iz1hp55PGap5wbWxxshJ7quWaDpCSK/yzTv0vR/em1JpT/dQwpyXXu/6zEYeOvUtRlHqy2jupTKUgYkbblyAd5OJ8aswGuvP/USXTzD91PsCgSoY5Rwdu/FxcMPhKKZwC8ZAPRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aRDo2Q0jbOuMML+vMNBeqr5DgBoQ7TuayPnUSIgelOs=; b=EJdT2cZ8i4VC2mpQqvkwOfOeusMCqE+Mo2bdrc4Dc6tZXNfaz/w/ylUwpU5lRIdyRZBpZ5AqdORm2zvQ3SlQLujD8JydNAaLEZsWSAE1K3J5iEFVwjIMHjp6fy2pB8au26XPSYGGiQk1NyRzq1zwzaX9DF/QVHYLwzQhB2AGcQkVZLxR8ELBS26xSzZCfaW+GDJvjCf+9N+Ggp0jeGACW5GNFP63iE8AWMqOpTDSs70/NiB0aLbBsV9aP4UqAyO7YYy8j4F8RSLxHlD9pkCryg04CkQsUBQyAwhPouzfvb4bYTBfdADTt+A9yog5UbzyONcpAMCBeoJroUfYYEl0CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aRDo2Q0jbOuMML+vMNBeqr5DgBoQ7TuayPnUSIgelOs=; b=bXHzDTKPAgjIyv7rstpYfl1DwQAQRaUr/w9Eqpi7zLKye58UO3UwTAfnF1d8gaJuMyEXULDS2IlwKpiX9Ad6K6EuqjwGrERZcYHcYQ5mMBOT2tWoCwA6lb0GAVF97Dh3lZmL37mjvpr+wtKerUeDGOlFdXWm5F/fiMPp/s43FXw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SA0PR12MB4557.namprd12.prod.outlook.com (2603:10b6:806:9d::10) by PH8PR12MB6721.namprd12.prod.outlook.com (2603:10b6:510:1cc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.18; Thu, 2 Apr 2026 17:56:10 +0000 Received: from SA0PR12MB4557.namprd12.prod.outlook.com ([fe80::885a:79b3:8288:287]) by SA0PR12MB4557.namprd12.prod.outlook.com ([fe80::885a:79b3:8288:287%5]) with mapi id 15.20.9769.018; Thu, 2 Apr 2026 17:56:10 +0000 Message-ID: Date: Thu, 2 Apr 2026 12:56:08 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/5] pci_ids: Add Hygon Family 0x18 DF device IDs To: Lin Wang , yazen.ghannam@amd.com, Borislav Petkov Cc: tglx@kernel.org, mingo@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org References: <20260402111515.1155505-1-wanglin@open-hieco.net> <20260402111515.1155505-2-wanglin@open-hieco.net> Content-Language: en-US From: Mario Limonciello In-Reply-To: <20260402111515.1155505-2-wanglin@open-hieco.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM6PR08CA0042.namprd08.prod.outlook.com (2603:10b6:5:1e0::16) To SA0PR12MB4557.namprd12.prod.outlook.com (2603:10b6:806:9d::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA0PR12MB4557:EE_|PH8PR12MB6721:EE_ X-MS-Office365-Filtering-Correlation-Id: 6a00de27-7a20-433a-6087-08de90e11f8f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info: BrEdQaP6+rpwZtAGBjrhHqvDCyQOFJlFLyspSfFAyas5RN2+b6zMftb+aRWtuNizop8smfXffeB5B82W3VkE72PEtOSVjTOMqfGhYhTDmXVTjSC0c86fShBCOi3ITd2ltIrolMWRE6lWR0KpSqtppzr4tYK/NvEYlNLXXWDxR9bkOcs0tG/rfTJgDgfpKUgBkYGLsxaGH2wUbIs9KqXPc6co0JmQ0f/5sN8zmUGspa6MlBYPF7dldyfPwtKVpW+tZtGEjwZU5WUM5ANP2Sv2JGROtSWBcZ4yAoa3pZApA2z6VNnM44xwmo5//xTlqdhkyh0m1cZ3D1REy2ns6ccv9UbXDDDYAnWp5jgP2dWRRefLELdXrzNLWR5UoXPqmUsBhuVUATqDC7fYaCQozIoUCeO69RclmcXfVgDhM6Gdo23uAltR2rhY8c85CQOv9jlHNISMyXhs9JO17bZa4awocH5cJvn++XlXSh7NrxnKLCFwnHcFIal5Z8mntoMrMyaZtSXhFK+G/y+RlNq7W/HlrdovVRqo+/Z1JNyUR8dDGKF9dfImJrvvYKS8wwcP95eskS1tc/+aKWqE8z2aZkGyBJvgReDK9VC2UOTaQjWBRcb4nUyJziRGJ2MVou53r6T5vFWXx3Ig6jKOMFlxRZl+ywTwAufx3ZspXW9phuvvZWZpRicuaSXb+DsJkHrtUGpQjM4pMSoftGNw9gogSjFh6tcODbVWyxekQYhNsQlSCLw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR12MB4557.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T05PWERGZWRqODRZYjUwaVpDS0V5Rk8vVktnRStieG00U1JPN1VLalo1TG8x?= =?utf-8?B?N0JwSUFEc2VTV0ljRkdZa0hvMGFxTG85MU9zTGpTeGQxUTQxcnFML1hha0dz?= =?utf-8?B?NFZsZUIrOXRnY0VKczNsT1o5UVFrbURidkZXOVdvQ2NXUEhkNjVlZmFLaTRk?= =?utf-8?B?ejBkcW9hbFZDNE5HWXhoUmQrMDlaTld2MTBQTHdGRnZuU2JoZG5oc3BTZVh6?= =?utf-8?B?clZEVVpSd1hpWU44a3ZEWmo5em9tZHdHUXVHMEkwaEdXbUVaelNxVzJvSE1W?= =?utf-8?B?blBORE00c3NVU0hoRU53NkFBNHR3aGtRWHpYS3RNK05jL0ZYclNneEZiaTMz?= =?utf-8?B?QUZTZ21OZWhTaTRTdzM3M0VsU0wyejVmZUZwTVBNNkMxMlUyRDZSL212dTZw?= =?utf-8?B?eitwOGVkY09ZYWxPZVgvbW5IbnY4TW9HRWowSE5HZjlodjlXY1NqY1YzVUhM?= =?utf-8?B?RzRiMUp3VTJlSUFCdjVmVldPSWlZc3lGcTVmcTdLdXNRQVZ6OWNleE0vbGcy?= =?utf-8?B?bHN4UzVIMlB1NTRRczJ1bG9WM3BpTHV4THdpQ2l2cmxqM2FRZkZCcThzUDdD?= =?utf-8?B?RFFZRncvQWhpWTRyUlpuSmxNa3YxVnI1QWdPbkNLdVBOQkRSNTJiM1kvNEhY?= =?utf-8?B?d0pLRnFPbkczNmVSWnM4Sk1lTGU3dkRjVk44VDR4NGpGaHRrZlJ2aDVIQ1pv?= =?utf-8?B?RlBacm5OTnVpNk80UTJvYlJLYmp2ZnZzbnBoR2JJbTRGUEkwMDhXNmZwalRN?= =?utf-8?B?eGJzM0VibVpjdXh5YW9lSXIvcFZzT3lwdkRkNzVkMXZ6QktLNnVyZTQ3dG9J?= =?utf-8?B?QkllNXpiVEd3bjJsWVl6SEpkM0JkZFpxcGpjZWFtTE9SWWhGb2ZuOVZBSW5E?= =?utf-8?B?MXRTUERUSDI1TlNxWjVKQjNkWHVydDUydW1JVGk2aU9yS2xZT0g0UG5Td0xV?= =?utf-8?B?aEJFMlBwVCt4L0lsS2JNNG9lVTJJOWFPY0hSOXQ3U0J2VWxOZ1NXc2lYZ01o?= =?utf-8?B?eG85WnorN2JmNW9GZ3Z3c2hVSVBPSW5iWWFYRTEwN0FpZ1MxaXl2emxRS25X?= =?utf-8?B?aDlXZ0g4OXJrVzAzbnZtbFg1WkszMExvK1VNQWhXYURjMHlwY3MxRDZJTy9s?= =?utf-8?B?VWFKQ28yWTc3TkYrclJucko4RDVzVndWQ2VuRERkNVVKRHcrTi9CcVpPc214?= =?utf-8?B?YkpOTURFa1JvcnVjR001QVg1Z2l4UGljazA0cUVPYVpIZEl3M2UyUkRmbjVZ?= =?utf-8?B?a0JZWGlpM0ZXVktYdTY5cVNoOGJOWEVJU0NEUjBqNjJJdmxqUkczVkJPbitT?= =?utf-8?B?VW9NS3dUMFZJNVUrQmhjUTBTRk9GTGpJajdnS0c4TWVzeXVqY0ZNRnlaWnNr?= =?utf-8?B?ZjRFZXJSZGxOTDNZUG5IczROQVRVWTlCam5RS1p0aE1HUXZ3NDJsaHN1WUVr?= =?utf-8?B?ZE5rNUhTN2JTemk1L0Zyb0JJVWQ3WDlFU08rbHkzY2hKUklGYjVvdWpPODJ1?= =?utf-8?B?R2NlUGRBenJ0ZGQzenFKQndrRXJieWc0eGhENWxEcFhJUmhKaVJUWHhIN3J6?= =?utf-8?B?bjhrVDg4Y04wUXd5bmRvTHVBREZTT24wSTBwMm14WlNqRS96akFSVWtNNnZU?= =?utf-8?B?bTNWZ3VaTHpYNnh2dXRhcEFQNi9IYldRcHkyQVNPYmQwVDR2dzNaclNla1pl?= =?utf-8?B?QUlESUxGc05ncDdSM0RhWUpXcGpZcXd2Q3FHUXBJb2JlZnQ1YzY3Q3NYVTRp?= =?utf-8?B?d2R1L1pmWDJZMFZhcG9tbGJzSnFYYkNHYVl0L2dueGNmWW5yR0FIblk2NVEr?= =?utf-8?B?aHZCNFNpejBrL2Z2L0sydzRIeGR0REJpNkZSMklnM0ZsMnc1UENHdGM1eTEz?= =?utf-8?B?VjF0SFQ1bVJScCtSZWNRak1NK1N6VjYwTWRneDhXMnZxeHZlOHp5b1RnL3Ez?= =?utf-8?B?UUF6N0FqWEN6QWZEQUh4V0ROcjIvSUhlNWVXT1Y2cHF4WWlPTjVoQy9XMUZ3?= =?utf-8?B?cmlBN2RoMkxZVDVSNWx5N0Nqem9ncTRhOC9qQzNZRDlvLzZCZW5RMVB1b2o3?= =?utf-8?B?NXpOa1VjL0hsYkg4OFQ3TzJhZkExZUdSK09WZ0hNeXNCaFJFamIreW85Vm13?= =?utf-8?B?UWVNZUpKTm1IelVrYjFlbEdtZDdLVDA2WUlmQ2Zjc25lV0VrZGdNVUpkbkZz?= =?utf-8?B?d3BNS1hHOTAyZlpTZlc2K0lSRDZSSVVQYWZ4enEyK01LMFgxQVpsTHZzUnZ5?= =?utf-8?B?MEZCQjlpb1IyUEhvaUlicGNIcFR3Y3ZsVTRuejA1bkZZVWEycHNLemVFends?= =?utf-8?B?aGVGV1BjdDB2azRtYThTRFc3WS81VHRlSDBDd2tFUjBlM1c5WG1uQT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a00de27-7a20-433a-6087-08de90e11f8f X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4557.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2026 17:56:10.5898 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HicXuNpGY3l6EzRRqR19C/onEGLcrBemdPIbK9pr5DJ4I1lFxrnDVTrzkJUFqSJfKOwwXCq615iabjVqqyrXGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6721 On 4/2/26 6:15 AM, Lin Wang wrote: > [Some people who received this message don't often get email from wanglin@open-hieco.net. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > Add the PCI device IDs required to discover Hygon Family 0x18 Data Fabric > functions. > > Hygon systems expose DF-related PCI functions using PCI_VENDOR_ID_HYGON. > Some numeric device IDs are shared with AMD families but are qualified by > PCI_VENDOR_ID_HYGON when used on Hygon systems. I don't think this is a good idea to start precedent of using exact same define for Hygon and AMD because it might not always be true. Could we instead have something like #define PCI_DEVICE_ID_HYGON_17H_M30H_DF_F3 PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 And then anywhere you're using it like you describe (such as how I see in patch 3) then you can use PCI_DEVICE_ID_HYGON_17H_M30H_DF_F3 instead. > > Signed-off-by: Lin Wang > --- > include/linux/pci_ids.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 406abf629be2..0b51773412be 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -568,8 +568,10 @@ > #define PCI_DEVICE_ID_AMD_16H_M30H_NB_F3 0x1583 > #define PCI_DEVICE_ID_AMD_16H_M30H_NB_F4 0x1584 > #define PCI_DEVICE_ID_AMD_17H_DF_F3 0x1463 > +#define PCI_DEVICE_ID_AMD_17H_DF_F4 0x1464 > #define PCI_DEVICE_ID_AMD_17H_M10H_DF_F3 0x15eb > #define PCI_DEVICE_ID_AMD_17H_M30H_DF_F3 0x1493 > +#define PCI_DEVICE_ID_AMD_17H_M30H_DF_F4 0x1494 > #define PCI_DEVICE_ID_AMD_17H_M40H_DF_F3 0x13f3 > #define PCI_DEVICE_ID_AMD_17H_M60H_DF_F3 0x144b > #define PCI_DEVICE_ID_AMD_17H_M70H_DF_F3 0x1443 > @@ -2613,6 +2615,8 @@ > #define PCI_VENDOR_ID_ROCKCHIP 0x1d87 > > #define PCI_VENDOR_ID_HYGON 0x1d94 > +#define PCI_DEVICE_ID_HYGON_18H_M05H_DF_F3 0x14b3 > +#define PCI_DEVICE_ID_HYGON_18H_M10H_DF_F3 0x14d3 > > #define PCI_VENDOR_ID_META 0x1d9b > > -- > 2.43.0 >