From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <webgeek1234@gmail.com>
Cc: <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Val Packett <val@packett.cool>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Weidong Wang <wangweidong.a@awinic.com>
Subject: Re: [PATCH 5/6] ASoC: codecs: aw88166: remove async start
Date: Fri, 25 Sep 2026 16:35:32 +0200 [thread overview]
Message-ID: <ab6f28d6-4ce7-477d-80ce-ba076cc1b025@intel.com> (raw)
In-Reply-To: <20260925-aw88166-cleanup-v1-5-11f74cb5fe28@gmail.com>
On 9/25/2026 9:47 AM, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
>
> Codec drivers are not supposed to do anything like this. The result was
> that the first second or so of playback was essentially inaudible, and
> very short alert sounds could be missed entirely. Let's not do this.
Do anything like what?
Let's not do what?
With all due respect, the commit message found here is so vague I'm
surprised people even review this. Your change is not a one-liner
cleanup. I'd expect at least a short description provided, on what is
happening _currently_ and _why_ removal improves the functional
behaviour of the codec device.
Kind regards,
Czarek
next prev parent reply other threads:[~2026-09-25 14:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 7:47 [PATCH 0/6] ASoC: codecs: aw88166: fixes and cleanup Aaron Kling via B4 Relay
2026-09-25 7:47 ` [PATCH 1/6] ASoC: codecs: aw88166: support changing sample rate and bit width Aaron Kling via B4 Relay
2026-09-25 14:00 ` Mark Brown
2026-09-25 15:56 ` Aaron Kling
2026-09-25 7:47 ` [PATCH 2/6] ASoC: codecs: aw88166: add TDM support Aaron Kling via B4 Relay
2026-09-25 7:47 ` [PATCH 3/6] ASoC: codecs: aw88166: reduce log spam Aaron Kling via B4 Relay
2026-09-25 7:47 ` [PATCH 4/6] ASoC: codecs: aw88166: remove fade in/out on start/stop Aaron Kling via B4 Relay
2026-09-25 14:11 ` Mark Brown
2026-09-25 15:59 ` Aaron Kling
2026-09-25 16:27 ` Mark Brown
2026-09-25 7:47 ` [PATCH 5/6] ASoC: codecs: aw88166: remove async start Aaron Kling via B4 Relay
2026-09-25 14:12 ` Mark Brown
2026-09-25 15:44 ` Aaron Kling
2026-09-25 16:06 ` Mark Brown
2026-09-25 16:16 ` Aaron Kling
2026-09-25 16:27 ` Mark Brown
2026-09-25 14:35 ` Cezary Rojewski [this message]
2026-09-25 15:42 ` Aaron Kling
2026-09-25 7:47 ` [PATCH 6/6] ASoC: codecs: aw88166: make volume control usable Aaron Kling via B4 Relay
2026-09-25 14:18 ` Mark Brown
2026-09-25 16:05 ` Aaron Kling
2026-09-25 16:18 ` Mark Brown
2026-09-25 16:25 ` Aaron Kling
2026-09-25 16:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab6f28d6-4ce7-477d-80ce-ba076cc1b025@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=val@packett.cool \
--cc=wangweidong.a@awinic.com \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®