From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbcHQGFK (ORCPT ); Wed, 17 Aug 2016 02:05:10 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:64619 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbcHQGFI (ORCPT ); Wed, 17 Aug 2016 02:05:08 -0400 X-AuditID: cbfec7f5-f792a6d000001302-ba-57b3fe912ded Subject: Re: [PATCH v2] clk: max77686: Migrate to clk_hw based OF and registration APIs To: Stephen Boyd , Michael Turquette , Stephen Boyd References: <20160816223856.1282-1-stephen.boyd@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Javier Martinez Canillas , Laxman Dewangan From: Krzysztof Kozlowski Message-id: Date: Wed, 17 Aug 2016 08:05:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <20160816223856.1282-1-stephen.boyd@linaro.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t/xq7oT/20ON9j1hM3izds1TBavXxha LN23msXiY889VovLu+awWVw85Wrx40w3i8XcqweYHDg83t9oZfe43NfL5HHn2h42j97md2we W/rvsnv0bVnF6PF5k1wAexSXTUpqTmZZapG+XQJXxvmmq8wFL9kqbk79zdjAeI21i5GTQ0LA RGL2vKssELaYxIV769lAbCGBpYwSV74XdTFyAdnPGCU+HjjGCJIQFoiUaHs+jwUkISLQwCjx 5MghdogOa4m/W9cwgySYBWYxSvx43Qo2lk3AWGLz8iVgY3kF7CRePewCi7MIqEr8fd4E1iwq ECFxa9VHRogaQYkfk++B1XAK2Egc29gKVMMBNFRP4v5FLZAws4C8xOY1b5knMAItQuiYhVA1 C0nVAkbmVYyiqaXJBcVJ6blGesWJucWleel6yfm5mxgh4f91B+PSY1aHGAU4GJV4eBssNocL sSaWFVfmHmKU4GBWEuE1+gMU4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjtz1/sQIYH0xJLU7NTU gtQimCwTB6dUA2PJpXsrvj/23md3mLWNa/brtG8aMr4Tv5+tNavQ6a1OkkqK2OkSwnFhk8iM M7GhF/eJrDEJ3H1fVEK1xvby1WLXVRlFWf1iFukP50r1bNvZ++3piXll/DMOCmWuLYgXCZC4 f+9hlaChSkhwbYDzDbkvW/wuvK+oU2tIetkgtuXc1lWij2f3vFdiKc5INNRiLipOBACT7bCl ewIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2016 12:38 AM, Stephen Boyd wrote: > Now that we have clk_hw based provider APIs to register clks, we > can get rid of struct clk pointers while registering clks in > these drivers, allowing us to move closer to a clear split of > consumer and provider clk APIs. > > Cc: Javier Martinez Canillas > Cc: Laxman Dewangan > Cc: Krzysztof Kozlowski > Signed-off-by: Stephen Boyd > --- > drivers/clk/clk-max77686.c | 42 +++++++++++++++++++++--------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) Looks correct. The pr_err() could be replaced to dev_err() but first pointer to dev should be stored... so this may be fixed on different patch. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof