From: "lihuisong (C)" <lihuisong@huawei.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: <linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<zhanjie9@hisilicon.com>, <zhenglifeng1@huawei.com>,
<liuyonglong@huawei.com>, <jdelvare@suse.com>
Subject: Re: [RFC] hwmon: (acpi_power_meter) Replace hwmon_device_register
Date: Sun, 2 Mar 2025 15:43:32 +0800 [thread overview]
Message-ID: <ab93d716-f38c-8e34-cd41-0a35b7db4e43@huawei.com> (raw)
In-Reply-To: <ce3866a2-d264-4da9-9411-8427fc1c8f46@roeck-us.net>
在 2025/2/28 22:47, Guenter Roeck 写道:
> On 2/28/25 00:26, lihuisong (C) wrote:
> ...
>>>> BTW, I have another problem as commit log described:
>>>> -->
>>>> The path of these sysfs interfaces are modified accordingly if use
>>>> hwmon_device_register_with_info():
>>>> Old: all sysfs interfaces are under acpi device, namely, path is
>>>> "/sys/class/hwmon/hwmon1/device/" ('device' in the path is a soft
>>>> link of acpi device)
>>>> Now: all sysfs interfaces are under hwmon device, namely, path is
>>>> "/sys/class/hwmon/hwmon1/"
>>>> What do you think about this?
>>>>
>>>
>>> That is as intended. The ABI states that the attributes are under
>>> /sys/class/hwmon/hwmonX _or_ /sys/class/hwmon/hwmonX/device/.
>>> The ABI does not guarantee that the underlying path remains the same.
>> Yes
>>> libsensors handles this automatically, as should any userspace programs
>>> accessing the attributes directly.
>>>
>>>
>> So we don't need to care or handle this change of syfs path, right?
>>
>
> Correct. Each driver converted to the new API experiences the same
> change.
> If you insist keeping the path the same, you'll have to drop this effort
> and live with the deprecated message.
>
>
Ok, thanks for your advice and reply.
will send next version ASAP.
/Huisong
>
> .
prev parent reply other threads:[~2025-03-02 7:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 8:51 Huisong Li
2025-02-25 13:01 ` Guenter Roeck
2025-02-26 10:19 ` lihuisong (C)
2025-02-26 13:26 ` Guenter Roeck
2025-02-27 8:21 ` lihuisong (C)
2025-02-27 12:31 ` Guenter Roeck
2025-02-28 8:26 ` lihuisong (C)
2025-02-28 14:47 ` Guenter Roeck
2025-03-02 7:43 ` lihuisong (C) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab93d716-f38c-8e34-cd41-0a35b7db4e43@huawei.com \
--to=lihuisong@huawei.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=liuyonglong@huawei.com \
--cc=zhanjie9@hisilicon.com \
--cc=zhenglifeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®