From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4260C433B4 for ; Sun, 18 Apr 2021 10:44:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88CEB610CC for ; Sun, 18 Apr 2021 10:44:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbhDRKou (ORCPT ); Sun, 18 Apr 2021 06:44:50 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:53883 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbhDRKod (ORCPT ); Sun, 18 Apr 2021 06:44:33 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4FNRQ86t5cz9vBmS; Sun, 18 Apr 2021 12:44:00 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id d54YPj4tRfSP; Sun, 18 Apr 2021 12:44:00 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FNRQ85vyTz9vBmQ; Sun, 18 Apr 2021 12:44:00 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DB7918B79B; Sun, 18 Apr 2021 12:44:03 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id Dh9WCAivhXwx; Sun, 18 Apr 2021 12:44:03 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 7A5CC8B799; Sun, 18 Apr 2021 12:44:03 +0200 (CEST) Subject: Re: mmu.c:undefined reference to `patch__hash_page_A0' To: Randy Dunlap , kernel test robot Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Michael Ellerman , PowerPC References: <202102271820.WlZCxtzY-lkp@intel.com> <06227600-c5c5-3da7-a495-ae0b0849b62d@infradead.org> From: Christophe Leroy Message-ID: Date: Sun, 18 Apr 2021 12:43:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <06227600-c5c5-3da7-a495-ae0b0849b62d@infradead.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 18/04/2021 à 02:02, Randy Dunlap a écrit : > HI-- > > I no longer see this build error. Fixed by https://github.com/torvalds/linux/commit/acdad8fb4a1574323db88f98a38b630691574e16 > However: > > On 2/27/21 2:24 AM, kernel test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >> head: 3fb6d0e00efc958d01c2f109c8453033a2d96796 >> commit: 259149cf7c3c6195e6199e045ca988c31d081cab powerpc/32s: Only build hash code when CONFIG_PPC_BOOK3S_604 is selected >> date: 4 weeks ago >> config: powerpc64-randconfig-r013-20210227 (attached as .config) > > ktr/lkp, this is a PPC32 .config file that is attached, not PPC64. > > Also: > >> compiler: powerpc-linux-gcc (GCC) 9.3.0 ... > > I do see this build error: > > powerpc-linux-ld: arch/powerpc/boot/wrapper.a(decompress.o): in function `partial_decompress': > decompress.c:(.text+0x1f0): undefined reference to `__decompress' > > when either > CONFIG_KERNEL_LZO=y > or > CONFIG_KERNEL_LZMA=y > > but the build succeeds when either > CONFIG_KERNEL_GZIP=y > or > CONFIG_KERNEL_XZ=y > > I guess that is due to arch/powerpc/boot/decompress.c doing this: > > #ifdef CONFIG_KERNEL_GZIP > # include "decompress_inflate.c" > #endif > > #ifdef CONFIG_KERNEL_XZ > # include "xz_config.h" > # include "../../../lib/decompress_unxz.c" > #endif > > > It would be nice to require one of KERNEL_GZIP or KERNEL_XZ > to be set/enabled (maybe unless a uImage is being built?). Can you test by https://patchwork.ozlabs.org/project/linuxppc-dev/patch/a74fce4dfc9fa32da6ce3470bbedcecf795de1ec.1591189069.git.christophe.leroy@csgroup.eu/ ? Thanks Christophe