From: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>, jolsa@redhat.com
Cc: namhyung@kernel.org, irogers@google.com, songliubraving@fb.com,
yao.jin@linux.intel.com, linux-kernel@vger.kernel.org,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Subject: Re: [PATCH v2 1/6] perf annotate: Remove privsize from symbol__annotate() args
Date: Mon, 3 Feb 2020 10:24:29 +0530 [thread overview]
Message-ID: <ab9edd7d-04d1-f988-9f29-81d65a807250@linux.ibm.com> (raw)
In-Reply-To: <20200130111653.GE3841@kernel.org>
On 1/30/20 4:46 PM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 24, 2020 at 01:34:27PM +0530, Ravi Bangoria escreveu:
>> privsize is passed as 0 from all the symbol__annotate() callers.
>> Remove it from argument list.
>
> Right, trying to figure out when was it that this became unnecessary to
> see if this in fact is hiding some other problem...
>
> It all starts in the following change, re-reading those patches...
>
> - Arnaldo
>
Ok, I just had a quick look at:
https://lore.kernel.org/lkml/20171011194323.GI3503@kernel.org/
This change was for python annotation support which, I guess, Jiri didn't posted
the patches? Jiri, are you planning to post them?
-Ravi
next prev parent reply other threads:[~2020-02-03 4:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 8:04 [PATCH v2 0/6] perf annotate: Misc fixes / improvements Ravi Bangoria
2020-01-24 8:04 ` [PATCH v2 1/6] perf annotate: Remove privsize from symbol__annotate() args Ravi Bangoria
2020-01-30 11:16 ` Arnaldo Carvalho de Melo
2020-02-03 4:54 ` Ravi Bangoria [this message]
2020-02-03 13:30 ` Jiri Olsa
2020-02-04 2:37 ` Ravi Bangoria
2020-01-24 8:04 ` [PATCH v2 2/6] perf annotate: Simplify disasm_line allocation and freeing code Ravi Bangoria
2020-01-27 11:59 ` Jiri Olsa
2020-01-28 13:57 ` Ravi Bangoria
2020-01-24 8:04 ` [PATCH v2 3/6] perf annotate: Align struct annotate_args Ravi Bangoria
2020-01-24 8:04 ` [PATCH v2 4/6] perf annotate: Fix segfault with source toggle Ravi Bangoria
2020-01-24 8:04 ` [PATCH v2 5/6] perf annotate: Make few functions static Ravi Bangoria
2020-01-24 8:04 ` [PATCH v2 6/6] perf annotate: Get rid of annotation->nr_jumps Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab9edd7d-04d1-f988-9f29-81d65a807250@linux.ibm.com \
--to=ravi.bangoria@linux.ibm.com \
--cc=arnaldo.melo@gmail.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=songliubraving@fb.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®