mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Muhammad Shadab Khan <shadabtg4@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org, andy@kernel.org,
	gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: split long line in sh_css_sp.c
Date: Wed, 11 Mar 2026 11:41:37 +0200	[thread overview]
Message-ID: <abE40Qr5-S6E5c-0@kekkonen.localdomain> (raw)
In-Reply-To: <20260311084602.6088-1-shadabtg4@gmail.com>

Hi Huhammad,

On Wed, Mar 11, 2026 at 02:13:18PM +0530, Muhammad Shadab Khan wrote:
> Split a long line exceeding 100 characters to comply with
> Linux kernel coding style guidelines.
> 
> Signed-off-by: Muhammad Shadab Khan <shadabtg4@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/sh_css_sp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c
> index 6da151e7a873..c38a7c69728b 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_sp.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c
> @@ -983,7 +983,9 @@ sh_css_sp_init_stage(struct ia_css_binary *binary,
>  						    IA_CSS_BUFFER_TYPE_DIS_STATISTICS);
>  	}
>  	ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_METADATA, thread_id, &queue_id);
> -	sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id, mmgr_EXCEPTION, IA_CSS_BUFFER_TYPE_METADATA);
> +	sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id,

That limit is actually 80... so you could wrap at a different location.

Are there no other such cases in the driver?

> +					    mmgr_EXCEPTION,
> +					    IA_CSS_BUFFER_TYPE_METADATA);
>  	if (err)
>  		return err;
>  

-- 
Regards,

Sakari Ailus

      reply	other threads:[~2026-03-11  9:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  8:43 Muhammad Shadab Khan
2026-03-11  9:41 ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abE40Qr5-S6E5c-0@kekkonen.localdomain \
    --to=sakari.ailus@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=shadabtg4@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®