From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F096030648C for ; Wed, 11 Mar 2026 06:53:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773211994; cv=none; b=e9fnnLxXaHn6EYspbZYoq3Z93JqTu1hP0/XpUR49ho+4OJSYZWuFnOnYTD7lcn4TYlm8spYYyvgXhy9G5BTYgP5Bx9KY/8xiZ83pvQrPvuFqHGM3/PavBRY1XeIKj00uJgospFoVrI8TtqiZ2T4xBqxh5JrV+QbDfaMm3lQxFm8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773211994; c=relaxed/simple; bh=gLfrcn4GNXtzUHZ4mAGV9C/SkrxMY2hE3JC4Bc6Os5Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X3jD3SDIm9GovJiIfyzDlAnMmbgiQAikZilFCiSeLeK+r29SDg29lPTc7qpdSUQ6OY4Ld1vOMBhBhGgFmwHWSuPoDOVk2SU+pHKyLLe5MEe2N3v0acjzddf2epBu+u2ZmZlSMzKgUlmV1DnAGgDzHEQElKEql1+c6tJ8R+FyDEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H7iSPowC; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H7iSPowC" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-439f59dfda2so969568f8f.2 for ; Tue, 10 Mar 2026 23:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773211990; x=1773816790; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rfTOivZx0p7gzOazZRKQSvuxJsM85KQ4nZ/QkBNEE2E=; b=H7iSPowCaihQ/BeqvN8WvZzx/VwiKh9shDNd38JlfBo0LJXNzMXxoWcPH9WcIYj7+q 1lUyxU2LxJlIx/rlD4XHDEWlMttygEjoV0E2XzYXrf2n7ITCr5eHjKb0tcB5VP4MOO1c M4f85hNx79Z9mfvBhTsdNH62nbaJr65jKEIcGpah6vNkHmBTJI3RMMXoLPy3SMyd3PNr /F/MUcOh/tdO2glvTYCp5Mvxqwd1mbQ28YZRXWOepe07XmgebHV3H38av0mARJ/+PxO3 xrIRkvOEo0hqtTeeWpmOqLxFVoF63thl34ffP9W9MGfMeYaBsgfwO8k2rETMMCHkC0op 7jhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773211990; x=1773816790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rfTOivZx0p7gzOazZRKQSvuxJsM85KQ4nZ/QkBNEE2E=; b=sFuZXDDR1a+v6uH5/sv2hpMlufF+3xlAEvbaizT+HCwAON9yFFFgJjyog/Ctv7bxZd 0Ua1vSclhYjvOXszi0qBKR1LsXqim2sVSf1ZlDRBVDwG1dkzYNJUKthN7Q7Dm+3zB5IB 2q/9Gv3xVMPun8Wp0CqPqSm7UzeJQWxVI+obInKci8KvB/sGhZcO+VIsvE1OjAPFPAh9 mhDsbKqxSOmfUvrHxTuSke6uW4NvGxsanJuIs/i/zHf/j/SJ8s9KPUBy0rg0JjJes5Hw 6uXkMHf8DfGJ8+J5nGFgQAAckaHccs2Kt4G4DUrmojg5WyLNPc6GRTE8PT0sbVlrZb2n 9V/w== X-Forwarded-Encrypted: i=1; AJvYcCUCL8gv5s+Qx4/0RuC9Lv0B9SMFR719vRTEfohXAKlqHxL3i/HrGGzX2lclOAdFsEFUMyCPO7qaDSupH5c=@vger.kernel.org X-Gm-Message-State: AOJu0YzRFJhDANhByX+ifjTMnowj6ReuZuPmTnLvJ0TLqXd18pVurGoc tWOj8179ZIcrCpcwP8nELeQBJBtYzimtgsZM6E2q07Z/KUA3mJMAKKkuAExMVsY6JfQ= X-Gm-Gg: ATEYQzwS8pVOaGYfDwc92RkkpzQ3g2ya4C4UwWPKoXemcrqk3GlU5amv69GtpCzazjL +Tt7+8U+Iho7nNqgEpK0W/q20Y10NaSRL2904V9f5vT9ziPh104lTnn/YzKPiZJ58otdFaCyAgR a4+Ca+l2WqRCLIPW1iD9a52hbE/5a4Wo3sJPvuEd9PEzTKDQsP6icmNqhjFFgFfMUVjZIanb6FV RE1LYyfcPaV6CxNzmg4euOyEA8oYRfj2lbMpDEFlR0X7I8O7T+zAvoDAFerYm53HZ1v6sCx0CNI lf3LBkrdF4OPsvouBacKUAPHPWqyBliBsWYQL1fdvZEc8/mlinfPvsY15JzyyKK1wrubXhEQsGs IwyYINIBGlqJ2hf7PboUPFEw0AqwjlVNzBcEauMNXMPE5Q4LkCpCq7aUfrTHS2rI6y9Jfrq2XlR COvu3fQafpiH1UEX9wOeHIG7hllLdlevGjhcAZFpI= X-Received: by 2002:a05:6000:2884:b0:439:c628:2228 with SMTP id ffacd0b85a97d-439f843125amr2715649f8f.31.1773211990335; Tue, 10 Mar 2026 23:53:10 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439f818d209sm3857972f8f.5.2026.03.10.23.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2026 23:53:10 -0700 (PDT) Date: Wed, 11 Mar 2026 09:53:07 +0300 From: Dan Carpenter To: Tomasz Unger Cc: Andy Shevchenko , Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v3 04/28] media: staging: atomisp: Remove unnecessary return statement in ifmtr.c Message-ID: References: <20260310-atomisp-remove-void-return-v2b-v3-0-3fdddab41271@yahoo.pl> <20260310-atomisp-remove-void-return-v2b-v3-4-3fdddab41271@yahoo.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260310-atomisp-remove-void-return-v2b-v3-4-3fdddab41271@yahoo.pl> On Tue, Mar 10, 2026 at 10:39:15PM +0100, Tomasz Unger wrote: > Remove redundant 'return;' statement at the end of void function > ifmtr_set_if_blocking_mode(). Void functions do not need an explicit > return statement at the end. > > Found with checkpatch.pl --strict. > > Signed-off-by: Tomasz Unger > --- > drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c > index 50b0b31d734a..31dd3f99e28e 100644 > --- a/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c > +++ b/drivers/staging/media/atomisp/pci/runtime/ifmtr/src/ifmtr.c > @@ -472,7 +472,6 @@ static void ifmtr_set_if_blocking_mode( > } > } > > - return; Delete the blank line as well. regards, dan carpenter > } > > static int ifmtr_start_column( >