From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Linus Walleij <linusw@kernel.org>,
AKASHI Takahiro <akashi.tkhro@gmail.com>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
arm-scmi@vger.kernel.org
Subject: Re: [PATCH v3 1/7] pinctrl: introduce pinctrl_gpio_get_config()
Date: Wed, 11 Mar 2026 22:30:29 +0200 [thread overview]
Message-ID: <abHQ5Ry3ASErxKvO@ashevche-desk.local> (raw)
In-Reply-To: <350d922ad791ac72756caa91e1551e16d7f511eb.1773150895.git.dan.carpenter@linaro.org>
On Wed, Mar 11, 2026 at 10:38:07PM +0300, Dan Carpenter wrote:
> This is a counterpart of pinctrl_gpio_set_config(), which will be used
> to implement the ->get() interface in a GPIO driver for SCMI.
...
> +/**
> + * pinctrl_gpio_get_config() - Get the config for a given GPIO pin
> + * @gc: GPIO chip structure from the GPIO subsystem
> + * @offset: hardware offset of the GPIO relative to the controller
> + * @config: the configuration to query. On success it holds the result
kernel-doc is not happy: return section is missing.
Always run it with -Wall to see that.
> + */
...
I'm also wondering if this needs to be used in / already part of UP board pin
control and GPIO driver. There they used a proxy based on gpio-aggregator code.
With this it might be (I haven't checked at all) that the code can be simplified.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-11 20:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 19:37 [PATCH v3 0/7] gpio: introduce a gpio driver for SCMI Dan Carpenter
2026-03-11 19:38 ` [PATCH v3 1/7] pinctrl: introduce pinctrl_gpio_get_config() Dan Carpenter
2026-03-11 20:30 ` Andy Shevchenko [this message]
2026-03-11 21:47 ` Linus Walleij
2026-03-11 19:38 ` [PATCH v3 2/7] pinctrl: scmi: Add SCMI_PIN_INPUT_VALUE Dan Carpenter
2026-03-11 21:46 ` Linus Walleij
2026-03-12 15:27 ` Sudeep Holla
2026-03-11 19:38 ` [PATCH v3 3/7] pinctrl: Delete PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS support Dan Carpenter
2026-03-11 21:48 ` Linus Walleij
2026-03-11 19:38 ` [PATCH v3 4/7] pinctrl-scmi: ignore PIN_CONFIG_PERSIST_STATE Dan Carpenter
2026-03-11 21:49 ` Linus Walleij
2026-03-11 19:39 ` [PATCH v3 5/7] arm_scmi: pinctrl: allow PINCTRL_REQUEST to return EOPNOTSUPP Dan Carpenter
2026-03-11 21:50 ` Linus Walleij
2026-03-12 15:25 ` Sudeep Holla
2026-03-11 19:39 ` [PATCH v3 6/7] dt-bindings: gpio: Add bindings for pinctrl based generic gpio driver Dan Carpenter
2026-03-11 21:53 ` Linus Walleij
2026-03-14 0:12 ` Rob Herring
2026-03-11 19:39 ` [PATCH v3 7/7] gpio: add " Dan Carpenter
2026-03-11 20:34 ` Andy Shevchenko
2026-03-11 22:00 ` Linus Walleij
2026-03-12 10:41 ` Andy Shevchenko
2026-03-16 21:08 ` Linus Walleij
2026-03-11 21:55 ` Linus Walleij
2026-03-16 9:16 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abHQ5Ry3ASErxKvO@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=akashi.tkhro@gmail.com \
--cc=arm-scmi@vger.kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®