From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Rajveer Chaudhari <rajveer.chaudhari.linux@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, waqar.hameed@axis.com, linusw@kernel.org,
sakari.ailus@linux.intel.com, harshit.m.mogalapalli@oracle.com,
antoniu.miclaus@analog.com, andrew.ijano@gmail.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] iio: accel: bmc150: convert to guard(mutex)
Date: Thu, 12 Mar 2026 16:19:22 +0200 [thread overview]
Message-ID: <abLLap9bN3tTXfD6@ashevche-desk.local> (raw)
In-Reply-To: <20260312081942.23858-2-rajveer.chaudhari.linux@gmail.com>
On Thu, Mar 12, 2026 at 01:49:39PM +0530, Rajveer Chaudhari wrote:
> Replace manual mutex_lock/mutex_unlock pair with guard(mutex)
> in bmc150_accel_buffer_predisable() and
> bmc150_accel_buffer_postenable(). This ensures the mutex is
> released on all return paths and allows returning directly
> without a goto label.
> v2: Cleaned mutex_unlock and goto in
> bmc150_accel_buffer_postenable(),
> Dropped Header alignment change.
I don't understand why you can't do that as prerequisite. At some point we
probably go through them to fix, but since the new header is added, it makes
sense to put it to the proper order.
Same comment to other patches in the series.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-12 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 8:19 [PATCH v3 0/4] iio: accel: " Rajveer Chaudhari
2026-03-12 8:19 ` [PATCH v3 1/4] iio: accel: bmc150: " Rajveer Chaudhari
2026-03-12 14:19 ` Andy Shevchenko [this message]
2026-03-12 16:27 ` Rajveer Chaudhari
2026-03-12 16:47 ` Waqar Hameed
2026-03-12 17:31 ` Rajveer Chaudhari
2026-03-13 10:28 ` Waqar Hameed
2026-03-13 10:48 ` Rajveer Chaudhari
2026-03-13 8:56 ` Andy Shevchenko
2026-03-12 8:19 ` [PATCH v3 2/4] iio: accel: mma8452: " Rajveer Chaudhari
2026-03-12 8:19 ` [PATCH v3 3/4] iio: accel: mma9551: " Rajveer Chaudhari
2026-03-12 8:19 ` [PATCH v3 4/4] iio: accel: sca3000: " Rajveer Chaudhari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abLLap9bN3tTXfD6@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andrew.ijano@gmail.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=jic23@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rajveer.chaudhari.linux@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®