From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5EC816CD33 for ; Thu, 12 Mar 2026 14:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773325484; cv=none; b=bOJM86GxoyBGk6KiCB4lB+2NT7CdrsoILv51B5IcGNe8BoA1szZY6l2OqFa9m4rWUciyUGDyhwnisSotVEHUPVtwMK0Cu4kvoDkGnfoxFVPgGn758x/7XQYQDMiJ74rJv71QjsmKCl/4tUH7bI6JpALdC5eZsj0IL6iKBOc8Syw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773325484; c=relaxed/simple; bh=t172iUubs816NPU310xanePPUbfZ4bV/hhWzp0MCTTY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Hbh3lREzWZ2TBwZLyNgRtn8oi96sVeKYNHOxtvjYhQ1G2EmPSkOxqt6ZyueWQsdRky0CR3zyDdcl8dcw3grJu1lXumERPjR8/Beaf8zoQxvQU0JeIU7l7dY9IHs25XA6JojxhraQhhvVefs2FC1MZQvC+O6ougv6G1pL1eecegA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=aXhVzLlE; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aXhVzLlE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773325484; x=1804861484; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=t172iUubs816NPU310xanePPUbfZ4bV/hhWzp0MCTTY=; b=aXhVzLlEa5knN3DL5OxOp5eNYAOyVoGzJDJeqBZez0+uvFaSRJoFjTYm 69W2725xtedUMC2RqYqOoPjszMI+NAUkiV3SEsRpj5pGjZxLwKxyEVlD5 VtN/M0ODvd9iArhJxifKItMhSRMLOXccZHJdO2eIohq3KE/As7z6MyD7R qen2tFWIusIlqtLfbkCQAHPLwVuO26Yv2KJeLo8Hq21iffMc6vUzhdqzl vl8uqhkD+EXl/OWsdy3M6+KkGNYOLIYt1ISFuqdrSQYzXMxpd8gT99adK CMxpd7JfJcZteK5kZIIxfMSjBY678/AoDEjrwFp5aFPtho/kEk+gAwtcR w==; X-CSE-ConnectionGUID: LiVCKkM8QlSSFbfWVOydFg== X-CSE-MsgGUID: zPvgC6RGQEOsCKYVJP6KhA== X-IronPort-AV: E=McAfee;i="6800,10657,11727"; a="85120085" X-IronPort-AV: E=Sophos;i="6.23,116,1770624000"; d="scan'208";a="85120085" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2026 07:24:43 -0700 X-CSE-ConnectionGUID: TAkOn6KzS5GOizS+IPByOA== X-CSE-MsgGUID: FZ4vi3IISkuVtgG7mzitmA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,116,1770624000"; d="scan'208";a="220891635" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.112]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Mar 2026 07:24:41 -0700 Date: Thu, 12 Mar 2026 16:24:37 +0200 From: Andy Shevchenko To: Wang Jun <1742789905@qq.com> Cc: Andy Shevchenko , Andy Shevchenko , Geert Uytterhoeven , linux-kernel@vger.kernel.org, Andrew Morton , Randy Dunlap , gszhai@bjtu.edu.cn, 25125332@bjtu.edu.cn, 25125283@bjtu.edu.cn, 23120469@bjtu.edu.cn Subject: Re: [PATCH V2] auxdisplay: lcd2s: add error handling for i2c transfers Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Mar 12, 2026 at 09:25:02PM +0800, Wang Jun wrote: > The lcd2s_print() and lcd2s_gotoxy() functions currently ignore the > return value of lcd2s_i2c_master_send(), which can fail. This can lead > to silent data loss or incorrect cursor positioning. > > Add proper error checking: if the number of bytes sent does not match > the expected length, return -EIO; otherwise propagate any error code > from the I2C transfer. Why? Where is the changelog if it's a v2? -- With Best Regards, Andy Shevchenko