From: Frank Li <Frank.li@nxp.com>
To: Felix Gu <ustc.gu@gmail.com>
Cc: Samuel Kayode <samkay014@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Lee Jones <lee@kernel.org>,
imx@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: pf1550: Remove redundant regmap assignment
Date: Thu, 12 Mar 2026 11:46:15 -0400 [thread overview]
Message-ID: <abLfx7-KXTOPw7dQ@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20260312-1550-v1-1-5a84b886ccfe@gmail.com>
On Thu, Mar 12, 2026 at 10:30:31PM +0800, Felix Gu wrote:
> The config.regmap is already correctly initialized using dev_get_regmap()
> on the parent device. Remove the redundant second assignment that was
> overwriting it with pf1550->regmap.
>
> Fixes: 7320d41c29bb ("regulator: pf1550: Add support for regulator")
Nit: This is not bug fix and it is code cleanup. Needn't fixes tag here
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
> ---
> drivers/regulator/pf1550-regulator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/regulator/pf1550-regulator.c b/drivers/regulator/pf1550-regulator.c
> index 037b8ec94066..1d1726528460 100644
> --- a/drivers/regulator/pf1550-regulator.c
> +++ b/drivers/regulator/pf1550-regulator.c
> @@ -360,7 +360,6 @@ static int pf1550_regulator_probe(struct platform_device *pdev)
> "failed to get parent regmap\n");
>
> config.dev = pf1550->dev;
> - config.regmap = pf1550->regmap;
> info->dev = &pdev->dev;
> info->pf1550 = pf1550;
>
>
> ---
> base-commit: f90aadf1c67c8b4969d1e5e6d4fd7227adb6e4d7
> change-id: 20260312-1550-327017c6f56c
>
> Best regards,
> --
> Felix Gu <ustc.gu@gmail.com>
>
next prev parent reply other threads:[~2026-03-12 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 14:30 Felix Gu
2026-03-12 15:46 ` Frank Li [this message]
2026-03-12 17:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abLfx7-KXTOPw7dQ@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=broonie@kernel.org \
--cc=imx@lists.linux.dev \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=samkay014@gmail.com \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®