From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD180337BB0 for ; Fri, 13 Mar 2026 02:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773369828; cv=none; b=P6Lp48tfhiWmQ65FYeTtUD0yxF2R7apUKQX4Ppo5F7pv6j9ddFvw1gRoTztm0lNkQ2oTkBlzK8j8iliVniQAnDMWKAEiCRGbzaVGF4sNhLqFC3mXD/rela0qVL1Ptze+csRJQVbNjpDnlpM6wOHjzG+v7KQlAxLaF1EriltLFzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773369828; c=relaxed/simple; bh=BvmSqdKL2mgHyEPzAmRBGH1hY2ITeXqKZPua1k6rWgY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I0qszZAHiWTetUVetsLQPcS/+O8uLEopxTJ2tSZUv9m9xqcRcDCbKxgZvq6Jt2YMuJtRYYvdpgZy/iULYrpVw40Ds3eQrqMscWZlvqVBW0uttVq2mSbgSRY780sIgY4nS2X1LC+CwHlMVTFsADA7am0u2QDzAQbNYrfQYvMyl4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YcgO7Owd; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YcgO7Owd" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-506251815a3so14877241cf.0 for ; Thu, 12 Mar 2026 19:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773369826; x=1773974626; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q9hCuzuHEN/sMOidNnhHLkJz/g4iSobaxo8mhYZkdNU=; b=YcgO7OwdSmT1lEE2QGd97QDP+xEYFgoLtIIqgs7H9tTtJEwhFR46mmXg6EQVrvbdr4 mHL4DhGg504Y6zqkYbEUzhDov+JftRDWVoxlMoK0BkX2AzH83tSbCwcHTzK3MuGxR/gA TE20/wAKjpfjti6li10gtma1z5tge69nhxA5ARj6uAtpP1N5ukzyNly2RzYsBAFdY9Nm /p3pcz/PCqUGSdJp4cjETko2D6XnR/+jJ7RXqtdAXAKo6p/e/JDWPdlHrlWGKgQ8KYwI ztd3csBHmW8bcFCpQJp63YiQRi/FFFFeuHklzaH7WxFgaVorjpxEeIarZvzyq7DbjqDt +E4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773369826; x=1773974626; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q9hCuzuHEN/sMOidNnhHLkJz/g4iSobaxo8mhYZkdNU=; b=GP1nNyG4g63yvbC2TWUofC4eOVs/yY2XnGpeem1wEIub9mRHXlsKKxoX/59qhsFOBR wgaW0pROxsWZRD53KubYvqOtzOfScQRD4ElIvgzJWTO9pAOhwhpsJ9OMk0PW0oCmPJ0T m3WWY6Rk1YiBb1MZD49fvQQR9GtBo1TASx8xeyI0yRYhBiOMqzzL8Opl+YDaS+9d0L2j oNOUkduy6Ek4CCacYabZcKUfuuIhvR2DfM4Khkd14XtfpnzSdasIpyGX1hg7ZzK0hKuN RFGRRrJmxpG1C37knibaQyTdcPBy5oti+m1LkH7bDq1c2cj9n+XOUQHHf7ef0zGt1XuS kqqQ== X-Forwarded-Encrypted: i=1; AJvYcCUaKrJIz38eSVDmSqe3TXmAaqicDmGApUxowuUWosdRXrD1xSsoofGjjapnQIKDMG3hx2JCwS4GAR8Zb30=@vger.kernel.org X-Gm-Message-State: AOJu0YzSDY6Efpscp0HFAuq+w1UCJygKaOhLjFybKDPjJU0QbHkfEU21 6QYdP+QZGenHiHDC2kqKxE3gYM9+k/Ti/IcZue779G3MurekoG/tV+Ne X-Gm-Gg: ATEYQzxMYlYywrWcvuuTX5fXUzXga+D4+KJ5ixcXRzn5Cj/3raIiqTGtNdbaHXMVhcu Vh/yN17Z729aUkuoyJ0Oa3axdEDJEB7Mwcihdet/X0QLWzF32J0eKjQYz+qeCPc28e6sI0pZawv EMQ8PTOZDCNjvgafoKrUlr+7Im7f/aGDGYII9UNzzj3oYch+VTJQPSjvZ5cGUpUtBnHbdGtflhz MqE2bt08rfs5OYVLCi5scxFe04SHZLG3e37UTgkOrHS/v0Hu5/l6NJoYy0EO9iSutl8yjpASFay MfwFT5rx57tjagFBTFFK8dNaAA/Hr+rGS+K5pXoKw3UaIunVdJnKOPqsPhTOGChxYW/cbKrAojI YiwWZvuN4kRtqWsQxMYP5dEKaUTFnnF3If9+6K4br6pHClC0SVid2z8WV/acYURz0BMh4nR9Kr6 jdSWiimaqXFIBNqDkz88NoZkY= X-Received: by 2002:ac8:5fcb:0:b0:509:329e:bd5 with SMTP id d75a77b69052e-50957b909c8mr24981181cf.3.1773369825770; Thu, 12 Mar 2026 19:43:45 -0700 (PDT) Received: from localhost ([2001:19f0:8001:1b2d:5400:5ff:fefa:a95d]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5093a0ea844sm53518871cf.17.2026.03.12.19.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2026 19:43:45 -0700 (PDT) Date: Fri, 13 Mar 2026 10:43:05 +0800 From: Inochi Amaoto To: Jakub Kicinski , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "Russell King (Oracle)" , Yao Zi , Yanteng Si , Vladimir Oltean , Lad Prabhakar , Maxime Chevallier , Chen-Yu Tsai , Shangjuan Wei , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Yixun Lan , Longbin Li Subject: Re: [PATCH net-next v9 3/4] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260312012232.373713-1-inochiama@gmail.com> <20260312012232.373713-4-inochiama@gmail.com> <20260312193801.61c30de4@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312193801.61c30de4@kernel.org> On Thu, Mar 12, 2026 at 07:38:01PM -0700, Jakub Kicinski wrote: > Some nit picks only to be addressed in case the AI complaint on patch 1 > is legit.. > > On Thu, 12 Mar 2026 09:22:25 +0800 Inochi Amaoto wrote: > > +config DWMAC_SPACEMIT > > + tristate "Spacemit dwmac support" > > + depends on OF && (ARCH_SPACEMIT || COMPILE_TEST) > > + select MFD_SYSCON > > + default m if ARCH_SPACEMIT > > I know other STMMAC sub-drivers do it but isn't the defconfig for > the platform the right place to add this sort of default? > > > + apmu = syscon_regmap_lookup_by_phandle_args(pdev->dev.of_node, > > + "spacemit,apmu", 2, > > + offset); > > + if (IS_ERR(apmu)) > > + return dev_err_probe(dev, PTR_ERR(apmu), > > + "Failed to get apmu regmap\n"); > > looks mis-aligned Yes, that's true. I will fix this. Regards, Inochi