From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DB6923AB9D for ; Fri, 13 Mar 2026 10:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773396134; cv=none; b=ayNltYJzuwJKe9Ngzgj+5ZadUZco8bGc/7Q1m9l4xOrDuai9j5fM91ifH6JmLh1QcONHON4fAWFQOICTczMS7KdZyDCTRlALontPZP6aLzRvsDv/MoUYso+xxjOY/P0tQAFyKLUVcERr4w7GBEFkXvPfqAfuAsTg1YdGl0inZ1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773396134; c=relaxed/simple; bh=ZsuuHRO/3rVri9kUSf+/DKFSmDJcF38SjDAzIAvPpbE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bUCCpGElSz1+Kkz71KGCekMhJPAM26rZVYAO55l2SiDtvBkM7KODn8n5XfH4RK3xLskCQYMWWu69cBpHtJFfNr+GFhO0SQwIMd5QbAHhYt6WUdKJI7qAItMcXWAF1kumwkdF+HXCySulH62tNKlyL9tZ7WYxVaF9RbiLfz/5ckU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=M0uQgnoj; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="M0uQgnoj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773396134; x=1804932134; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZsuuHRO/3rVri9kUSf+/DKFSmDJcF38SjDAzIAvPpbE=; b=M0uQgnojabIkIWfDb7SSofFrTf0y4/p/tgzFe5B+dqScu1Yzricy/00k /URfia7Kmggszo+V8x0rMXmsIO4Ly9yFDhrMrnCVjQc3UjyR3CgC9daUL eIS+AjcSLmrbSrf0x4cxnDBxpa2hjuCrDpBRqO6NGx5AQxpK3oitnRoXO zNKpGHQxa4A9PZXzXYsfltSz3g/cCZjGNiMquN037ocHeORTBoYLPTsOs Y3l2WLtIIx4Bq5pTyPxsHwp37wevs/LKkyhT+elqespDsPnhF50TkWWIn d8dKnbNMvZjMDXTDpr3vimXzxW6irErrtEymYwK2DSOM2Stu5YWe1RGPr w==; X-CSE-ConnectionGUID: LWsquF2ESvOkotWdoqf5Yg== X-CSE-MsgGUID: eZLgRTHSTPK6ygzMhOkd2g== X-IronPort-AV: E=McAfee;i="6800,10657,11727"; a="73687823" X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="73687823" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 03:02:13 -0700 X-CSE-ConnectionGUID: nNaKHeYER9u4PtlwDtrckQ== X-CSE-MsgGUID: MQnmBWzsTaaeEUUZHE5AQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="225241092" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.246]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 03:02:10 -0700 Date: Fri, 13 Mar 2026 12:02:07 +0200 From: Andy Shevchenko To: Wang Jun <1742789905@qq.com> Cc: Andy Shevchenko , Andy Shevchenko , Geert Uytterhoeven , linux-kernel@vger.kernel.org, Andrew Morton , Randy Dunlap , gszhai@bjtu.edu.cn, 25125332@bjtu.edu.cn, 25125283@bjtu.edu.cn, 23120469@bjtu.edu.cn Subject: Re: [PATCH v3] auxdisplay: lcd2s: add error handling for i2c transfers Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Mar 12, 2026 at 10:51:36PM +0800, Wang Jun wrote: > The lcd2s_print() and lcd2s_gotoxy() functions currently ignore the > return value of lcd2s_i2c_master_send(), which can fail. This can lead > to silent data loss or incorrect cursor positioning. > > Add proper error checking: if the number of bytes sent does not match > the expected length, return -EIO; otherwise propagate any error code > from the I2C transfer. Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko