From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2183A39F183 for ; Fri, 13 Mar 2026 13:23:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408233; cv=none; b=G+Cbt6818BXF93YULfJgSVs8jiIJG4ArztJwPmQ9E78wNvl4LC9YTTKVksQzHuyPX60BLeHcUJnLplTpOKtVS5fd3t6xNzMDSLpIdF+WpmcQq3u/ICaHLATch7J5s6RJw9RxN4rtqLjCCgZywltVUxcMuFGZR4hXzMWzDgkKzRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773408233; c=relaxed/simple; bh=ZtHwRVLIvoDuwE15SqsQokaOwa/XA5uaZPU2Mzcfynw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IcbfkTz1No6UC+tisDuvIkUVZJTwuDyZKNCcaJwuEZiqNIyV5Cp2a2UTG1j1Fm40ByLb40PNwKSplYlATOpv6tWe75GBAdBI8PJxuofQYRkB9xxzSpQBwRDImm795D/OujBvT0x4W0QesZw6vSkfwPxH1+/aY4XQ2vbYMuHMKuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NIuhXoTP; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=MdIzn6yM; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NIuhXoTP"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="MdIzn6yM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773408231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R7HlaCIiaZDqWdp+o834N7JPGX2olX/c1Y000VF8Mwk=; b=NIuhXoTPTJxBfC2TqV4iGl+Ex9fz0azpXBZ2qegrTL3yspEsD9W2/L5u9ZY8Iw4XUy01w1 D+SDUopmOkD3a46TTOLv0xn6E97HtYA2Ktaev9E4dK5euPWuTRKEeunqUisoFxawVJba7N /wwdAZMRQU4R/CiFHJWuLjOu+C8tIEs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-5fFo9H93PWuaJcztvfhnVw-1; Fri, 13 Mar 2026 09:23:50 -0400 X-MC-Unique: 5fFo9H93PWuaJcztvfhnVw-1 X-Mimecast-MFC-AGG-ID: 5fFo9H93PWuaJcztvfhnVw_1773408229 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4836abfc742so15242415e9.0 for ; Fri, 13 Mar 2026 06:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773408228; x=1774013028; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R7HlaCIiaZDqWdp+o834N7JPGX2olX/c1Y000VF8Mwk=; b=MdIzn6yMpp7ebktkhBjKiXeonMs/GeNhUKlwouzBedyY52Rw/v84eYeI0PhYK11Wof WNMx7rYP/FuohqM+raU6O+3ISFLF0k7fMpXCYKT2I5MRgwuixTzd7zLTkcZAn1P34b/R wRUtneNTQ+X+Zaqr6oGZxeoMdLXn396FUD0F77QV2LW2eg0uMStxnoXRon/2rzN2XO8a l5F4uFHRUXGrE8c5Mg5v3tKcnrnFKsmw8pKSMR2vBYAsGr05CaddVhzBZb+CoIOqBbo9 pflavwF7ukUtEFl9cZq7nDnfSrWWEddJwh2sLW5Qygdvbw5ZIJgnDs24nFJYlfkrZTIA t3nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773408228; x=1774013028; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R7HlaCIiaZDqWdp+o834N7JPGX2olX/c1Y000VF8Mwk=; b=Xw+pE3FP0GUSZzEhR3REL9BLV/WjEQ1wNm3ehQVF05zH6q9GHazaFxuooOkoRr8tpo mdAuDPWToudrwVdWZ1Ar02o9o98lA5m3I3sQV0ou6aY3EfGzRuJmxXPg8UySjAlrS5Zv wflI0kDGlKS8K/jZdEZgz6z0MnXk4MCmO/43juFYnvh9WiEk8lahwDImVCOVHJKN/6Ju 7d5neRUWCdPjbBqtGjJBedKatPLFT58tl1U0wWl8g9A0zVDrGSl8bzsac6lblBn3nIC0 2tlLFgv/5CENuCB7PyXRnFecpqaaChPogmlzBHNvwE8EbVC1VeqYsN6basDwq13N9oaB y/DA== X-Gm-Message-State: AOJu0Yya9ucpMve5uKewRCLzpp1QdmcJVD9w8OglpQbn1xgPevEvKp5X uR/QHSQORPH1rOa/rtxkdDRIMCiXpPbjBkF2uOxdysykY7Q5M57eVth3CqlSXeKBENB3RZPUkgt QbbW3rNOBxq0/q6vjTYQVJZjzmaqxZmv7EIXgkhPgZkepKQWJs20g/MlsyaTygInla/HC6vThmA == X-Gm-Gg: ATEYQzx0fmGR2NVS44Hk0N/y90nW9ftjjHrXmzsIppaUip1KVnAKc3Oc4q/935DgbJm xpKhzU8qrv41SjKlOkL4UYfb8e09zVOTIGOFydcx0DkPSKq3TubOo7Aqap+oGd8cARa594TiYEf RFYEWH5Xu2fnLqrRWGfaMawoCtoaRJ9El5SfoplD4TU3AczzDy+c/G/Lmt4X4nIv9hS6eTWsK7S K3YqWp8JIaa/H114+YuKwe4+PjbWpuEK8nzLll0zWtQSNbLALsSfSDc74RYgU8s8DooL6IBtJdb o79yM0wA3a4IYe7kSoZ25TvWiTva+osYBVLcjDpdYXKIZvWPL2tTcd6p28NEcrziQ38ZoD6yfgt G+AS0IuE1lN7o3H+hzjWbsVLvtFqfXtIuq6itqzTMiITybJCv6pk= X-Received: by 2002:a05:600c:8b46:b0:485:34b3:858a with SMTP id 5b1f17b1804b1-485566d2d66mr52863285e9.11.1773408228605; Fri, 13 Mar 2026 06:23:48 -0700 (PDT) X-Received: by 2002:a05:600c:8b46:b0:485:34b3:858a with SMTP id 5b1f17b1804b1-485566d2d66mr52862635e9.11.1773408228148; Fri, 13 Mar 2026 06:23:48 -0700 (PDT) Received: from jlelli-thinkpadt14gen4.remote.csb ([151.29.82.96]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48557784c18sm51257345e9.4.2026.03.13.06.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2026 06:23:47 -0700 (PDT) Date: Fri, 13 Mar 2026 14:23:45 +0100 From: Juri Lelli To: gmonaco@redhat.com Cc: linux-kernel@vger.kernel.org, Steven Rostedt , Nam Cao , Juri Lelli , Jonathan Corbet , linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Tomas Glozar , Clark Williams , John Kacur Subject: Re: [PATCH v7 05/15] Documentation/rv: Add documentation about hybrid automata Message-ID: References: <20260310105627.332044-1-gmonaco@redhat.com> <20260310105627.332044-6-gmonaco@redhat.com> <4620e92b1c7f4d87f192a017f3026dfc17bcaef6.camel@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4620e92b1c7f4d87f192a017f3026dfc17bcaef6.camel@redhat.com> On 13/03/26 14:05, gmonaco@redhat.com wrote: > Hello, > > On Thu, 2026-03-12 at 11:39 +0100, Juri Lelli wrote: > > Very minor nit, feel free to ignore, but ... > > > > The formal 7-tuple definition includes 'i' (invariant function), but > > unlike other elements, 'i' isn't stored in the automaton struct - > > it's implemented as generated code in ha_verify_constraint(), IIUC. > > Worth a brief note clarifying this design choice so readers don't > > expect to find an invariants[] member in the struct? Here or below in > > the example C code section. > > Thanks for the review! I haven't really thought of that. > At this stage we are not mentioning any struct element (it's purely > theoretical), so there shouldn't be any expectation from the reader. > > Later I mention "The function verify_constraint checks guards, > performs resets and starts timers to validate invariants according to > specification". > In fact, also guards are not represented as part of 'function', I may > mention after that sentence something like: "those cannot easily be > represented in the automaton struct". > > Not sure if saying more wouldn't make it even more confusing than it > already is. Yeah, probably. As mentioned, feel free to ignore, it was just a thought. :)