From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D88E6175A9C; Fri, 13 Mar 2026 14:34:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773412457; cv=none; b=N7K+qiSnIRnk2WIUdPNyc6E4ikhcyIn7UGcBjNbFfPSoGTP7AW2FdltvcoSIFiqz1x0X9d9mrSXki4JCsosaQO6RlHxarZNw7OnRv1CYemps0LKMr0kYEsEGNR6Ggwsa+8lZizjEDy6FNO6/BI/RBAuKYmDkUd/FXOTbfEZX0f4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773412457; c=relaxed/simple; bh=RKTUaqioJ2zolu5YI1IwDnVHeW1fQdQf3qwJyJX8XOw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JqD6g6E+gTzbMAEECSZAoAFnqvUZa1+YmcG6RkjWKAAp9vOZoyO0cYqgFtd0/I72Z+uPoNoVPEfkqcI56KEAiTJL/gpD66YLbNxlE4vg8Y1KcR9UsQQF85JoUsZZVfjmT/A/QpGOlxkQzg1dQnKEuN6fA2A/ii13RkNP/fbouIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Xk//vMbq; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Xk//vMbq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773412455; x=1804948455; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RKTUaqioJ2zolu5YI1IwDnVHeW1fQdQf3qwJyJX8XOw=; b=Xk//vMbqYTAK0jWieDWiC34P4/m+DugVWTK+aiMmyOa9tE+WZDIVcplD UDVK1mRh5unqzuoqscmhVFZ8kSZoUvpM8LdSRvx1MKJIxNErM4pX7cYiP Mb6+uh6TtY9nExTWzVMCvl1zht/Ex1Z2XtXbWDBx++R2XDQE6e4QgcdQ7 yJBt87Gh+G0EO9rWbUdvwOz9VL4U76hN4IBT0q+RuAe30Knd+q+sQ/zcz Lge/3EjQo78SBopxGENkoF7bDXgdflPz35hXhxii5GaOcXztVIA3ZOl7D n82LvBOdqw9JkmK/tJOD3xgJ4FItS6cs8y81tpV1Wth14K44YFInz+LkU Q==; X-CSE-ConnectionGUID: g3B9YfNMQQSFPwboOo0ivA== X-CSE-MsgGUID: 5/25qEHjQhueXaLA6BUKNw== X-IronPort-AV: E=McAfee;i="6800,10657,11728"; a="73536599" X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="73536599" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 07:34:14 -0700 X-CSE-ConnectionGUID: uUKGtdhTSFOF6vyLxU5t3w== X-CSE-MsgGUID: 5O2EmwidS3KE+Kj3Wcsm6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="216084555" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.246]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 07:34:11 -0700 Date: Fri, 13 Mar 2026 16:34:09 +0200 From: Andy Shevchenko To: Siratul Islam Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] iio: proximity: add driver for ST VL53L1X ToF sensor Message-ID: References: <20260313113737.151881-1-email@sirat.me> <20260313113737.151881-3-email@sirat.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260313113737.151881-3-email@sirat.me> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, Mar 13, 2026 at 05:37:18PM +0600, Siratul Islam wrote: > Add support for the STMicroelectronics VL53L1X Time-of-Flight > ranging sensor with I2C interface. Now LGTM, Reviewed-by: Andy Shevchenko One nit-pick that can be dealt with later on (up to maintainers). ... > + reset_control_deassert(data->xshut_reset); No need to check for an error? -- With Best Regards, Andy Shevchenko