mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	pierluigi.p@variscite.com,
	Stefano Radaelli <stefano.r@variscite.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v3 06/11] arm64: dts: freescale: imx8mm-var-som: Update WiFi/BT with variants
Date: Fri, 13 Mar 2026 15:02:20 -0400	[thread overview]
Message-ID: <abRfPK0pUxFcb8sQ@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <abRDxRK_GFYwmAGE@Lord-Beerus.station>

On Fri, Mar 13, 2026 at 06:05:09PM +0100, Stefano Radaelli wrote:
> Hi Fabio,
>
> On Fri, Mar 13, 2026 at 01:52:31PM -0300, Fabio Estevam wrote:
> > On Fri, Mar 13, 2026 at 1:46 PM Stefano Radaelli
> > <stefano.radaelli21@gmail.com> wrote:
> >
> > > Correct. It is not included anywhere at the moment.
> > > The Symphony evaluation board uses the IW61x configuration.
> > > The imx8mm-var-som-wifi-brcm-legacy.dtsi file is kept as a separate include
> > > so that carrier boards using the legacy Broadcom-based SOM revision can
> > > include it if needed.
> >
> > Then imx8mm-var-som-wifi-brcm-legacy.dtsi is dead code. Nothing includes it.
> >
> > I don't think we want a dead dts in the tree.
> >
> > IW612 has not been upstreamed, right?
> >
> > People using the Broadcom Wi-Fi on the old board may still want to
> > continue using it.
> >
> > Please don't break it.
>
>
> Thanks for the feedback!
>
> I might have misunderstood the best approach here. The reason I split the
> WiFi/BT configuration into separate dtsi files was to follow the direction
> discussed in the previous revision, where we decided to keep support for the
> legacy Broadcom-based SOM while moving the configuration out of the
> device tree, giving the support for both modules revisions.
>
> However, I see your point that if it is not referenced anywhere it becomes
> dead code:
> Would it make sense to add a legacy Symphony DTS that includes the Broadcom
> configuration, in addition to the current Symphony DTS that uses the IW61x?

Yes.

Frank

> This way the existing boards would keep working while the default board
> description reflects the currently produced hardware.
>
> Or if you have any other suggestion, I'd be happy to follow it!
>
> Best regards,
> Stefano

  reply	other threads:[~2026-03-13 19:02 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 15:54 [PATCH v3 00/11] arm64: dts: freescale: imx8mm-var-som: Align SOM and Symphony DTSs Stefano Radaelli
2026-03-07 15:54 ` [PATCH v3 01/11] arm64: dts: freescale: imx8mm-var-som: Move UART4 description to Symphony Stefano Radaelli
2026-03-07 15:54 ` [PATCH v3 02/11] arm64: dts: freescale: imx8mm-var-som: Align fsl,pins tables Stefano Radaelli
2026-03-07 15:54 ` [PATCH v3 03/11] arm64: dts: freescale: imx8mm-var-som: Update FEC support with MaxLinear PHY Stefano Radaelli
2026-03-13 15:53   ` Frank Li
2026-03-19 16:00     ` Stefano Radaelli
2026-03-07 15:54 ` [PATCH v3 04/11] arm64: dts: freescale: imx8mm-var-som: Add support for WM8904 audio codec Stefano Radaelli
2026-03-13 15:55   ` Frank Li
2026-03-07 15:54 ` [PATCH v3 05/11] arm64: dts: freescale: imx8mm-var-som: Add MCP251xFD CAN controller Stefano Radaelli
2026-03-13 15:58   ` Frank Li
2026-03-07 15:54 ` [PATCH v3 06/11] arm64: dts: freescale: imx8mm-var-som: Update WiFi/BT with variants Stefano Radaelli
2026-03-13 16:01   ` Frank Li
2026-03-13 16:41   ` Fabio Estevam
2026-03-13 16:46     ` Stefano Radaelli
2026-03-13 16:52       ` Fabio Estevam
2026-03-13 17:05         ` Stefano Radaelli
2026-03-13 19:02           ` Frank Li [this message]
2026-03-13 19:31           ` Fabio Estevam
2026-03-07 15:54 ` [PATCH v3 07/11] arm64: dts: imx8mm-var-som-symphony: Move USB configuration from SOM Stefano Radaelli
2026-03-13 16:03   ` Frank Li
2026-03-07 15:54 ` [PATCH v3 08/11] arm64: dts: imx8mm-var-som-symphony: Enable uSD on USDHC2 Stefano Radaelli
2026-03-07 15:54 ` [PATCH v3 09/11] arm64: dts: imx8mm-var-som-symphony: Add TPM2 support Stefano Radaelli
2026-03-07 15:54 ` [PATCH v3 10/11] arm64: dts: imx8mm-var-som-symphony: Enable I2C4 Stefano Radaelli
2026-03-07 15:54 ` [PATCH v3 11/11] arm64: dts: imx8mm-var-som-symphony: Enable PCIe Stefano Radaelli
2026-03-13 16:07   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abRfPK0pUxFcb8sQ@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierluigi.p@variscite.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=stefano.r@variscite.com \
    --cc=stefano.radaelli21@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®