Re: [PATCH v2 3/4] net: dsa: mxl862xx: move API macros to mxl862xx-host.h

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hi,

On 5/21/26 04:40, Daniel Golle wrote:
> Move the MXL862XX_API_WRITE, MXL862XX_API_READ and
> MXL862XX_API_READ_QUIET convenience macros from mxl862xx.c to
> mxl862xx-host.h next to the mxl862xx_api_wrap() prototype they wrap.
> This makes them available to other compilation units that include
> mxl862xx-host.h, which is needed once the SerDes PCS code in
> mxl862xx-phylink.c also calls firmware commands.
> 
> No functional change.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>

Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

Maxime

> ---
> v2: no changes
> 
>   drivers/net/dsa/mxl862xx/mxl862xx-host.h | 8 ++++++++
>   drivers/net/dsa/mxl862xx/mxl862xx.c      | 7 -------
>   2 files changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/dsa/mxl862xx/mxl862xx-host.h b/drivers/net/dsa/mxl862xx/mxl862xx-host.h
> index 84512a30bc18..66d6ae198aff 100644
> --- a/drivers/net/dsa/mxl862xx/mxl862xx-host.h
> +++ b/drivers/net/dsa/mxl862xx/mxl862xx-host.h
> @@ -9,6 +9,14 @@ void mxl862xx_host_init(struct mxl862xx_priv *priv);
>   void mxl862xx_host_shutdown(struct mxl862xx_priv *priv);
>   int mxl862xx_api_wrap(struct mxl862xx_priv *priv, u16 cmd, void *data, u16 size,
>   		      bool read, bool quiet);
> +
> +#define MXL862XX_API_WRITE(dev, cmd, data) \
> +	mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), false, false)
> +#define MXL862XX_API_READ(dev, cmd, data) \
> +	mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), true, false)
> +#define MXL862XX_API_READ_QUIET(dev, cmd, data) \
> +	mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), true, true)
> +
>   int mxl862xx_reset(struct mxl862xx_priv *priv);
>   
>   #endif /* __MXL862XX_HOST_H */
> diff --git a/drivers/net/dsa/mxl862xx/mxl862xx.c b/drivers/net/dsa/mxl862xx/mxl862xx.c
> index a193f3c07d35..0b1a23364eb5 100644
> --- a/drivers/net/dsa/mxl862xx/mxl862xx.c
> +++ b/drivers/net/dsa/mxl862xx/mxl862xx.c
> @@ -24,13 +24,6 @@
>   #include "mxl862xx-host.h"
>   #include "mxl862xx-phylink.h"
>   
> -#define MXL862XX_API_WRITE(dev, cmd, data) \
> -	mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), false, false)
> -#define MXL862XX_API_READ(dev, cmd, data) \
> -	mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), true, false)
> -#define MXL862XX_API_READ_QUIET(dev, cmd, data) \
> -	mxl862xx_api_wrap(dev, cmd, &(data), sizeof((data)), true, true)
> -
>   /* Polling interval for RMON counter accumulation. At 2.5 Gbps with
>    * minimum-size (64-byte) frames, a 32-bit packet counter wraps in ~880s.
>    * 2s gives a comfortable margin.