From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.garry@huawei.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Christoph Hellwig <hch@infradead.org>
Cc: "Ewan D. Milne" <emilne@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Doug Gilbert <dgilbert@interlog.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
james.smart@broadcom.com
Subject: Re: [PATCH 1/4] scsi: core: constify pointer to scsi_host_template
Date: Mon, 25 Apr 2022 18:16:30 -0700 [thread overview]
Message-ID: <aba8999d-276d-f9e8-96b4-5d1cc4e82c53@acm.org> (raw)
In-Reply-To: <1bb53912-c5c3-7690-e82f-cf356ca87404@huawei.com>
On 4/25/22 06:04, John Garry wrote:
> On 25/04/2022 10:22, Krzysztof Kozlowski wrote:
>> For example scsi_proc_hostdir_rm(): 'present' and 'proc_dir' members.
>> Where should they be stored? Should they be moved to the Scsi_Host?
>>
>
> I don't think scsi_Host is appropriate as this is per-scsi host
> template, unless you see a way to do it that way. Alternatively we could
> keep a separate list of registered sht, like this:
>
> struct sht_proc_dir {
> int cnt;
> struct list_head list;
> struct proc_dir_entry *proc_dir;
> struct scsi_host_template *sht;
> };
> static LIST_HEAD(sht_proc_dir_list);
>
> void scsi_proc_hostdir_add(struct scsi_host_template *sht)
> {
> struct sht_proc_dir *dir;
>
> if (!sht->show_info)
> return;
>
> mutex_lock(&global_host_template_mutex);
> list_for_each_entry(dir, &sht_proc_dir_list, list) {
> if (dir->sht == sht) {
> dir->cnt++;
> goto out;
> }
> }
> dir = kzalloc(sizeof(*dir), GFP_KERNEL);
> if (!dir)
> goto out;
>
> dir->proc_dir = proc_mkdir(sht->proc_name, proc_scsi);
> if (!dir->proc_dir) {
> printk(KERN_ERR "%s: proc_mkdir failed for %s\n",
> __func__, sht->proc_name);
> kfree(dir);
> goto out;
> }
>
> dir->cnt++;
> list_add_tail(&dir->list, &sht_proc_dir_list);
> out:
> mutex_unlock(&global_host_template_mutex);
> }
How about removing scsi_proc_hostdir_add(), scsi_proc_hostdir_rm() and
all other code that creates files or directories under /proc/scsi? There
should be corresponding entries in sysfs for all /proc/scsi entries.
Some tools in sg3_utils use that directory so sg3_utils will have to be
updated.
Thanks,
Bart.
next prev parent reply other threads:[~2022-04-26 1:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 10:30 Krzysztof Kozlowski
2022-04-08 10:30 ` [PATCH 2/4] scsi: core: fix white-spaces Krzysztof Kozlowski
2022-05-04 8:47 ` Krzysztof Kozlowski
2022-04-08 10:30 ` [PATCH 3/4] scsi: ufs: ufshcd-pltfrm: constify pointed data Krzysztof Kozlowski
2022-04-08 10:30 ` [PATCH 4/4] scsi: ufs: ufshcd: " Krzysztof Kozlowski
2022-04-08 14:35 ` Bart Van Assche
2022-04-08 12:14 ` [PATCH 1/4] scsi: core: constify pointer to scsi_host_template John Garry
2022-04-08 12:32 ` Krzysztof Kozlowski
2022-04-08 12:57 ` John Garry
2022-04-08 19:31 ` Ewan D. Milne
2022-04-12 7:57 ` John Garry
2022-04-20 7:03 ` Christoph Hellwig
2022-04-25 8:58 ` John Garry
2022-04-25 9:22 ` Krzysztof Kozlowski
2022-04-25 13:04 ` John Garry
2022-04-26 1:16 ` Bart Van Assche [this message]
2022-04-26 1:54 ` Douglas Gilbert
2022-04-26 4:13 ` Bart Van Assche
2022-04-27 1:47 ` Douglas Gilbert
2022-05-06 16:42 ` Krzysztof Kozlowski
2022-05-09 11:28 ` John Garry
2022-05-09 13:20 ` Krzysztof Kozlowski
2022-05-09 14:50 ` John Garry
2022-05-11 8:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aba8999d-276d-f9e8-96b4-5d1cc4e82c53@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=dgilbert@interlog.com \
--cc=emilne@redhat.com \
--cc=hch@infradead.org \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®