From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B43C37D13C for ; Thu, 5 Mar 2026 10:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772705896; cv=none; b=PKbgnUywtiC868irJ8dHIGkb6B/gOBwHJiETtDA3jxWN7GGsJ6ZEJ2Gexlux5UKhADXwqtN/JlxbXnTZrss41IR38eT54oksnDrsXH8yHWaOOtslyvU/K9GaMltnx7J9SkBFSdWzt2iVlc48gFI8mAPEDBPFdwMO5g69YID/k+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772705896; c=relaxed/simple; bh=3DCiGsq5RqF1DOTCxVYVjabY1CfYAt48GVqi+OH0GHs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YdcMhgvF/bo+u3pjp5H7o6/PWVvk7g1z6lDF1PdXJbA7QP8rgEaHVm+wkJieQJM73lPRrMdyEtjPn0DXSSJbIkjRnvPSyH7jxZ3DXsMRIakkaf7ZSWsaM9o8RgVSy1R+a80ouBsj62RucGnsfruZ0/RJ4UYu31L9+69y/jmenkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=sdseIFM3; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=b9FvGrU6; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=sdseIFM3; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=b9FvGrU6; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="sdseIFM3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="b9FvGrU6"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="sdseIFM3"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="b9FvGrU6" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 490C43F839; Thu, 5 Mar 2026 10:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772705893; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sdos9HgNBRPQmvN1VE2fzeordnjggvR1CLbUrtu481U=; b=sdseIFM35Z48H6Cw9Uj2QiPNLOFk1nD3E4iOjbierfFGZUmEWp2eLtEPJgHwRRZy4C4Fd2 DbHHerzLbNfBr/fiPhkZktg+wrlPhugvqNqj2/a5gLVT+MFpRoCo5Ubs4sglJQCLr+Gdk8 XHZXXFUMHfcUb+377gTaKBUXl6O4h/M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772705893; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sdos9HgNBRPQmvN1VE2fzeordnjggvR1CLbUrtu481U=; b=b9FvGrU6kABi7XF9kpvDI4kJL1r8AfOhlQEy12NgSh81eShX/S7AV27/t+QR/sWfob+96n nXEEgV/Lr0TSZyCQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=sdseIFM3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=b9FvGrU6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772705893; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sdos9HgNBRPQmvN1VE2fzeordnjggvR1CLbUrtu481U=; b=sdseIFM35Z48H6Cw9Uj2QiPNLOFk1nD3E4iOjbierfFGZUmEWp2eLtEPJgHwRRZy4C4Fd2 DbHHerzLbNfBr/fiPhkZktg+wrlPhugvqNqj2/a5gLVT+MFpRoCo5Ubs4sglJQCLr+Gdk8 XHZXXFUMHfcUb+377gTaKBUXl6O4h/M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772705893; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Sdos9HgNBRPQmvN1VE2fzeordnjggvR1CLbUrtu481U=; b=b9FvGrU6kABi7XF9kpvDI4kJL1r8AfOhlQEy12NgSh81eShX/S7AV27/t+QR/sWfob+96n nXEEgV/Lr0TSZyCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0B65C3EA68; Thu, 5 Mar 2026 10:18:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id I11XAWVYqWlDYwAAD6G6ig (envelope-from ); Thu, 05 Mar 2026 10:18:13 +0000 Message-ID: Date: Thu, 5 Mar 2026 11:18:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH drm-misc-next v2 1/3] drm: verisilicon: make vs_format conversion function return int To: Icenowy Zheng , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Icenowy Zheng References: <20260305075926.3642501-1-zhengxingda@iscas.ac.cn> <20260305075926.3642501-2-zhengxingda@iscas.ac.cn> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260305075926.3642501-2-zhengxingda@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FREEMAIL_TO(0.00)[iscas.ac.cn,linux.intel.com,kernel.org,gmail.com,ffwll.ch]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,iscas.ac.cn:email,suse.de:mid,suse.de:dkim,suse.de:email,suse.com:url] X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 490C43F839 Hi Am 05.03.26 um 08:59 schrieb Icenowy Zheng: > This is for further proper invalid drm_format handling before committing > the plane state change. > > The return value is not yet checked yet, and will be checked in > atomic_check in the future. > > Signed-off-by: Icenowy Zheng Reviewed-by: Thomas Zimmermann > --- > Changes in v2: > - Move a bogus #include clause to the next patch. > > drivers/gpu/drm/verisilicon/vs_plane.c | 6 ++++-- > drivers/gpu/drm/verisilicon/vs_plane.h | 2 +- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/verisilicon/vs_plane.c b/drivers/gpu/drm/verisilicon/vs_plane.c > index 2f3953e588a34..fa88ed14e41d7 100644 > --- a/drivers/gpu/drm/verisilicon/vs_plane.c > +++ b/drivers/gpu/drm/verisilicon/vs_plane.c > @@ -12,7 +12,7 @@ > > #include "vs_plane.h" > > -void drm_format_to_vs_format(u32 drm_format, struct vs_format *vs_format) > +int drm_format_to_vs_format(u32 drm_format, struct vs_format *vs_format) > { > switch (drm_format) { > case DRM_FORMAT_XRGB4444: > @@ -62,7 +62,7 @@ void drm_format_to_vs_format(u32 drm_format, struct vs_format *vs_format) > vs_format->color = VSDC_COLOR_FORMAT_A2R10G10B10; > break; > default: > - pr_warn("Unexpected drm format!\n"); > + return -EINVAL; > } > > switch (drm_format) { > @@ -101,6 +101,8 @@ void drm_format_to_vs_format(u32 drm_format, struct vs_format *vs_format) > > /* N/A for non-YUV formats */ > vs_format->uv_swizzle = false; > + > + return 0; > } > > dma_addr_t vs_fb_get_dma_addr(struct drm_framebuffer *fb, > diff --git a/drivers/gpu/drm/verisilicon/vs_plane.h b/drivers/gpu/drm/verisilicon/vs_plane.h > index 41875ea3d66a5..a88cc19f2202e 100644 > --- a/drivers/gpu/drm/verisilicon/vs_plane.h > +++ b/drivers/gpu/drm/verisilicon/vs_plane.h > @@ -63,7 +63,7 @@ struct vs_format { > bool uv_swizzle; > }; > > -void drm_format_to_vs_format(u32 drm_format, struct vs_format *vs_format); > +int drm_format_to_vs_format(u32 drm_format, struct vs_format *vs_format); > dma_addr_t vs_fb_get_dma_addr(struct drm_framebuffer *fb, > const struct drm_rect *src_rect); > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)