mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Bailey Forrest <bcf@google.com>, Eric Dumazet <edumazet@google.com>
Cc: Mina Almasry <almasrymina@google.com>,
	joshwash@google.com, willemb@google.com, pkaligineedi@google.com,
	pabeni@redhat.com, kuba@kernel.org, jeroendb@google.com,
	hramamurthy@google.com, andrew+netdev@lunn.ch,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, darren.kenny@oracle.com
Subject: Re: [PATCH] gve: add missing NULL check for gve_alloc_pending_packet() in TX DQO
Date: Tue, 3 Jun 2025 14:33:59 +0530	[thread overview]
Message-ID: <abb065ab-1923-4154-8b79-f47a86a3d30e@oracle.com> (raw)
In-Reply-To: <CANH7hM5O7aq=bMybUqgMf5MxgAZm29RvCTO_oSOfAn1efZnKhg@mail.gmail.com>

Hi Bailey,

On 03-06-2025 00:54, Bailey Forrest wrote:
> Hi Alok,
> 
> I think this patch isn't needed. gve_tx_add_skb_dqo() is only called
> after checking gve_maybe_stop_tx_dqo(), which checks that
> gve_alloc_pending_packet() will not return NULL.


Thank you for the clarification,

Even so, I felt it could be a bit misleading for developers and tools. 
But if you believe the patch isn't required,I completely understand.
In that case, I kindly request you to provide your NACK on the [PATCH 
net v2] mail thread for formal tracking,
so that other developers can also be aware of the reasoning and 
understand the context.

Appreciate your time and feedback!


Thanks,
Alok

  reply	other threads:[~2025-06-03  9:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-01 19:34 Alok Tiwari
2025-06-01 19:49 ` Mina Almasry
2025-06-01 19:51   ` [External] : " ALOK TIWARI
2025-06-02  8:50     ` ALOK TIWARI
2025-06-02  9:56       ` Eric Dumazet
2025-06-02 19:24         ` Bailey Forrest
2025-06-03  9:03           ` ALOK TIWARI [this message]
2025-06-03 10:50             ` Paolo Abeni
2025-06-03 18:02               ` Bailey Forrest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abb065ab-1923-4154-8b79-f47a86a3d30e@oracle.com \
    --to=alok.a.tiwari@oracle.com \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bcf@google.com \
    --cc=darren.kenny@oracle.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hramamurthy@google.com \
    --cc=jeroendb@google.com \
    --cc=joshwash@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkaligineedi@google.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®