From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25CDAC43334 for ; Tue, 7 Jun 2022 09:56:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240215AbiFGJ4B (ORCPT ); Tue, 7 Jun 2022 05:56:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240233AbiFGJzr (ORCPT ); Tue, 7 Jun 2022 05:55:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 10AF1E77DF for ; Tue, 7 Jun 2022 02:55:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654595737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n7hfgQiB1fvAohjSL+LX1HTZTS0xE+mT9eAbQ5SA/1g=; b=SOUt+rEWmeggmduuimiUu8nP+9IBzP5/fZ1O4qRUKGVcdHdb+7IL5clPrZiwrM3TE89sRe gGN3g/ay1b53m3S8i5i9FUfWc3ZuzigKl3KEBQS+eGsL3X6r5Qx8nKE9mgDaYUUa6LhWzq N76bbrumz9+HBjEg8DPlsXOdb23WKfA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-619-lVVJu3AqPCOGD_GWVs8-lg-1; Tue, 07 Jun 2022 05:55:33 -0400 X-MC-Unique: lVVJu3AqPCOGD_GWVs8-lg-1 Received: by mail-wr1-f70.google.com with SMTP id bv8-20020a0560001f0800b002183c5d5c26so1568020wrb.20 for ; Tue, 07 Jun 2022 02:55:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=n7hfgQiB1fvAohjSL+LX1HTZTS0xE+mT9eAbQ5SA/1g=; b=MpYf+D3YuiH+3UTozOM5UU3LqqqlUGYurSCJc62qv4v+iz2aOz9FHxP4C5db/f9/XC TXTDH3ojeEsf/RRFvEkOX04QwAKzOHgQ7xP7IZTSSmaIo+PtRHBz19TkPtwryVmNki9I jPXPmahPVbkjZVbYLQVhDR9vDMhmWiM0lEmIsV1/xm2DFcqCte7DtUMYKNqkFlL4J/YN xwzh4YQ7KH7EPwEPc2PRmRta5lfDgFoqAogEKLaoUAuQMSiKm5CQR2XNJ/fq4PdinOuM JIve40h/tVkYlXzpe8MEOA3ovsMkG65i08JCEcy8ICxrn/DGkqMcoGjBr+XtxmTRAy4g vXEg== X-Gm-Message-State: AOAM530n5/LY4zcR9cGq3mlU7UxETGK7X79w0dQvn0ZJIwH407pMhO5Q r3SUMsHkmVtfk26C1FDwTW/kj3CKeSFLQiF1mZb5XuedGval1mCYpyev2krGN6Yh7zr/Rr8FokJ A59DquZ89wFS7rMd4R3YIpAo2 X-Received: by 2002:a5d:58c2:0:b0:210:2baa:52b8 with SMTP id o2-20020a5d58c2000000b002102baa52b8mr26772067wrf.20.1654595732390; Tue, 07 Jun 2022 02:55:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmQQjkSNT69Gzr83bM10Ninlkk05aLiBs5DvzsVAimhJHJr7sP1/XRhlCUmbBJ6Rae13u6jQ== X-Received: by 2002:a5d:58c2:0:b0:210:2baa:52b8 with SMTP id o2-20020a5d58c2000000b002102baa52b8mr26772049wrf.20.1654595732186; Tue, 07 Jun 2022 02:55:32 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-112-184.dyn.eolo.it. [146.241.112.184]) by smtp.gmail.com with ESMTPSA id bi11-20020a05600c3d8b00b0039c3ecdca66sm12636741wmb.23.2022.06.07.02.55.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jun 2022 02:55:31 -0700 (PDT) Message-ID: Subject: Re: [PATCH] stmmac: intel: Fix an error handling path in intel_eth_pci_probe() From: Paolo Abeni To: Christophe JAILLET , Wong Vee Khee Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Maxime Coquelin , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Date: Tue, 07 Jun 2022 11:55:30 +0200 In-Reply-To: <75b293bd-ec8d-8c90-ffe5-afa49d6a218d@wanadoo.fr> References: <1ac9b6787b0db83b0095711882c55c77c8ea8da0.1654462241.git.christophe.jaillet@wanadoo.fr> <20220606062650.GA31937@linux.intel.com> <75b293bd-ec8d-8c90-ffe5-afa49d6a218d@wanadoo.fr> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-06-06 at 22:42 +0200, Christophe JAILLET wrote: > Le 06/06/2022 à 08:26, Wong Vee Khee a écrit : > > On Sun, Jun 05, 2022 at 10:50:48PM +0200, Christophe JAILLET wrote: > > > When the managed API is used, there is no need to explicitly call > > > pci_free_irq_vectors(). > > > > > > This looks to be a left-over from the commit in the Fixes tag. Only the > > > .remove() function had been updated. > > > > > > So remove this unused function call and update goto label accordingly. > > > > > > Fixes: 8accc467758e ("stmmac: intel: use managed PCI function on probe and resume") > > > Signed-off-by: Christophe JAILLET > > > --- > > > drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 +--- > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > > LGTM > > > > Reviewed-by: Wong Vee Khee > > > > > > Hi, > > I've looked at it again. > > I still think that the patch is good, but pcim_release() has changed in > 5.18 since commit 3f35d2cf9fbc ("PCI/MSI: Decouple MSI[-X] disable from > pcim_release()") > > I guess that all the mechanic is in place so that everything is > registered when needed, but I've not been able to figure it out in the > case of dwmac-intel.c. > > So, double check :). AFACIS: stmmac_config_{single,multi}_msi -> pci_alloc_irq_vectors -> pci_alloc_irq_vectors_affinity -> __pci_enable_msix_range -> pcim_setup_msi_release So LGTM, thanks! Paolo