From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751806AbdJWUA2 (ORCPT ); Mon, 23 Oct 2017 16:00:28 -0400 Received: from mail-bl2nam02on0053.outbound.protection.outlook.com ([104.47.38.53]:64352 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751113AbdJWUA0 (ORCPT ); Mon, 23 Oct 2017 16:00:26 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v6 16/38] crypto: ccp: Implement SEV_PEK_GEN ioctl command To: Borislav Petkov References: <20171020023413.122280-1-brijesh.singh@amd.com> <20171020023413.122280-17-brijesh.singh@amd.com> <20171023093240.GC19523@nazgul.tnic> <20171023123223.GA24208@nazgul.tnic> <66c9f41e-868e-0d14-aaec-0858753c86d4@amd.com> <20171023141032.GC3044@nazgul.tnic> From: Brijesh Singh Message-ID: Date: Mon, 23 Oct 2017 15:00:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171023141032.GC3044@nazgul.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR02CA0041.namprd02.prod.outlook.com (10.175.57.155) To SN1PR12MB0157.namprd12.prod.outlook.com (10.162.3.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f40aabe0-866a-4c45-43f5-08d51a50b262 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:SN1PR12MB0157; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;3:dUoo6vBqPSLO5IdNWyXDL/1ebsInZtmTNANxHO9p0jwAYbiytP/0VL1Amu81ThFHIk6XrzW7QtFUCgWL840uner578rGQ1Q4uo1hWKPUWzub7E7mf6bES8TA/PgK0YxMLavTU9kdC/3NucC6NWOHq90MVl+6Pq5dL5eFXcWe45NeNGI3y5W2JAMSJfKVcWlFfqyL96NQnnqCQPamDxwnIVRKgyuwBIvVv6vEUhbEMWazmIRBT0K0UALKVyrLsjSL;25:F+8fVWa83G33maXrx3uPYI0UFqadD1PDv5q/nDEsrZq8p7Nu7gdFKYYv73QYr9OpqgD0snQV7H5KZrfr8n+iW+MkgrnG0GFMFVvn348iSy/2lCpjHd37nAOyeQPpGxuauVrVfBIsawuNutF6oQV7rGaj5H228dt6Nw5X6Wjmk3h83JBjZACHRHEWjtxRBJRl7kQWu2tbJ05US2oXlmvC99P+cHrV3aXJBH2f+wtFDJRw8F0WropgfIb62k4zXSOH+ZMYcBAQQYnKWMLyosmLDLavydgln1TUw1CpUAzld3+8EwBbRmJfdSrejx3jLkb/UapvBoTy4VdzFAs4Ev7nBQ==;31:Kunndgw27+IEJUK9YCqCJWLjaUCPjpUSowFZ8OSxd4aWWgIhXdmt/dBG+IWbCNMdWoFwvmu2EN8s2sSFivtBX30zK7Q1bG9O9p+PipnhVCGmVMh8eGULOAIBirELJuxjrOUt0Qw3fBF3E+uZRqZzyMd1PiWpV2OCO3zT3WUpTKqXhAj71POK+ft2dV48yTiMF8GsXeyuXupX8bo9GRzUbnwpzSdj0JObeO7zwBquywM= X-MS-TrafficTypeDiagnostic: SN1PR12MB0157: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;20:s4HW+iZrHbjpwblm9ml8OAu10FlviqHq/yBso9weW/DZsOv05D+6hmC56alTGhnqAijchW0M3K5n1hqMvNcSSPXFx1sMZSzXFoagnwCyDJLheiknqWm21WnjkWJ4cVSJrG3PlFuMgP+CtaEyvDL4LhRRgFA+MifOFv15EROSzkxWtnSSJITuvQS/KrBR4of8bLg9JWkMwvTpfWKY2EG0NYaI/owEN3D87lN37v73dgc+OhrOwdNfuf/IYLMxVg22aZ7zl2dCZ8CYhuDs2XZmzSHuyH0zLgd0q3Bz8hk27NeXm0UO9gIM5W2d4O7hV09mnTW33ckRWJbH3J8zEyfIyr/4RLuNHEGQtsRn22A4LG5Zazh6swY3IiXNmr6u1Ce4OTf0ZqoxgmQbpAzBdNrxZ01l+0ntwiiT3s/EytFSbJS0LozFYdCHywNx8Exe2Z0aQz6GP1je/A+h11isaRLe9TGQf8XECoH+6RbIeXbeFuMkerAL1i8gVWvNCkDUbK1I;4:GjlXAznwlr5Klife+kmW14whWT9559vkBbhe0UiTySTjYeZwdz9vW5LaLfAEGM/x178VnmlhPHPjpT5+CwG8zi97ymlPq3Z5B/BswJSM2U5pJm0cIoAN/plN2+LKVOzwJ39S3A9TdfR1SpbEPsE3PizVoeIxcpHUSK0DaSbgMYphxJLjrirlmqDm7UW1fuBjYuBGpMCVsTw/mNvt/9UepmHjfOOgUTyFO3qq29JLv0JUdxXQfhmqUWuglkFrjYRs X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(3231020)(6055026)(6041248)(20161123558100)(20161123564025)(20161123555025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0157;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0157; X-Forefront-PRVS: 046985391D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(39860400002)(346002)(376002)(199003)(189002)(24454002)(31696002)(5660300001)(68736007)(65826007)(83506002)(65806001)(4326008)(25786009)(77096006)(90366009)(6246003)(50466002)(6486002)(33646002)(81166006)(81156014)(53546010)(58126008)(65956001)(2906002)(54906003)(478600001)(53936002)(6666003)(105586002)(86362001)(66066001)(305945005)(6916009)(2950100002)(31686004)(47776003)(23676002)(36756003)(50986999)(54356999)(76176999)(316002)(7736002)(230700001)(97736004)(93886005)(8676002)(64126003)(8936002)(106356001)(229853002)(16526018)(3846002)(16576012)(189998001)(101416001)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0157;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU3OzIzOkZzTEVMQnUvTCs0bGFncDl6dzY3Q2FMazlv?= =?utf-8?B?MGgxRi9sUTBpOXhqTzJzNmFoZThLMjh2MHBLejByN3hESFpPbEJSUHdZWW9J?= =?utf-8?B?OUxJL0FZWG9vOVUxcXlNd09XN1c5cGhXSHBDZmVCZnk3TDhCcmM1WkUxbDJN?= =?utf-8?B?VDB6T2JLL0l3YkovMGFkQ0tvaEc2WnRRMHNaUnR1OXpBM0xrcWR4S3FVSHE2?= =?utf-8?B?WnI1bW5DbkJYbldIaE1YaDV1SlZwVFk3d09sQzJ2d2R5SFVrWmg0Z0tPRytV?= =?utf-8?B?L3NXRVljaDBPU0tYOVBNZEFBU3BtQlJLc3ZONEVTVTEzU2g2b1VXTGZXVDZM?= =?utf-8?B?dmNqTEI1TERaeXBGdCtRa1hZN0U0MUZyaTdRZnV4M0UzN0ZaekZIVFJzU0xP?= =?utf-8?B?ZDd1N3A2eTVBYWx3eitjVGUyWVRtMXlrOUNKcWRycVdMSHRneFJ3QWpmZTZj?= =?utf-8?B?RUJtU2hOckU5MnZEdVNyWGg2Q2Y1WW5aa21tK043OFJ6VVplUWp2VnNDbUNn?= =?utf-8?B?SXpCVUpPQ05jditiQ1Y4bW1PeU12cjRMTU9qaHRPQTlWMVNmciswU2tWQzgv?= =?utf-8?B?TS9LaVhlWXM4SEN2VzNtVExQUUZEMGRPMkdwTFIxN1dpTjkrTjEvMGliUjZi?= =?utf-8?B?RkozUlRrZG1KY3VNV3FRMC9vNnREREpQeHM5aDhUY29JaUQvUDlUQThBckV2?= =?utf-8?B?SzhnVHdXY0lQcWhaUkkwSHlvQmNNQklaMy9KOXNUOWJDY1FBUVJKQ1FCeitG?= =?utf-8?B?cnN6cE1iakJCeWlWUGIreWpFaEdQaFA0Y3ZPZ2s3ZnVjZlExNjF0V3hqbkUv?= =?utf-8?B?WjJKK0RsZi9NYWN0MlZLNFZZdjlrUEFHd0V4c1ZCVVlmZE1zZW11eU5mY1p1?= =?utf-8?B?SFpObHBXb2tkZ1lNa3lHdlhUc3dFU0ZZRDczbU8rZ0c2NlpjcWJZdEtqL2Qw?= =?utf-8?B?L3V3RXBGUGJLcTNrRFRhQ010bVQzZGxRTllDbzZzRFgwcUs4dzExcVZ6UmZD?= =?utf-8?B?SWxzNU1hRVRYTktqSGVzRnRidjNjSlBQYndldzNHKzdnRXdQVFBlZTBaS3Rr?= =?utf-8?B?dnFQTTJZS2E0Z1kvd3lmWUFGOGxac2FjbkFrRVV6T1VEcnVXaktOK0VzSU1Y?= =?utf-8?B?TG1wN1drc05tYmJFUU1xWTJPZWZwSGozeFhnOXo2clhlMDRrYTVTbmtITGVN?= =?utf-8?B?eFgyWUw0Q0ZLc1FkZDBnNHRuTjZxYUVEd25NNDE5SlpFc3ZiNnE5clgwUk52?= =?utf-8?B?ME01VjY2Rkc5M1puaW4yVmpkUzJDbndFcnFNOHgya0oxenF3TEhPd0FpRGNr?= =?utf-8?B?UHhUVXJscHdtMGFQTDRhUnhUVlNmV1NyaWU1R1NTT3pyMDlwMy9FcTM2aTU5?= =?utf-8?B?RzlCb1YxenI3ZEVCMk1GUVdHLzNNa3BRVjkrbmgxdDU5SlpGN2dGNFBtdEdw?= =?utf-8?B?NnhNRDZDY3diZ1ZUZkpPVitnbFRwOGFIM05zYUdIV09GNG5HaHhKbWVWc3l1?= =?utf-8?B?MnhRVEduSm53aVlTYklscGkyOGU1azAzRVpBTzYvS3JlamdCUkZodkw0Smoy?= =?utf-8?B?dm01ZlA3V0tSKy80TWtSWmkwRzUzaDg1dVVDblhna3R6a0hmY3IzZkN6dHB2?= =?utf-8?B?WUk5OVQvOHpnWjZUMGd5dldpR2g0MWRDOHZ1RkZFUmhKTVEwdVJuQnpvVElR?= =?utf-8?B?eDJkb0RLTmRiYWpPc2piV0lyM2ZlbTFYdmRFTis5VVgyVW85bGJPMHFwUjNz?= =?utf-8?B?K0pRc2U5bUhZRTYzUHhLQlU5Q0d2MFE1ZVdYZ0txTWpybUVLS2VEdjVlTjBl?= =?utf-8?B?OWFTZjVnSXZHcDRFc3RzMHBIN3JsTFZwNC9iS0E0ZUtsT2dsSHV0TjZrQ0E0?= =?utf-8?Q?kmFxbgmvAVKG+5HFjfVXG8wz1hLw+ZDR?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;6:XaJJM1oiPdyRxLnqoAQogE4n5JuXRw4GxsfrIZRncmeFVUd3tOvAN5R40QJxMzsL0qhP0tcjTrcGkC9rW3dz5rxfgIU/KtE6BTihbsH1b0bkWT3vRhIHvAcK0dmecVn1paUo8LASBmAZQ3QCS68yLajD/6Q95fCTbgnA6gdpcyFBftKou4Mu11eBnWu/FbygnVzV0AKRCeMGiv2NwNSLXl3frdnk6RORujTL8Yrb2Lsgwvdi9gFDEG4IqyKqooAOtglou7p3qO4ffy7wnIsgBdezBwWBnA1LdniFfHZBUM50JLlNZI0ltmNQoaGm5k4pKXHwGu+/HNtUD8kMNLObJA==;5:v7vkr4pmTCrSabKpNzsiSsOzrrnS3BoZ5ZjVkXtEJJfI1NanAE0Re14HyZZ/0XqAjjtuuB4FKHnky50TeHSRUCUZ4v1h7WIFvTOxXkhmYG/o+t0ggegKI3eaNWftmWR2Ruf0D5hmai8RF0sX9xOR7g==;24:R60kHnqYNiW6xU94gPztagyJGhMCdgQXzaZZFc0+HyQ5XWa4JkWHgRrUNyyM1RCgun6P9BRz7pzaZvVP8rV6/2dvQpQ9gofBpw/ZlWhUcws=;7:9DOanTrwU1BjQCAHGu78UcgOKNAilPpswqFXRFIUC4yJZsmXO1zL8SSlH1ib0Tub9+NdBThUZxsW9jwph51GpC7ztHeRZxBjbFnktRwsvBRDFK6Nf2uSqlSJzGbsFxkc4fv7TqIwsyUeNHQqU1BOSkwLm9k1f2iBRiDdHFL8hPyZxSz26Kbg1jFyuHb0Wn1MZ+x4Z248Ev012VVxn7buSdDdIyC1CRVSkVSS/W3W7fE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0157;20:4KDB0xF6H2T9FpHjIkNnDqJmweNXb6I7nD9kBu3fvg3ODD5SsL9iS7NFwuxzdBYADuhH3X45hSchiWd3n+2e5f9qG7DL5I4GpDJ5q5KfoN5u8Avqu2w9Da4EbsEyxLfp+LG8X2mAKxwFRNbUPTX5CWDxHKRbFODbtBDzX2+yhrSdePfvQKDxM0Tuck6CI1fk/EeYQdo97BodPUi6FsD2hJJUDp7rkvBoprJGItUQ/5GEnvIVb/podF0W64uVnQVN X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2017 20:00:22.8720 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f40aabe0-866a-4c45-43f5-08d51a50b262 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0157 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2017 09:10 AM, Borislav Petkov wrote: > On Mon, Oct 23, 2017 at 08:32:57AM -0500, Brijesh Singh wrote: >> If both the command fails then we return status from the last command. >> IIRC, in my previous patches I was returning status from sev_do_cmd() >> instead of sev_platform_shutdown() but based on our previous >> communication I thought you asked to return the status from the last >> failed command. Did I miss understood ? > > So my problem is that it looks strange that you save an error value from > sev_do_cmd() but you don't look at it. And as I said in the other mail, > you should either ignore it and say so in a comment why it is OK to > ignore it or handle it but not overwrite it without looking at it. > > Does that make more sense? > I see your point, if both commands failed then I am now inclined towards ignoring the error code from shutdown command and add some comments explaining why its OK. thanks -Brijesh