From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013013.outbound.protection.outlook.com [40.93.201.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18DA93ACF0A for ; Wed, 15 Jul 2026 03:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784087419; cv=fail; b=MwTRr4ERkvcoFO/z7XkUNq4ZrAbmImrkI8IH76+xwoa9MRr89GsBP4RQPI9xFskYEtDvpZgvDx1Qw9NedG9eVWR26Xxr4CAuSzx+YdAP3I7FB7/Y05qI9Z4EP+YkGhMRReG4WL3iqfSOibofV93tgm+YMJ6OvxlYqzE9WLH0uKc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784087419; c=relaxed/simple; bh=L8LoB0VrAUVHhpJKTDiXatvZQI+teZUJAnFV6eTFlLQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=mx9hraXEpQgtgIdulk08Eah37N+TII7tI5Pfv2NUzJL96auo0E3Lf/ziGw8hct5LkqvZDYWRloSh8gwJXCklInaCpGlzQPcLusy5cR4BvQKBtWOAu0R1am7B9CP/FUqIX/ertTt7clCB3Poz4HFx5FQ4KnuBtmnRQ68QrvaV+aw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=N3iHboYM; arc=fail smtp.client-ip=40.93.201.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="N3iHboYM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UbFoCb+YCYi9ZGGMfU3BI59dVaaGoXUfLUYkKBNe4iR0FvIj6E2IcRv0zj80XGhdKhu83KbAJ1bgElsYpJGWJXNvq6UAcMZHVe6QfgSBkkFIw/Hnt/a78qIo3tmYoYXd/t2nHgwd9mZgPWDPngx+kp6Fhyq+4CJc8zkZKWXcK2jl+Txr1WSwZ2FIYlfmFt205mvHdK1LMM2/1I15Rjvu6sTtvEDJ8t+9uGXvn6zuExQnMorEMHDckEW0+ow39Eq8mONHVNPzFq2Nk/b/IK1v8K0LXjU7csIeZWUIhHplb+jmRy+HR4U8p57JqsyiFJQxWMuLHbJWpj1EDD6UBgL9TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FeIwMVLESiYacSBrj01pbWECDFhq8/eX7mjSjlS+ABs=; b=fBCZx9lP5oFU+anSIYreT99hm5Zp/xMNW6j/Wg133i3WpB7pLJMNTczT3C0/rA5FBlKD58hmwNRQkJ5tgZVFKbvqbX2nwujC6wmgAwhvnEbl9ExH4nOWOIlFqgFJ2VIj5tHFYDQBKbOhiYh8w9jaGAHqqyCT6YgiasWJJCSpxYVvNnFYie9uBQkd5NynRKQD0t9bkMSSlakJq7ozdiJN9DHhWBp2CJ22/6kVFoXq5ks9RFt4peRCe0kZI4lcwwyRYc/R1q2Q76p0YQ7j5qOvI3yOxOlwhnwsQAJaiegVaPpxesVKso0r4JzRP0jXxuP4X7LN7LK4PiR9f6lojs2IlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.dev smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FeIwMVLESiYacSBrj01pbWECDFhq8/eX7mjSjlS+ABs=; b=N3iHboYM3cobjc+fPgF/cMCHF68BmlQOD7bh9h/PLcNb0gtrFZDqV8rprCdYtEuXOJMMLU16azuwuEw7fMcoWfOPICdzdKFsXm+nLISkPgRmNZPs4oQbTzEH220IQtOyydjqLRWtzPKc1OtEFcWza5gECWGjbLWzXd5Nr9XuKIA= Received: from BL1P223CA0029.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::34) by PH7PR12MB9067.namprd12.prod.outlook.com (2603:10b6:510:1f5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.9; Wed, 15 Jul 2026 03:50:11 +0000 Received: from BL02EPF0002992D.namprd02.prod.outlook.com (2603:10b6:208:2c4:cafe::aa) by BL1P223CA0029.outlook.office365.com (2603:10b6:208:2c4::34) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.223.10 via Frontend Transport; Wed, 15 Jul 2026 03:50:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BL02EPF0002992D.mail.protection.outlook.com (10.167.249.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.9 via Frontend Transport; Wed, 15 Jul 2026 03:50:10 +0000 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Tue, 14 Jul 2026 22:50:10 -0500 Received: from [10.136.35.249] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Tue, 14 Jul 2026 22:50:03 -0500 Message-ID: Date: Wed, 15 Jul 2026 09:19:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/psi: use for_each_set_bit() in psi_group_change() task-count walk To: Usama Arif , , , , , , , , , , , , , , , References: <20260714142057.181135-1-usama.arif@linux.dev> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260714142057.181135-1-usama.arif@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0002992D:EE_|PH7PR12MB9067:EE_ X-MS-Office365-Filtering-Correlation-Id: b3288dfc-89fd-4d92-6c8a-08dee2242b77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|376014|1800799024|82310400026|36860700016|18002099003|22082099003|56012099006|11063799006|921020; X-Microsoft-Antispam-Message-Info: YIO+UmLlzqB7VII7rzLYU0YNTmMnVeE5XGCPbyca/lEUkInSTo3GMQHfXmyL5f9HIrb14m3n84NMa6sXTrbyhisFyQF4+gYXFeOyv7fM51KDLwqyu3TP58Y5GSaoUkdJfBiigJIhWR9pU/+U71I5w4XkV0pmqOGMg23wcLnthUIIl5W+1zBFxScz6fHaO6XNf12GJwzwuF3tayIpWy3zJKf5pFG1cpruezazpRFeWAh0LJ2fJaYM46cBASY5dqaxiEhp6NTNq6u2Da3A4Vp2bv5ef0y5hIwOGJbKjr2fTDlKY4RWxygp9/qrcz1TKofoM5UGf86R6NdCRkAlOjN6t4fv+SNtgAviXWincd2XbnU+pXijSW+YL+TIrWZCR9+/nR7vgOZkVAHiYngNttCyp2AZmj8VIHMXs9IKUviKEoWF/xKkX+5ohgb/94KKeajTUkyBst/L2d0StZIms54QcEVakqTC6LSSFd+canfspgIHiE1RI+UwDB6CLJ6OvHXlMyMbFJTgkq1RDmvrWdDENqjLb7gZ+5aOhv5guFp9vJINhkzoPvGBBNy0A9CwK4Ds5WuKTsj6W4Y8MwkmHqCc9h29AhzHzJ9snwdBSWs5Rk9BD6vueyfGxVn2dZ7qNeLsme0wf+hUBKxUqylDKqR1w1mYMOQbtrUPKyJ00svya/qLlgUaG8aGvmQUJuPV485n2L83BHiGqEjJJ0HNp2M0bn253DHNTapdvzFwmErPs3cIV+MSzkHIFVtVZm9782vE X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(376014)(1800799024)(82310400026)(36860700016)(18002099003)(22082099003)(56012099006)(11063799006)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 973vkgJAy1/qicTtGeAId6L9dZNSYHB+OzTInYgClErOrshChzdXdHzDeskLXJQmPKQJcZAgb0ag8hewao0LNb+NUM4U2CAeP4A8onJV571N1cHZLoZNIfp22EY5SF9LAvqQk3RSj3+HPa0Z7Qa9do/lZgvhQ3/d8G/ypkvpjui/N5xK+QqkbT0J2M8f1jyjK90J846ZwXGPkyJXICD6JdLrCsCexJ8BTloyuVov1tBt8GCSO+FX5cPT00QrSFb+0+hpWQrYMNPcHAxbWGgakXkdAWRmrLIZrp5hTM5ewqM7kTZ+5h7wtkUN9p8LeSa15jk0fod2n6Pv+DOfBFbuCVyFPqs30QT/axgB/4LEgfezTXoFmhsD+TaF2npcT3idcNk8ry9yPfv3QVjgb3G1yqustlblww6g1OsJ1myR7sIiQ3cfUJ8eohHMjmP5UCk5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2026 03:50:10.8750 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b3288dfc-89fd-4d92-6c8a-08dee2242b77 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0002992D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9067 Hello Usama, On 7/14/2026 7:50 PM, Usama Arif wrote: > diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c > index d9c9d9480a45..f5ae1ceb21a7 100644 > --- a/kernel/sched/psi.c > +++ b/kernel/sched/psi.c > @@ -798,7 +798,8 @@ static void psi_group_change(struct psi_group *group, int cpu, > u64 now, bool wake_clock) > { > struct psi_group_cpu *groupc; > - unsigned int t, m; > + unsigned long clear_bits, set_bits; > + unsigned int t; > u32 state_mask; > > lockdep_assert_rq_held(cpu_rq(cpu)); > @@ -824,9 +825,8 @@ static void psi_group_change(struct psi_group *group, int cpu, > * The rest of the state mask is calculated based on the task > * counts. Update those first, then construct the mask. > */ > - for (t = 0, m = clear; m; m &= ~(1 << t), t++) { > - if (!(m & (1 << t))) > - continue; > + clear_bits = clear; nit. Can't we convert the arguments to unsigned long instead of assigning them to these local variables? Apart form that, for_each_set_bit() is indeed much cleaner. Feel free to include: Reviewed-by: K Prateek Nayak > + for_each_set_bit(t, &clear_bits, NR_PSI_TASK_COUNTS) { > if (groupc->tasks[t]) { > groupc->tasks[t]--; > } else if (!psi_bug) { -- Thanks and Regards, Prateek