mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil+cisco@kernel.org>
To: Sunny Patel <nueralspacetech@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Hans Verkuil <hverkuil@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Ricardo Ribalda <ribalda@chromium.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: v4l2-ctrls: Enable support for u64 value
Date: Sun, 31 Aug 2025 11:06:38 +0200	[thread overview]
Message-ID: <abd7a0e3-abe2-4125-8ddd-9dfad24a704b@kernel.org> (raw)
In-Reply-To: <20250831080606.35545-1-nueralspacetech@gmail.com>

On 31/08/2025 10:06, Sunny Patel wrote:
> Added Support for unsigned 64 bit value
> 
> Signed-off-by: Sunny Patel <nueralspacetech@gmail.com>
> ---
>  include/media/v4l2-ctrls.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index c32c46286441..7b2bc459f378 100644
> --- a/include/media/v4l2-ctrls.h
> +++ b/include/media/v4l2-ctrls.h
> @@ -250,6 +250,7 @@ typedef void (*v4l2_ctrl_notify_fnc)(struct v4l2_ctrl *ctrl, void *priv);
>   * @cur.val:	The control's current value, if the @type is represented via
>   *		a u32 integer (see &enum v4l2_ctrl_type).
>   * @val:	The control's new s32 value.
> + * @val64:	The control's new u64 value.
>   * @p_def:	The control's default value represented via a union which
>   *		provides a standard way of accessing control types
>   *		through a pointer (for compound controls only).
> @@ -313,6 +314,7 @@ struct v4l2_ctrl {
>  	void *p_array;
>  	u32 p_array_alloc_elems;
>  	s32 val;
> +	u64 val64;
>  	struct {
>  		s32 val;
>  	} cur;

????

This patch makes no sense whatsoever. Rejecting.

Regards,

	Hans

      reply	other threads:[~2025-08-31  9:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-31  8:06 Sunny Patel
2025-08-31  9:06 ` Hans Verkuil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abd7a0e3-abe2-4125-8ddd-9dfad24a704b@kernel.org \
    --to=hverkuil+cisco@kernel.org \
    --cc=hverkuil@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=nueralspacetech@gmail.com \
    --cc=ribalda@chromium.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®