From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gianluca Boiano <morf3089@gmail.com>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: sound: add Texas Instruments TAS2557
Date: Fri, 20 Nov 2026 09:50:21 +0100 [thread overview]
Message-ID: <abd82191-f084-41f6-b916-fb67ae18d562@kernel.org> (raw)
In-Reply-To: <20261120004442.1687225-2-morf3089@gmail.com>
On 20/11/2026 01:44, Gianluca Boiano wrote:
> On Sun, Jul 19, 2026 at 10:33:15AM +0200, Krzysztof Kozlowski wrote:
>> This paragraph does not look useful in commit log. This is part of
>> changelog rather.
>
> Moved to the changelog in v4.
>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>
> Thanks. I did not carry it to v4 because the binding changed:
> reset-gpios and interrupts take one entry per reg entry, ti,asi-port
> is new, ti,imon-slot-nos/ti,vmon-slot-nos are gone (the register they
> were written to only holds the I-sense scale) and firmware-name is
> required for two chips.
>
Did you just respond to review from July? That you ask to do it again?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-20 8:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 23:33 [PATCH v3 0/2] ASoC: codecs: add Texas Instruments TAS2557 smart amplifier driver Gianluca Boiano
2026-07-17 23:33 ` [PATCH v3 1/2] dt-bindings: sound: add Texas Instruments TAS2557 Gianluca Boiano
2026-07-19 8:33 ` Krzysztof Kozlowski
2026-11-20 0:44 ` Gianluca Boiano
2026-11-20 8:50 ` Krzysztof Kozlowski [this message]
2026-07-17 23:34 ` [PATCH v3 2/2] ASoC: codecs: add TAS2557 mono smart amplifier driver Gianluca Boiano
2026-07-18 15:36 ` Markus Elfring
2026-11-20 0:44 ` Gianluca Boiano
2026-07-19 19:05 ` Mark Brown
2026-11-20 0:44 ` Gianluca Boiano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abd82191-f084-41f6-b916-fb67ae18d562@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=morf3089@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®