From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946988AbcHRNdL (ORCPT ); Thu, 18 Aug 2016 09:33:11 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:60936 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946675AbcHRNdJ (ORCPT ); Thu, 18 Aug 2016 09:33:09 -0400 Subject: Re: [PATCH v5 2/2] usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY To: Felipe Balbi , Peter Chen References: <1471430081-12860-1-git-send-email-heikki.krogerus@linux.intel.com> <1471430081-12860-3-git-send-email-heikki.krogerus@linux.intel.com> <87d1l77e0r.fsf@linux.intel.com> <20160817230058.GA26420@shlinux2> <87wpje60xu.fsf@linux.intel.com> Cc: Heikki Krogerus , Greg KH , Oliver Neukum , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: Guenter Roeck Message-ID: Date: Thu, 18 Aug 2016 06:32:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <87wpje60xu.fsf@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2016 11:33 PM, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: >> On Wed, Aug 17, 2016 at 03:53:24PM +0300, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Heikki Krogerus writes: >>> >>> [...] >>> >>>> +static struct platform_driver wcove_typec_driver = { >>>> + .driver = { >>>> + .name = "bxt_wcove_usbc", >>>> + }, >>>> + .probe = wcove_typec_probe, >>>> + .remove = wcove_typec_remove, >>>> +}; >>>> + >>>> +module_platform_driver(wcove_typec_driver); >>>> + >>>> +MODULE_AUTHOR("Intel Corporation"); >>>> +MODULE_LICENSE("GPL v2"); >>>> +MODULE_DESCRIPTION("WhiskeyCove PMIC USB Type-C PHY driver"); >>> >>> you need to add: >>> >>> MODULE_ALIAS("platform:bxt_wcove_usbc"); >>> >>> otherwise this won't probe() automagically. >>> >> >> What do you mean, Felipe? If there is a platform device named >> "bxt_wcove_usbc", why it will not be probed? > > IIRC default module alias is added based on file name, not > platform_driver name, so this would be > MODULE_ALIAS("platform:typec_wcove") by default... I could be wrong, > really don't remember the details of that now. > AFAIK one either needs MODULE_ALIAS or MODULE_DEVICE_TABLE for platform device autoloading. I have seen many patches along the line of "Add missing MODULE_ALIAS", so I'd be a bit surprised if that was no longer needed. Guenter