From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39DFAC48BCD for ; Wed, 9 Jun 2021 05:12:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E69161287 for ; Wed, 9 Jun 2021 05:12:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233396AbhFIFOu (ORCPT ); Wed, 9 Jun 2021 01:14:50 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:50522 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232153AbhFIFOt (ORCPT ); Wed, 9 Jun 2021 01:14:49 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1595CmVQ063309; Wed, 9 Jun 2021 00:12:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623215568; bh=8nU8dx0W7UHA7c2WDGiyi7oL2CaDsAqar1u6ZM2n30Q=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=IHlXFtRyDtg9r55tenCp+Tf+UKwB2jNb+FPTaIBC1O5uExwWt9dKleJ8baHi07+Uf yLWnM7m1w1huCr+aRRejiCghpNFib4ScawsSSVmXSTv3aDDHoeWZGDGybOWwjWv0aX JqPx2D8xFkRjjEiXtjTX1hEtazl5kfcwjKlufU3g= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1595Cm93054084 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 9 Jun 2021 00:12:48 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 9 Jun 2021 00:12:48 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 9 Jun 2021 00:12:48 -0500 Received: from [10.250.234.148] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1595CjRq124940; Wed, 9 Jun 2021 00:12:46 -0500 Subject: Re: [PATCH] arm64: dts: ti: k3-am642-main: fix ports mac properties To: Grygorii Strashko , Nishanth Menon , Lokesh Vutla , Tero Kristo CC: , , References: <20210608184940.25934-1-grygorii.strashko@ti.com> From: Vignesh Raghavendra Message-ID: Date: Wed, 9 Jun 2021 10:42:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210608184940.25934-1-grygorii.strashko@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/21 12:19 AM, Grygorii Strashko wrote: > The current device tree CPSW3g node adds non-zero "mac-address" property to > the ports, which prevents random MAC address assignment to network devices > if bootloader failed to update DT. This may cause more then one host to > have the same MAC in the network. > > mac-address = [00 00 de ad be ef]; > mac-address = [00 01 de ad be ef]; > > In addition, there is one MAC address available in eFuse registers which > can be used for default port 1. > > Hence, fix ports MAC properties by: > - resetting "mac-address" property to 0 > - adding ti,syscon-efuse = <&main_conf 0x200> to Port 1 > > Fixes: 3753b12877b6 ("arm64: dts: ti: k3-am64-main: Add CPSW DT node") > Signed-off-by: Grygorii Strashko > --- Reviewed-by: Vignesh Raghavendra > arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > index effb9d2e3c25..7f7178a7a055 100644 > --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi > @@ -514,7 +514,8 @@ > ti,mac-only; > label = "port1"; > phys = <&phy_gmii_sel 1>; > - mac-address = [00 00 de ad be ef]; > + mac-address = [00 00 00 00 00 00]; > + ti,syscon-efuse = <&main_conf 0x200>; > }; > > cpsw_port2: port@2 { > @@ -522,7 +523,7 @@ > ti,mac-only; > label = "port2"; > phys = <&phy_gmii_sel 2>; > - mac-address = [00 01 de ad be ef]; > + mac-address = [00 00 00 00 00 00]; > }; > }; > >