From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDEAC83F32 for ; Thu, 31 Aug 2023 12:29:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346252AbjHaM36 (ORCPT ); Thu, 31 Aug 2023 08:29:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231799AbjHaM34 (ORCPT ); Thu, 31 Aug 2023 08:29:56 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C955CFF; Thu, 31 Aug 2023 05:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=iogearbox.net; s=default2302; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=AuoeT0q4LJbl7muZqjyyTpJkzqz+1kv2o9BGttWzdfA=; b=Lt9RdBHrmbU1Mkao1QA3gcXnYe M9KpP2B1pWSPLH+626tGR1/Dc6oK66sR7E1ZpnHZ95/nKwkPQPOLIQ8d1iXSuGI7g+njLLs/qEhVM dQbAbyveGyiF/MxPXdLoNFpN9D7/Lz2oDIICpkmWyRr82WN/J8LwGobTfvzGaSYGOy01mG0ezsRTJ PEFXKEtB12QUWB67nxgDRZsa7Gfz0wGmaZyt1xEcE+jkgkC9cZ0B/02UusnBh/BtR715BmqT61N6Q cAxt/15DGDr5JTp2+M7gevgmhKXVUXoqQf/8q/Krclunplquh2Dzx7K5doqvzuGyMXJGciV57uzsx G2fCf+zA==; Received: from sslproxy01.your-server.de ([78.46.139.224]) by www62.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qbgnw-0003yI-N6; Thu, 31 Aug 2023 14:29:45 +0200 Received: from [85.1.206.226] (helo=linux.home) by sslproxy01.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbgnw-0004pD-KU; Thu, 31 Aug 2023 14:29:44 +0200 Subject: Re: [PATCH bpf-next] selftests/bpf: Include build flavors for install target To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrii Nakryiko , Mykola Lysenko , bpf@vger.kernel.org Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Alexei Starovoitov , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230828183329.546959-1-bjorn@kernel.org> From: Daniel Borkmann Message-ID: Date: Thu, 31 Aug 2023 14:29:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20230828183329.546959-1-bjorn@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.8/27017/Thu Aug 31 09:40:48 2023) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/28/23 8:33 PM, Björn Töpel wrote: > From: Björn Töpel > > When using the "install" or targets depending on install, > e.g. "gen_tar", the BPF machine flavors weren't included. > > A command like: > | make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- O=/workspace/kbuild \ > | HOSTCC=gcc FORMAT= SKIP_TARGETS="arm64 ia64 powerpc sparc64 x86 sgx" \ > | -C tools/testing/selftests gen_tar > would not include bpf/no_alu32, bpf/cpuv4, or bpf/bpf-gcc. > > Include the BPF machine flavors for "install" make target. > > Signed-off-by: Björn Töpel Looks good and BPF CI also seems to be fine with it, wrt INSTDIRS could we use a more appropriate location where we define it? Was thinking sth like: diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index 7c77a21c3371..8b724efb8b7f 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -50,14 +50,17 @@ TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map test test_cgroup_storage \ test_tcpnotify_user test_sysctl \ test_progs-no_alu32 +TEST_INST_SUBDIRS := no_alu32 # Also test bpf-gcc, if present ifneq ($(BPF_GCC),) TEST_GEN_PROGS += test_progs-bpf_gcc +TEST_INST_SUBDIRS += bpf_gcc endif ifneq ($(CLANG_CPUV4),) TEST_GEN_PROGS += test_progs-cpuv4 +TEST_INST_SUBDIRS += cpuv4 endif [...] Thanks, Daniel