From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: "Sam Protsenko" <semen.protsenko@linaro.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Tomasz Figa" <tomasz.figa@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>
Cc: Ryu Euiyoul <ryu.real@samsung.com>,
Tom Gall <tom.gall@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Amit Pundir <amit.pundir@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 3/5] dt-bindings: clock: Add bindings definitions for Exynos850 CMU
Date: Fri, 8 Oct 2021 08:45:38 +0200 [thread overview]
Message-ID: <abe4bdeb-ee15-d8c8-54af-1cdf7282b004@canonical.com> (raw)
In-Reply-To: <20211007194113.10507-4-semen.protsenko@linaro.org>
On 07/10/2021 21:41, Sam Protsenko wrote:
> Clock controller driver is designed to have separate instances for each
> particular CMU. So clock IDs in this bindings header also start from 1
> for each CMU.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Changes in v2:
> - Added all clock ids
> - Added CLK_ prefix for all clock constants
> - Added R-b tag by Krzysztof Kozlowski
> - Added Ack tag by Rob Herring
>
> include/dt-bindings/clock/exynos850.h | 141 ++++++++++++++++++++++++++
> 1 file changed, 141 insertions(+)
> create mode 100644 include/dt-bindings/clock/exynos850.h
>
> diff --git a/include/dt-bindings/clock/exynos850.h b/include/dt-bindings/clock/exynos850.h
> new file mode 100644
> index 000000000000..a44c5f91d3c7
> --- /dev/null
> +++ b/include/dt-bindings/clock/exynos850.h
> @@ -0,0 +1,141 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
The bindings are preferred to be under GPL-2.0+BSD. I don't know about
such policy for the headers but it seems reasonable - allows re-usage in
other systems. Do you mind licensing it under:
GPL-2.0-only or BSD-2-Clause
?
Best regards,
Krzysztof
> +/*
> + * Copyright (C) 2021 Linaro Ltd.
> + * Author: Sam Protsenko <semen.protsenko@linaro.org>
> + *
> + * Device Tree binding constants for Exynos850 clock controller.
> + */
> +
> +#ifndef _DT_BINDINGS_CLOCK_EXYNOS_850_H
> +#define _DT_BINDINGS_CLOCK_EXYNOS_850_H
> +
> +/* CMU_TOP */
next prev parent reply other threads:[~2021-10-08 6:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 19:41 [PATCH v2 0/5] clk: samsung: Introduce Exynos850 SoC clock driver Sam Protsenko
2021-10-07 19:41 ` [PATCH v2 1/5] clk: samsung: clk-pll: Implement pll0822x PLL type Sam Protsenko
2021-10-07 19:41 ` [PATCH v2 2/5] clk: samsung: clk-pll: Implement pll0831x " Sam Protsenko
2021-10-07 19:41 ` [PATCH v2 3/5] dt-bindings: clock: Add bindings definitions for Exynos850 CMU Sam Protsenko
2021-10-08 6:45 ` Krzysztof Kozlowski [this message]
2021-10-08 15:31 ` Sam Protsenko
2021-10-15 0:47 ` Chanwoo Choi
2021-10-07 19:41 ` [PATCH v2 4/5] dt-bindings: clock: Document Exynos850 CMU bindings Sam Protsenko
2021-10-08 6:46 ` Krzysztof Kozlowski
2021-10-07 19:41 ` [PATCH v2 5/5] clk: samsung: Introduce Exynos850 clock driver Sam Protsenko
2021-10-08 6:54 ` Krzysztof Kozlowski
2021-10-08 15:36 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abe4bdeb-ee15-d8c8-54af-1cdf7282b004@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=amit.pundir@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=pawel.mikolaj.chmiel@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryu.real@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=sumit.semwal@linaro.org \
--cc=tom.gall@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®