From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 674173793C3 for ; Sat, 28 Mar 2026 12:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774701857; cv=none; b=D4LlMj7k8SPORSUuHEFE4BJonvAsWo8dwftmoXa2JHy2OfadWxeJXYjljbLLHFYJn+7FX8c/uaQlH7TJOXW8K5S7WdyYVT0n6KWOePXEvC2JocB+KDR8x1GDIv6iPw91Wa+qZyZhxZRv1CtBPVVtHbXEzbP0Qd7oFTsvKJYaWNI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774701857; c=relaxed/simple; bh=79/1UCAkXJ1fRlik+68IZw07RZgWagd69fiPAJ12N9A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X1gsgapE2fzuwVLDQevacLwU5sXE9x9T+K/9Wzc5h6rHqCf395r5YEx64g8caWf2DbyiXmSitUswojoqxUqnklTZJgSXG2qJK+wIYG2yw74QgsozV1PmV7+uMZHgWAxThDK1HU5h3ielJh0dOta7ucLdYi17z6Z2k2c5hT4M9JA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dl1uAITd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dl1uAITd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91A71C4CEF7; Sat, 28 Mar 2026 12:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774701857; bh=79/1UCAkXJ1fRlik+68IZw07RZgWagd69fiPAJ12N9A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dl1uAITdiByJc+r1+hUxJVh+hRdNG4RTjBoSTWp3vx0qwAar2zle63hTvqjpqkqmq TKmvid4fmzCREO4y2CJTWjoMX3tvvvK5pZ9eo6EFv/G2YwMn2cMTLoAm7Fy+MQt+lK YZPGr/Hwx8dmpOLdpY/Nl/Dh07scwVTxWvOO0JNl8AUJ+PyK0/kdsco58BzXlmcUwt mbIr/ejLI/yEIB4OL+bFwPLdI4PnA4KGKgiBTV7fIZgwAdcdY1xXRSzCCakoOB1wcK +oICL10lWhXTNurMEa7YLuUTiR6U2c0Fe2vtSJRLgCM1yS5I12jkwYnL1NgfGbS55O i1vuPREYTpj/Q== Message-ID: Date: Sat, 28 Mar 2026 13:44:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: fsl: qe_ports_ic: Add missing cleanup on device removal To: Felix Gu , Qiang Zhao Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260310-qe_ports_ic-v1-1-608293026561@gmail.com> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260310-qe_ports_ic-v1-1-608293026561@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 09/03/2026 à 17:25, Felix Gu a écrit : > [Vous ne recevez pas souvent de courriers de ustc.gu@gmail.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > Add a devm action handler to properly clean up the irq_domain and > chained handler when the device is removed. > > Fixes: f0bcd784e1b7 ("soc: fsl: qe: Add an interrupt controller for QUICC Engine Ports") > Signed-off-by: Felix Gu > --- > drivers/soc/fsl/qe/qe_ports_ic.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/drivers/soc/fsl/qe/qe_ports_ic.c b/drivers/soc/fsl/qe/qe_ports_ic.c > index 8e2107e2cde5..5e3fae19f314 100644 > --- a/drivers/soc/fsl/qe/qe_ports_ic.c > +++ b/drivers/soc/fsl/qe/qe_ports_ic.c > @@ -17,6 +17,7 @@ > struct qepic_data { > void __iomem *reg; > struct irq_domain *host; > + int irq; > }; > > static void qepic_mask(struct irq_data *d) > @@ -92,11 +93,18 @@ static const struct irq_domain_ops qepic_host_ops = { > .map = qepic_host_map, > }; > > +static void qepic_remove(void *res) > +{ > + struct qepic_data *data = res; > + > + irq_set_chained_handler_and_data(data->irq, NULL, NULL); > + irq_domain_remove(data->host); > +} > + > static int qepic_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct qepic_data *data; > - int irq; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > if (!data) > @@ -106,17 +114,18 @@ static int qepic_probe(struct platform_device *pdev) > if (IS_ERR(data->reg)) > return PTR_ERR(data->reg); > > - irq = platform_get_irq(pdev, 0); > - if (irq < 0) > - return irq; > + data->irq = platform_get_irq(pdev, 0); > + if (data->irq < 0) > + return data->irq; > > data->host = irq_domain_add_linear(dev->of_node, 32, &qepic_host_ops, data); > if (!data->host) > return -ENODEV; > > - irq_set_chained_handler_and_data(irq, qepic_cascade, data); > + irq_set_chained_handler_and_data(data->irq, qepic_cascade, data); > + > + return devm_add_action_or_reset(dev, qepic_remove, data); > > - return 0; > } > > static const struct of_device_id qepic_match[] = { > > --- > base-commit: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f > change-id: 20260310-qe_ports_ic-ca4c98bd1c4f > > Best regards, > -- > Felix Gu > Applied, thanks.