From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C46F634E74F for ; Mon, 16 Mar 2026 08:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773648510; cv=none; b=DPdsKsxD6E/4E52fc1YflH47+KXSB9HZ3GtkoMVbav/9k3jx7pUzRUPr6jVZAWqCIfAY1puDLrECYFsPEcwnLizLsbnlytWGDBbI7Su/voQRievJKWwrtOwFiq4AeE6PJqhcu55rTaK99NM0PNYcWVK2tLffu5xUtmXhwfTa9N8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773648510; c=relaxed/simple; bh=x1uU4O6ERf7uSMhZA+GDKpID7bpPyS29bfrvbbIt+58=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jyKGWVPK9Di9K6U1f0qpniOYeKSVPdmtxENd01d/cilXKy6ZNZHVqVcucmni427bRYShghflwNFy6tTqr2woB7YhW5gtzr6OEbqI1z42SVQKBKX/BNDujg5WR5uG3T4X/LzDuBMfTON0hRMgZw75b25/EKPHdMBLQrsQR9wTJfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Jb8r+CUA; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Jb8r+CUA" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso50094975e9.0 for ; Mon, 16 Mar 2026 01:08:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773648507; x=1774253307; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gM8VLpK7o2tGvr7MARawA5A/lh/4eDEJKA70VNN8UJ0=; b=Jb8r+CUA/4QKbRlV+vbcwmDcp7cDy/TfhdZgfrt85Tmrmy5bqd53iTUoTs+/T+oVvL 0AJUbjndWk6xC7UcSox15au2h9ayJigpl4idpujBnqfHL284i4kN4PeVIoLecK6kfILQ NALgjSkYkZfEECKvDckFo6wVuVGXERQkG4zbl/jjEMrXU5MtLuYQ73njKbPMSVDGBQk2 7/D0oJVxOAEvVk36VPsvw5AaN0yZYN+RuQRCCwvD+ZN8sRLE88rBT7p6dChmA6pg03bq dn62yTqUr2gsZhuABaWMLoqeFciiCZbOs9F8akSvb+giNFtii+8DT8QkKNYm1HMZjutG OjHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773648507; x=1774253307; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gM8VLpK7o2tGvr7MARawA5A/lh/4eDEJKA70VNN8UJ0=; b=d5s/f2WC4fonN6YN/NyYT9BzQKgTGM+Dat58ZjdRsFTsyk6GHf264JFbCrw1rlEBXc oHHStGhlIYect938V0Aw66XGY60OCTy7oN2yX8sIz1yFwCEyX+sVk0yWwthrAdMvA0dS mbQhnjri5WASDekUbhP1V7E7SNoQHHNj0VefrTNMe2/f6aUdWo9OrCyxmDrqXNYHopeH UaTPCE2CDIDi8IDpaMzf3uQVAPiPzFyf1L8F4g1m18MU8WivrN2nLzKnOFGAh9EFaXQv JDDQmraumPVvgrufNI6uwdPDGCRtA8x+6TCJReEhXZr1xYZ5wjMekpT5pRzgyVsS0JMW DWzQ== X-Forwarded-Encrypted: i=1; AJvYcCVWAejCskJuSl1wusly0mnpD4wyT9XQ7Wala8iuzV6XI6IdXK1U5gR9zwDa6jOYGCYDrGAKIzUcuSj6KMU=@vger.kernel.org X-Gm-Message-State: AOJu0YyvUD3FX9Vk+odsvqzYRJ7NAfUBtw0s5sbmch397j/lJA7l/bww y1Iv/pLE2RSYVORyKls+jOJaDfQ/fYOB2SdpQOpJ9OJl2C9wdxlZRM4L9gbS+Rh5eEw= X-Gm-Gg: ATEYQzzDOWEP74//QEwVF8iPqWrfeHPpNUW4pUWX25RcZ1P4pmZscB4Nt8cFTiJvMvu f8cqO8bWVWZhzG2XTk6JOsWoSFoxjsUJ1ZdyAvwm3ed1OHvKTGyrE+1ZCrRsc25nHaPd/lu/9AV Md6byttv2BBGW+V1PBit5FDxFw928nfsConZ8sMDpRdWqkKwzv5ZhoNWPPM8ZOfAppHAeLEKss9 gxoAWvjtXcgXBX0EVghL7L2/EllX4sjxQegkWs9inChbRM0pZz7AjI8K3DsFoz0gG9JDNlNe05k 8iQIvT+zLNotSs5NMycH4LHXWOlfVRqBgJWe5iDemb0tJmIHsl6VS2aIL8Mg0c4PxrKGBXUEemH e91N7P41XsO3FDo9Wn+W6j1lMBqHTzOs5RrrKfW00SOFFTLHMwn1L5S1r1hTi4G11UHLUuQPVAI Eg3x7JVwAZFwEw0kV7NUPL4qtXVqY6 X-Received: by 2002:a05:600c:8a09:10b0:483:badb:618e with SMTP id 5b1f17b1804b1-485566d6e33mr138080005e9.8.1773648506976; Mon, 16 Mar 2026 01:08:26 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48541ac17f2sm456509905e9.6.2026.03.16.01.08.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 01:08:26 -0700 (PDT) Date: Mon, 16 Mar 2026 11:08:23 +0300 From: Dan Carpenter To: Tomasz Unger Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging/media/av7110: update FIXME comment for signal strength Message-ID: References: <20260312-staging-cleanup-v1-1-fdb9f8367e3f.ref@yahoo.pl> <20260312-staging-cleanup-v1-1-fdb9f8367e3f@yahoo.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312-staging-cleanup-v1-1-fdb9f8367e3f@yahoo.pl> On Thu, Mar 12, 2026 at 07:21:17PM +0100, Tomasz Unger wrote: > Update the FIXME comment to provide more detail about the future > implementation for computing the signal strength based on the tuner RSSI. > > Signed-off-by: Tomasz Unger > --- > drivers/staging/media/av7110/av7110_v4l.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/av7110/av7110_v4l.c b/drivers/staging/media/av7110/av7110_v4l.c > index 200a7a29ea31..a64761979609 100644 > --- a/drivers/staging/media/av7110/av7110_v4l.c > +++ b/drivers/staging/media/av7110/av7110_v4l.c > @@ -310,7 +310,7 @@ static int vidioc_g_tuner(struct file *file, void *fh, struct v4l2_tuner *t) > V4L2_TUNER_CAP_LANG1 | V4L2_TUNER_CAP_LANG2 | V4L2_TUNER_CAP_SAP; > t->rangelow = 772; /* 48.25 MHZ / 62.5 kHz = 772, see fi1216mk2-specs, page 2 */ > t->rangehigh = 13684; /* 855.25 MHz / 62.5 kHz = 13684 */ > - /* FIXME: add the real signal strength here */ > + /* TODO: compute based on tuner RSSI */ This seems reasonable and also pointless. Is this AI? regards, dan carpenter > t->signal = 0xffff; > t->afc = 0; > > > ---