From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C538627EFF7; Fri, 13 Mar 2026 16:04:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773417885; cv=none; b=pm4NIpjwpvyNyPMhXrExAE50aw67WqOBH4KplZHcc8YGkoYrmqNqLihkuN9t47lgdIN7KLR3QJOZg4nl1M0AhiNfWA0YnIu3gKduGFZXl6w6TfAE/U0gww5y+xwF1oJUCrnRS3OP1/auJgBTlBGToh8+aubGNp5zOiwRQfTnzA0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773417885; c=relaxed/simple; bh=jYeg5qbLi0FFttCEkiPww5nskQYsa0sggqvW+/9q3WM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=agm8RqdMtk/kLjL66RsiIejEDw8E++zz/kI+jayIdZ3dbomE8zOsOdlb5lIJ/CNZG+h129xAXHlWuIcEuBkcnnPxFSnelUe2hCmD2aEejyiJ8oW/wDRtQ6swyEOXPiAmz2huatbSbtMGe7EOVdehkQXB+GUvNiJivkGkmM6K+DU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ZnV2uCmt; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZnV2uCmt" Received: from [192.168.0.43] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A867FD0; Fri, 13 Mar 2026 17:03:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773417813; bh=jYeg5qbLi0FFttCEkiPww5nskQYsa0sggqvW+/9q3WM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZnV2uCmtio2nUBtgi5Ia1sEMk9mTRWinTgKhkSt3vzyp5CKVoH1yS4T+XACCgU8V+ kxtyu3ozS14KWYM8eM/7fmFezj6YgkusEfqZcXpg7mnZ1n8V7uAa4B5S0JGO4Gu5Ug 2kUAZ8qjNYBeNQ2B46zHKL4ASuHp0QqC+CgmFAXA= Message-ID: Date: Fri, 13 Mar 2026 16:04:39 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] media: mali-c55: Bypass the Iridix Tonemap engine To: Jacopo Mondi , Anthony McGivern , Vincenzo Frascino , Nayden Kanchev , Konstantin Babin , =?UTF-8?Q?Barnab=C3=A1s_P=C5=91cze?= , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313-mali-c55-fixes-v7-0-v2-0-885c07961f30@ideasonboard.com> <20260313-mali-c55-fixes-v7-0-v2-5-885c07961f30@ideasonboard.com> Content-Language: en-US From: Dan Scally In-Reply-To: <20260313-mali-c55-fixes-v7-0-v2-5-885c07961f30@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi On 13/03/2026 14:54, Jacopo Mondi wrote: > The Iridix Tonemap engine, if not bypassed, applies a digital gain > in order to compensate under-exposed images. > > This however breaks the exposure and gain regulation performed on the > sensor. > > If the Iridix Tonemap has to be used, it need to be supported in the > ISP uAPI and properly configured by userspace. > > As the driver doesn't support it at the moment, bypass it by default. > > Signed-off-by: Jacopo Mondi Reviewed-by: Daniel Scally > --- > drivers/media/platform/arm/mali-c55/mali-c55-params.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-params.c b/drivers/media/platform/arm/mali-c55/mali-c55-params.c > index 773e5b6a2b7e..b9fc904a3844 100644 > --- a/drivers/media/platform/arm/mali-c55/mali-c55-params.c > +++ b/drivers/media/platform/arm/mali-c55/mali-c55-params.c > @@ -825,6 +825,11 @@ void mali_c55_params_init_isp_config(struct mali_c55 *mali_c55, > /* Disable the temper module's DMA read/write */ > mali_c55_ctx_write(mali_c55, MALI_C55_REG_TEMPER_DMA_IO, 0x0); > > + /* Disable IRIDIX module. */ > + mali_c55_ctx_update_bits(mali_c55, MALI_C55_REG_BYPASS_3, > + MALI_C55_REG_BYPASS_3_IRIDIX, > + MALI_C55_REG_BYPASS_3_IRIDIX); > + > /* Bypass the colour noise reduction */ > mali_c55_ctx_write(mali_c55, MALI_C55_REG_BYPASS_4, > MALI_C55_REG_BYPASS_4_CNR); >